Skip to content

MT8192 IOMMU support

Yong Wu linux-arm-kernel linux-devicetree linux-iommu linux-mediatek lkml 8 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v6 Latest33 patches 18 repliesIn review
  2. v5 posting 2/227 patches 29 repliesSuperseded
  3. v4 posting 2/224 patches 23 repliesSuperseded
Earlier versions · 5
VersionPostedPatchesRepliesStatus
v5 posting 1/23 patches4 repliesApplied
v4 posting 1/23 patches4 repliesSuperseded
v324 patches30 repliesSuperseded
v223 patches6 repliesSuperseded
v121 patches20 repliesSuperseded

Patches in v6 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/33dt-bindings: iommu: mediatek: Convert IOMMU to DT schemaDocumentation/devicetree/bindings/iommu/mediatek,iommu.txt Documentation/devicetree/bindings/iommu/mediatek,iommu.yaml+167 -1050 replies
2/33dt-bindings: memory: mediatek: Add a common memory header fileinclude/dt-bindings/memory/mt2712-larb-port.h include/dt-bindings/memory/mt6779-larb-port.h include/dt-bindings/memory/mt8167-larb-port.h +3 more+20 -50 replies
3/33dt-bindings: memory: mediatek: Extend LARB_NR_MAX to 32Documentation/devicetree/bindings/iommu/mediatek,iommu.yaml include/dt-bindings/memory/mtk-memory-port.h+3 -30 replies
4/33dt-bindings: memory: mediatek: Rename header guard for SMI header fileinclude/dt-bindings/memory/mt2701-larb-port.h include/dt-bindings/memory/mt2712-larb-port.h include/dt-bindings/memory/mt6779-larb-port.h +3 more+12 -120 replies
5/33dt-bindings: mediatek: Add binding for mt8192 IOMMUDocumentation/devicetree/bindings/iommu/mediatek,iommu.yaml include/dt-bindings/memory/mt8192-larb-port.h+260 -10 replies
6/33of/device: Move dma_range_map before of_iommu_configuredrivers/of/device.c+2 -16 replies
7/33iommu: Avoid reallocate default domain for a groupdrivers/iommu/iommu.c+2 -17 replies
8/33iommu/mediatek: Use the common mtk-memory-port.hdrivers/iommu/mtk_iommu.c drivers/iommu/mtk_iommu.h drivers/memory/mtk-smi.c +1 more+2 -90 replies
9/33iommu/io-pgtable-arm-v7s: Use ias to check the valid iova in unmapdrivers/iommu/io-pgtable-arm-v7s.c+1 -10 replies
10/33iommu/io-pgtable-arm-v7s: Extend PA34 for MediaTekdrivers/iommu/io-pgtable-arm-v7s.c drivers/iommu/mtk_iommu.c include/linux/io-pgtable.h+10 -50 replies
11/33iommu/io-pgtable-arm-v7s: Clarify LVL_SHIFT/BITS macrodrivers/iommu/io-pgtable-arm-v7s.c+3 -50 replies
12/33iommu/io-pgtable-arm-v7s: Add cfg as a param in some macrosdrivers/iommu/io-pgtable-arm-v7s.c+18 -180 replies
13/33iommu/io-pgtable-arm-v7s: Quad lvl1 pgtable for MediaTekdrivers/iommu/io-pgtable-arm-v7s.c+4 -30 replies
14/33iommu/mediatek: Add a flag for iova 34bits casedrivers/iommu/mtk_iommu.c+2 -10 replies
15/33iommu/mediatek: Update oas for v7sdrivers/iommu/mtk_iommu.c+5 -10 replies
16/33iommu/mediatek: Move hw_init into attach_devicedrivers/iommu/mtk_iommu.c+7 -60 replies
17/33iommu/mediatek: Add error handle for mtk_iommu_probedrivers/iommu/mtk_iommu.c+19 -40 replies
18/33iommu/mediatek: Add device link for smi-common and m4udrivers/iommu/mtk_iommu.c drivers/iommu/mtk_iommu.h+25 -30 replies
19/33iommu/mediatek: Add pm runtime callbackdrivers/iommu/mtk_iommu.c+5 -30 replies
20/33iommu/mediatek: Add power-domain operationdrivers/iommu/mtk_iommu.c+34 -50 replies
21/33iommu/mediatek: Support up to 34bit iova in tlb flushdrivers/iommu/mtk_iommu.c+8 -20 replies
22/33iommu/mediatek: Support report iova 34bit translation fault in ISRdrivers/iommu/mtk_iommu.c+15 -20 replies
23/33iommu/mediatek: Adjust the structuredrivers/iommu/mtk_iommu.c+11 -90 replies
24/33iommu/mediatek: Move domain_finalise into attach_devicedrivers/iommu/mtk_iommu.c+12 -190 replies
25/33iommu/mediatek: Move geometry.aperture updating into domain_finalisedrivers/iommu/mtk_iommu.c+4 -30 replies
26/33iommu/mediatek: Add iova_region structuredrivers/iommu/mtk_iommu.c drivers/iommu/mtk_iommu.h+24 -00 replies
27/33iommu/mediatek: Add get_domain_id from dev->dma_range_mapdrivers/iommu/mtk_iommu.c+41 -10 replies
28/33iommu/mediatek: Support for multi domainsdrivers/iommu/mtk_iommu.c drivers/iommu/mtk_iommu.h+29 -120 replies
29/33iommu/mediatek: Add iova reserved functiondrivers/iommu/mtk_iommu.c+31 -00 replies
30/33iommu/mediatek: Support master use iova over 32bitdrivers/iommu/mtk_iommu.c drivers/memory/mtk-smi.c include/soc/mediatek/smi.h+20 -60 replies
31/33iommu/mediatek: Remove unnecessary check in attach_devicedrivers/iommu/mtk_iommu.c+0 -60 replies
32/33iommu/mediatek: Add mt8192 supportdrivers/iommu/mtk_iommu.c drivers/iommu/mtk_iommu.h+23 -00 replies
33/33MAINTAINERS: Add entry for MediaTek IOMMUMAINTAINERS+9 -00 replies

Reviews trailers per patch

14 of 33 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchRob HerringKrzysztof KozlowskiRobin MurphyWill DeaconChun-Kuang HuTomasz Figa
SeriesR-b
1/33R-b
2/33A-b A-b
3/33A-b A-b
4/33A-b A-b
5/33R-b A-b
6/33R-b
7/33
8/33A-b
9/33R-b
10/33R-b A-b
11/33R-b
12/33R-b A-b
13/33R-b
14/33
15/33
16/33
17/33
18/33
19/33
20/33
21/33
22/33
23/33
24/33
25/33
26/33
27/33
28/33
29/33
30/33A-b
31/33
32/33
33/33R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 6 reviewers.

Read the v6 thread

Cover letter [PATCH v6 00/33] MT8192 IOMMU support

This patch mainly adds support for mt8192 Multimedia IOMMU and SMI.

mt8192 also is MTK IOMMU gen2 which uses ARM Short-Descriptor translation table format. The M4U-SMI HW diagram is as below:

                          EMI
                           |
                          M4U
                           |
                      ------------
                       SMI Common
                      ------------
                           |
  +-------+------+------+----------------------+-------+
  |       |      |      |       ......         |       |
  |       |      |      |                      |       |
larb0   larb1  larb2  larb4     ......      larb19   larb20
disp0   disp1   mdp    vdec                   IPE      IPE

All the connections are HW fixed, SW can NOT adjust it.

Comparing with the preview SoC, this patchset mainly adds two new functions:
a) add iova 34 bits support.
b) add multi domains support since several HW has the special iova region requirement.

change note:
v6:a) base on v5.11-rc1. and tlb v4:

      https://lore.kernel.org/linux-mediatek/[email protected]/T/#t 

b) Remove the "domain id" definition in the binding header file. Get the domain from dev->dma_range_map.
After this, Change many codes flow.
c) the patchset adds a new common file(mtk_smi-larb-port.h). This version changes that name into mtk-memory-port.h which reflect its file path. This only changes the file name. no other change. thus I keep all the Reviewed-by Tags.
(another reason is that we will add some iommu ports unrelated with
smi-larb)
d) Refactor the power-domain flow suggestted by Tomasz.
e) Some other small fix. use different oas for different soc; Change the macro for 34bit iova tlb flush.

v5: https://lore.kernel.org/linux-iommu/[email protected]/
a) Add a new patch for the header guard for smi-larb-port.h in [5/27].
b) Add a new patch for error handle for iommu_device_sysfs_add and
iommu_device_register[15/27].

    c) Add a flag for the iova "ias == 34" case. the previous SoC still keep

32bits to save 16KB*3 lvl1 pgtable memory[13/27].
d) Add include <linux/bitfield.h> for FIELD_GET build fail.
e) In PM power domain patch, add a checking "pm_runtime_enabled" when call
pm_runtime_get_sync for non power-domain case. and add a pm_runtime_put_noidle while pm_runtime_get_sync fail case.

v4: https://lore.kernel.org/linux-iommu/[email protected]/
a) rebase on v5.10-rc1
b) Move the smi part to a independent patchset.
c) Improve v7s code from Robin and Will.
d) Add a mediatek iommu entry patch in MAINTAIN.

v3: https://lore.kernel.org/linux-iommu/[email protected]/
a) Fix DT schema issue commented from Rob.
b) Fix a v7s issue. Use "_lvl" instead of "_l" in the macro(ARM_V7S_PTES_PER_LVL) since it is called in ARM_V7S_LVL_IDX which has already used "_l".
c) Fix a PM suspend issue: Avoid pm suspend in pm runtime case.

v2: https://lore.kernel.org/linux-iommu/[email protected]/
a) Convert IOMMU/SMI dt-binding to DT schema.
b) Fix some comment from Pi-Hsun and Nicolas. like use generic_iommu_put_resv_regions.
c) Reword some comment, like add how to use domain-id.

v1: https://lore.kernel.org/linux-iommu/[email protected]/

Yong Wu (33):
dt-bindings: iommu: mediatek: Convert IOMMU to DT schema
dt-bindings: memory: mediatek: Add a common memory header file
dt-bindings: memory: mediatek: Extend LARB_NR_MAX to 32
dt-bindings: memory: mediatek: Rename header guard for SMI header file
dt-bindings: mediatek: Add binding for mt8192 IOMMU of/device: Move dma_range_map before of_iommu_configure
iommu: Avoid reallocate default domain for a group iommu/mediatek: Use the common mtk-memory-port.h iommu/io-pgtable-arm-v7s: Use ias to check the valid iova in unmap iommu/io-pgtable-arm-v7s: Extend PA34 for MediaTek iommu/io-pgtable-arm-v7s: Clarify LVL_SHIFT/BITS macro iommu/io-pgtable-arm-v7s: Add cfg as a param in some macros iommu/io-pgtable-arm-v7s: Quad lvl1 pgtable for MediaTek iommu/mediatek: Add a flag for iova 34bits case iommu/mediatek: Update oas for v7s
iommu/mediatek: Move hw_init into attach_device iommu/mediatek: Add error handle for mtk_iommu_probe iommu/mediatek: Add device link for smi-common and m4u iommu/mediatek: Add pm runtime callback
iommu/mediatek: Add power-domain operation
iommu/mediatek: Support up to 34bit iova in tlb flush iommu/mediatek: Support report iova 34bit translation fault in ISR iommu/mediatek: Adjust the structure
iommu/mediatek: Move domain_finalise into attach_device iommu/mediatek: Move geometry.aperture updating into domain_finalise iommu/mediatek: Add iova_region structure
iommu/mediatek: Add get_domain_id from dev->dma_range_map iommu/mediatek: Support for multi domains
iommu/mediatek: Add iova reserved function
iommu/mediatek: Support master use iova over 32bit iommu/mediatek: Remove unnecessary check in attach_device iommu/mediatek: Add mt8192 support
MAINTAINERS: Add entry for MediaTek IOMMU

 .../bindings/iommu/mediatek,iommu.txt         | 105 -----
 .../bindings/iommu/mediatek,iommu.yaml        | 183 +++++++++
 MAINTAINERS                                   |   9 +
 drivers/iommu/io-pgtable-arm-v7s.c            |  56 +--
 drivers/iommu/iommu.c                         |   3 +-
 drivers/iommu/mtk_iommu.c                     | 366 ++++++++++++++----
 drivers/iommu/mtk_iommu.h                     |  12 +-
 drivers/memory/mtk-smi.c                      |   8 +
 drivers/of/device.c                           |   3 +-
 include/dt-bindings/memory/mt2701-larb-port.h |   4 +-
 include/dt-bindings/memory/mt2712-larb-port.h |   6 +-
 include/dt-bindings/memory/mt6779-larb-port.h |   6 +-
 include/dt-bindings/memory/mt8167-larb-port.h |   6 +-
 include/dt-bindings/memory/mt8173-larb-port.h |   6 +-
 include/dt-bindings/memory/mt8183-larb-port.h |   6 +-
 include/dt-bindings/memory/mt8192-larb-port.h | 243 ++++++++++++
 include/dt-bindings/memory/mtk-memory-port.h  |  15 +
 include/linux/io-pgtable.h                    |   4 +-
 include/soc/mediatek/smi.h                    |   3 +-
 19 files changed, 810 insertions(+), 234 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/iommu/mediatek,iommu.txt
 create mode 100644 Documentation/devicetree/bindings/iommu/mediatek,iommu.yaml
 create mode 100644 include/dt-bindings/memory/mt8192-larb-port.h
 create mode 100644 include/dt-bindings/memory/mtk-memory-port.h
Signature · 7 lines
2.18.0


_______________________________________________
iommu mailing list
[email protected]
https://lists.linuxfoundation.org/mailman/listinfo/iommu