perf metric: Add support to reuse metric
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
Changes in v4 from the cover letter
- removed acks from patch because it changed a bit
with the last fixes:
perf metric: Collect referenced metrics in struct metric_ref_node
- fixed runtime metrics [Kajol Jain]
- increased recursion depth [Paul A. Clarke]
- changed patches due to dependencies:
perf metric: Collect referenced metrics in struct metric_ref_node perf metric: Add recursion check when processing nested metrics perf metric: Rename struct egroup to metric
perf metric: Rename group_list to metric_list
Patches in v4 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/19 | perf metric: Fix memory leak in expr__add_id functiontools/ | +2 | 0 replies | |
| 2/19 | perf metric: Add expr__add_id functiontools/ tools/ tools/ | +27 | 0 replies | |
| 3/19 | perf metric: Change expr__get_id to return struct expr_id_datatools/ tools/ tools/ | +14 | 0 replies | |
| 4/19 | perf metric: Add expr__del_id functiontools/ tools/ | +14 | 0 replies | |
| 5/19 | perf metric: Add macros for iterating map eventstools/ | +40 | 0 replies | |
| 6/19 | perf metric: Add add_metric functiontools/ | +36 | 0 replies | |
| 7/19 | perf metric: Rename __metricgroup__add_metric to __add_metrictools/ | +6 | 0 replies | |
| 8/19 | perf metric: Collect referenced metrics in struct metric_ref_nodetools/ | +156 | 0 replies | |
| 9/19 | perf metric: Collect referenced metrics in struct metric_exprtools/ tools/ | +38 | 0 replies | |
| 10/19 | perf metric: Add referenced metrics to hash datatools/ tools/ tools/ | +80 | 0 replies | |
| 11/19 | perf metric: Compute referenced metricstools/ tools/ tools/ | +36 | 0 replies | |
| 12/19 | perf metric: Add events for the current listtools/ | +6 | 0 replies | |
| 13/19 | perf metric: Add cache_miss_cycles to metric parse testtools/ | +33 | 0 replies | |
| 14/19 | perf metric: Add DCache_L2 to metric parse testtools/ | +71 | 0 replies | |
| 15/19 | perf metric: Add recursion check when processing nested metricstools/ tools/ tools/ +1 more | +149 | 0 replies | |
| 16/19 | perf metric: Make compute_single function more precisetools/ | +13 | 0 replies | |
| 17/19 | perf metric: Add metric group testtools/ | +46 | 0 replies | |
| 18/19 | perf metric: Rename struct egroup to metrictools/ | +71 | 0 replies | |
| 19/19 | perf metric: Rename group_list to metric_listtools/ | +21 | 0 replies |
Reviews trailers per patch
17 of 19 patches have a Reviewed-by or Acked-by.
| Patch | Ian Rogers | Kajol Jain | Paul A. Clarke |
|---|---|---|---|
| Series | T-b | ||
| 1/19 | A-b | ||
| 2/19 | A-b | R-b | |
| 3/19 | A-b | R-b | |
| 4/19 | A-b | R-b | |
| 5/19 | A-b | R-b | |
| 6/19 | A-b | R-b | |
| 7/19 | A-b | R-b | |
| 8/19 | |||
| 9/19 | A-b | R-b | |
| 10/19 | A-b | R-b | |
| 11/19 | A-b | R-b | |
| 12/19 | A-b | R-b | |
| 13/19 | A-b | R-b | |
| 14/19 | A-b | R-b | |
| 15/19 | A-b | R-b | |
| 16/19 | |||
| 17/19 | A-b | R-b | |
| 18/19 | A-b | R-b | |
| 19/19 | A-b | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.
Cover letter [PATCHv4 00/19] perf metric: Add support to reuse metric
hi,
this patchset is adding the support to reused metric in another metric.
For example, to define IPC by using CPI with change like:
{
"BriefDescription": "Instructions Per Cycle (per Logical Processor)",
- "MetricExpr": "INST_RETIRED.ANY / CPU_CLK_UNHALTED.THREAD",
+ "MetricExpr": "1/CPI",
"MetricGroup": "TopDownL1",
"MetricName": "IPC"
},I won't be able to find all the possible places we could use this at, so I wonder you guys (who was asking for this) would try it and come up with comments if there's something missing or we could already use it at some places.
It's based on Arnaldo's tmp.perf/core.
v4 changes:
- removed acks from patch because it changed a bit
with the last fixes:
perf metric: Collect referenced metrics in struct metric_ref_node
- fixed runtime metrics [Kajol Jain]
- increased recursion depth [Paul A. Clarke]
- changed patches due to dependencies:
perf metric: Collect referenced metrics in struct metric_ref_node perf metric: Add recursion check when processing nested metrics perf metric: Rename struct egroup to metric
perf metric: Rename group_list to metric_list
Also available in here:
git://git.kernel.org/pub/scm/linux/kernel/git/jolsa/perf.git
perf/metric
thanks,
jirka
---
Jiri Olsa (19):
perf metric: Fix memory leak in expr__add_id function perf metric: Add expr__add_id function
perf metric: Change expr__get_id to return struct expr_id_data perf metric: Add expr__del_id function
perf metric: Add macros for iterating map events
perf metric: Add add_metric function
perf metric: Rename __metricgroup__add_metric to __add_metric perf metric: Collect referenced metrics in struct metric_ref_node perf metric: Collect referenced metrics in struct metric_expr perf metric: Add referenced metrics to hash data
perf metric: Compute referenced metrics
perf metric: Add events for the current list
perf metric: Add cache_miss_cycles to metric parse test perf metric: Add DCache_L2 to metric parse test
perf metric: Add recursion check when processing nested metrics perf metric: Make compute_single function more precise perf metric: Add metric group test
perf metric: Rename struct egroup to metric
perf metric: Rename group_list to metric_list
tools/perf/tests/parse-metric.c | 206 +++++++++++++++++++++++++++++++++++++++++++++++++---- tools/perf/util/expr.c | 143 ++++++++++++++++++++++++++++++++----- tools/perf/util/expr.h | 30 +++++++- tools/perf/util/expr.y | 16 +++-- tools/perf/util/metricgroup.c | 466 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++------------------------ tools/perf/util/metricgroup.h | 6 ++ tools/perf/util/stat-shadow.c | 20 ++++-- 7 files changed, 751 insertions(+), 136 deletions(-)