Skip to content

qom: HMP command fixes

Markus Armbruster qemu-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest5 patches 12 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5qdev: Fix device_add DRIVER, help to print to monitorqdev-monitor.c+1 -13 replies
2/5qom: Plug memory leak in "info qom-tree"qom/qom-hmp-cmds.c+4 -24 replies
3/5qom: Change object_get_canonical_path_component() not to mallocbackends/hostmem.c block/throttle-groups.c gdbstub.c +20 more+41 -612 replies
4/5qom: Document object_get_canonical_path() returns malloced stringinclude/qom/object.h+3 -21 reply
5/5qom: Make info qom-tree sort children more efficientlyqom/qom-hmp-cmds.c+13 -122 replies

Reviews trailers per patch

All 5 patches have a Reviewed-by or Acked-by.

PatchPhilippe Mathieu-DaudéLi QiangThomas HuthDr. David Alan Gilbert
1/5R-b R-b R-b
2/5R-b R-b T-b
3/5R-b R-b
4/5R-b
5/5R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.

Read the v1 thread

Cover letter [PATCH for-5.1 0/5] qom: HMP command fixes

A leak fix (recent regression), a help fix (regression in 5.0), a bit of performance work, and a doc fix. The leak fix looks like a must have for 5.1.

Markus Armbruster (5):
qdev: Fix device_add DRIVER,help to print to monitor
qom: Plug memory leak in "info qom-tree"
qom: Change object_get_canonical_path_component() not to malloc
qom: Document object_get_canonical_path() returns malloced string
qom: Make info qom-tree sort children more efficiently

 include/qom/object.h       |  7 ++++---
 backends/hostmem.c         |  2 +-
 block/throttle-groups.c    |  2 +-
 gdbstub.c                  |  2 +-
 hw/arm/xlnx-zynqmp.c       |  6 ++----
 hw/block/nvme.c            |  5 ++---
 hw/core/machine-qmp-cmds.c |  2 +-
 hw/core/machine.c          |  5 ++---
 hw/mem/nvdimm.c            |  5 ++---
 hw/mem/pc-dimm.c           |  5 ++---
 hw/misc/ivshmem.c          |  5 ++---
 hw/ppc/spapr_drc.c         |  3 +--
 hw/virtio/virtio-crypto.c  |  5 ++---
 hw/virtio/virtio-mem.c     |  6 ++----
 hw/virtio/virtio-pmem.c    |  5 ++---
 iothread.c                 |  9 ++++-----
 net/net.c                  |  6 ++----
 qdev-monitor.c             |  2 +-
 qom/object.c               |  7 +++----
 qom/qom-hmp-cmds.c         | 30 +++++++++++++++---------------
 scsi/pr-manager-helper.c   |  3 +--
 scsi/pr-manager.c          |  2 +-
 softmmu/memory.c           |  2 +-
 hw/ppc/trace-events        |  2 +-
 24 files changed, 56 insertions(+), 72 deletions(-)
Signature · 1 line
2.26.2