Skip to content

s390/bpf: implement BPF_PROBE_MEM

Ilya Leoshkevich bpf 2 versions Applied

Status from this message: Applied. Thanks

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest4 patches 4 repliesApplied
  2. v14 patches 0 repliesSuperseded

Changes in v2 from the cover letter

- Add jit->excnt = 0 in order to fix WARNINGs and fallbacks to the interpreter when running extra_pass. This wasn't easy to spot on bpf-next, since tests passed anyway. However, on v5.8-rc5 this led to panics.

Patches in v2 Applied

#Subject and filesSizeRepliesApplied
1/4s390/kernel: unify EX_TABLE* implementationsarch/s390/include/asm/asm-const.h arch/s390/include/asm/linkage.h+23 -230 replies
2/4s390/kernel: expand the exception table logic to allow new handling optionsarch/s390/include/asm/extable.h arch/s390/include/asm/linkage.h arch/s390/kernel/kprobes.c +3 more+76 -170 replies
3/4s390/bpf: implement BPF_PROBE_MEMarch/s390/net/bpf_jit_comp.c+138 -11 reply
4/4selftests/bpf: add exception handling testtools/testing/selftests/bpf/prog_tests/bpf_iter.c tools/testing/selftests/bpf/progs/bpf_iter_exception.c+37 -00 replies

Reviews trailers per patch

2 of 4 patches have a Reviewed-by or Acked-by.

PatchHeiko Carstens
1/4
2/4R-b
3/4R-b
4/4

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/4] s390/bpf: implement BPF_PROBE_MEM

This patch series implements BPF_PROBE_MEM opcode, which is used in BPF programs that walk chains of kernel pointers. It consists of two parts:
patches 1 and 2 enhance s390 exception table infrastructure, patches 3 and 4 contains the actual implementation and the test.

We would like to take this series via s390 tree, because it contains dependent s390 extable and bpf jit changes. However, it would be great if someone knowledgeable could review patches 3 and 4.

v1 -> v2:

- Add jit->excnt = 0 in order to fix WARNINGs and fallbacks to the interpreter when running extra_pass. This wasn't easy to spot on bpf-next, since tests passed anyway. However, on v5.8-rc5 this led to panics.

Ilya Leoshkevich (4):
s390/kernel: unify EX_TABLE* implementations s390/kernel: expand the exception table logic to allow new handling
options
s390/bpf: implement BPF_PROBE_MEM
selftests/bpf: add exception handling test

 arch/s390/include/asm/asm-const.h             |  12 ++
 arch/s390/include/asm/extable.h               |  50 ++++++-
 arch/s390/include/asm/linkage.h               |  35 ++---
 arch/s390/kernel/kprobes.c                    |   4 +-
 arch/s390/kernel/traps.c                      |   7 +-
 arch/s390/mm/fault.c                          |   4 +-
 arch/s390/net/bpf_jit_comp.c                  | 139 +++++++++++++++++-
 scripts/sorttable.c                           |  25 ++++
 .../selftests/bpf/prog_tests/bpf_iter.c       |  17 +++
 .../selftests/bpf/progs/bpf_iter_exception.c  |  20 +++
 10 files changed, 273 insertions(+), 40 deletions(-)
 create mode 100644 arch/s390/include/asm/asm-const.h
 create mode 100644 tools/testing/selftests/bpf/progs/bpf_iter_exception.c
Signature · 1 line
2.25.4