Skip to content

xfsprogs: remove custom dir2 sf fork verifier from repair

Brian Foster linux-xfs 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest4 patches 13 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4repair: set the in-core inode parent in phase 3repair/dino_chunks.c+1 -82 replies
2/4repair: don't double check dir2 sf parent in phase 4repair/dir2.c+3 -04 replies
3/4repair: use fs root ino for dummy parent value instead of zerorepair/dir2.c+2 -38 replies
4/4repair: remove custom dir2 sf fork verifier from phase6repair/phase6.c+2 -542 replies

Reviews trailers per patch

All 4 patches have a Reviewed-by or Acked-by.

PatchChristoph HellwigDave ChinnerDarrick J. Wong
1/4R-b R-b
2/4R-b R-b
3/4R-b R-b R-b R-b
4/4R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v1 thread

Cover letter [PATCH 0/4] xfsprogs: remove custom dir2 sf fork verifier from repair

Hi all,

These are some tweaks to eliminate the custom sf dir verifier code in phase 6 of xfs_repair. Note that I don't quite recall how thoroughly I reviewed the first couple patches, but Christoph was asking for this recently for some libxfs sync work and I'm running out of time before I disappear for a few weeks, so I wanted to get it on the list. Thoughts, reviews, flames appreciated.

Brian

Brian Foster (4):
repair: set the in-core inode parent in phase 3
repair: don't double check dir2 sf parent in phase 4
repair: use fs root ino for dummy parent value instead of zero
repair: remove custom dir2 sf fork verifier from phase6

 repair/dino_chunks.c |  9 +------
 repair/dir2.c        |  8 ++++---
 repair/phase6.c      | 56 ++------------------------------------------
 3 files changed, 8 insertions(+), 65 deletions(-)
Signature · 1 line
2.21.3