RFC qom: Let ObjectPropertyGet functions return a boolean value
Get series with b4
b4 am [email protected]Versions newest first
- v1 RFC Latest5 patches 9 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/5 | hw/core/qdev-properties: Simplify get_reserved_region()hw/ | +3 | 3 replies | |
| 2/5 | qom: Split ObjectPropertyAccessor as ObjectProperty[Get/Set]hw/ include/ include/ +1 more | +58 | 0 replies | |
| 3/5 | qom: Use g_autofree in ObjectPropertyGet functionsbackends/ hw/ hw/ +3 more | +11 | 0 replies | |
| 4/5 | qom: Let ObjectPropertyGet functions return a boolean valueaccel/ accel/ authz/ +54 more | +325 | 4 replies | |
| 5/5 | hw/virtio: Simplify virtio_mem_set_requested_size()hw/ | +1 | 1 reply |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [RFC PATCH-for-5.2 0/5] qom: Let ObjectPropertyGet functions return a boolean value
RFC series to follow Markus direction to simplify error propagation. Not sure it is worth it yet. It starts to be interesting when using the QEMU_WARN_UNUSED_RESULT attribute in the visitors, such:
-- >8 --
@@ -525,6 +533,7 @@ bool visit_type_uint8(Visitor *v, const char *name, uint8_t *obj,
* Visit a uint16_t value.
* Like visit_type_int(), except clamps the value to uint16_t range. */
+QEMU_WARN_UNUSED_RESULT
bool visit_type_uint16(Visitor *v, const char *name, uint16_t *obj,
Error **errp);
---
But to get there we need to update the QAPI generators first :)
Philippe Mathieu-Daudé (5):
hw/core/qdev-properties: Simplify get_reserved_region()
qom: Split ObjectPropertyAccessor as ObjectProperty[Get/Set]
qom: Use g_autofree in ObjectPropertyGet functions
qom: Let ObjectPropertyGet functions return a boolean value hw/virtio: Simplify virtio_mem_set_requested_size()
include/hw/qdev-core.h | 4 +- include/qom/object.h | 50 +++++++++----- accel/kvm/kvm-all.c | 4 +- accel/tcg/tcg-all.c | 4 +- authz/list.c | 4 +- backends/cryptodev.c | 4 +- backends/hostmem-file.c | 4 +- backends/hostmem-memfd.c | 4 +- backends/hostmem.c | 13 ++-- backends/tpm/tpm_util.c | 7 +- block/throttle-groups.c | 8 +-- bootdevice.c | 4 +- chardev/char-socket.c | 4 +- crypto/secret_keyring.c | 5 +- hw/acpi/ich9.c | 4 +- hw/arm/virt.c | 4 +- hw/block/xen-block.c | 9 ++- hw/core/machine.c | 4 +- hw/core/qdev-properties-system.c | 33 +++++---- hw/core/qdev-properties.c | 89 ++++++++++++------------ hw/core/qdev.c | 5 +- hw/cpu/core.c | 8 +-- hw/gpio/aspeed_gpio.c | 8 +-- hw/i386/microvm.c | 12 ++-- hw/i386/pc.c | 12 ++-- hw/i386/x86.c | 8 +-- hw/ide/qdev.c | 4 +- hw/intc/apic_common.c | 4 +- hw/mem/nvdimm.c | 11 ++- hw/mem/pc-dimm.c | 6 +- hw/misc/aspeed_sdmc.c | 4 +- hw/misc/pca9552.c | 8 +-- hw/misc/tmp105.c | 4 +- hw/misc/tmp421.c | 8 +-- hw/net/ne2000-isa.c | 4 +- hw/pci-host/i440fx.c | 16 ++--- hw/pci-host/q35.c | 16 ++--- hw/ppc/spapr_caps.c | 21 +++--- hw/ppc/spapr_drc.c | 21 +++--- hw/riscv/sifive_u.c | 4 +- hw/s390x/css.c | 4 +- hw/s390x/s390-pci-bus.c | 4 +- hw/usb/dev-storage.c | 4 +- hw/vfio/pci-quirks.c | 14 ++-- hw/virtio/virtio-balloon.c | 16 +++-- hw/virtio/virtio-mem.c | 17 ++--- iothread.c | 4 +- net/colo-compare.c | 8 +-- net/dump.c | 4 +- net/filter-buffer.c | 4 +- qom/object.c | 115 ++++++++++++++++--------------- softmmu/memory.c | 14 ++-- target/arm/cpu64.c | 14 ++-- target/i386/cpu.c | 48 ++++++++----- target/ppc/compat.c | 4 +- target/s390x/cpu.c | 11 +-- target/s390x/cpu_models.c | 14 ++-- target/sparc/cpu.c | 4 +- 58 files changed, 397 insertions(+), 352 deletions(-)
Signature · 1 line
2.21.3