squashfs fixes
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest3 patches 0 repliesNew
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/3 | cmd/sqfs.c, include/fs.h: fix build failures, don't expose do_sqfs_*() functions globallycmd/ include/ | +3 | 0 replies | |
| 2/3 | fs/squashfs: use "struct disk_partition" instead of "disk_partition_t"fs/ include/ | +6 | 0 replies | |
| 3/3 | fs/squashfs: do not use CMD_RET_* defines in the filesystem codefs/ | +25 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [PATCH 0/3] squashfs fixes
Hello Joao,
As I started reviewing your patch series, I encountered a number of build issues after applying your patches, and building on the latest master. The following patches address the build failures I have encountered. Could you squash them into your commits, so that those fixes are part of your v2 ? Of course, please do some testing, as I have only done build testing so far.
Also, even with those fixes in place, I do still get a worrying gcc warning (from gcc 10):
fs/squashfs/sqfs_inode.c: In function ?sqfs_find_inode?:fs/squashfs/sqfs_inode.c:72:34: warning: array subscript l is outside array bounds of ?struct squashfs_directory_index[0]? [-Warray-bounds]
72 | index_list_size += ldir.index[l].size + 1;
| ~~~~~~~~~~^~~In file included from fs/squashfs/sqfs_inode.c:16:fs/squashfs/sqfs_filesystem.h:207:34: note: while referencing ?index?
207 | struct squashfs_directory_index index[0];
| ^~~~~fs/squashfs/sqfs_inode.c:31:29: note: defined here ?ldir?
31 | struct squashfs_ldir_inode ldir;
| ^~~~
Could you investigate this ?
Thanks,
Thomas
Thomas Petazzoni (3):
cmd/sqfs.c, include/fs.h: fix build failures, don't expose do_sqfs_*()
functions globally
fs/squashfs: use "struct disk_partition" instead of "disk_partition_t" fs/squashfs: do not use CMD_RET_* defines in the filesystem code
cmd/sqfs.c | 5 ++-- fs/squashfs/sqfs.c | 66 ++++++++++++++++++++-------------------------- include/fs.h | 12 --------- include/squashfs.h | 4 ++- 4 files changed, 34 insertions(+), 53 deletions(-)
Signature · 1 line
2.26.2