Skip to content

Clean H264 stateless uAPI

Ezequiel Garcia linux-media lkml 4 versions – New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest19 patches 0 repliesNew
  2. v319 patches 5 repliesSuperseded
  3. v214 patches 24 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v110 patches29 repliesSuperseded

Changes in v4 from the cover letter

* Convert enum v4l2_h264_field_reference to a __u8,
as suggested by Hans. This reduces v4l2_ctrl_h264_slice_params from 536 bytes down to 152 bytes, and doesn't really change the uAPI. This also removes a hole in struct v4l2_h264_reference is removed.
* Drop 'mandatory' requirement on DECODE_MODE and START_MODE, in rkvdec driver.

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/19media: uapi: h264: Update reference listsDocumentation/userspace-api/media/v4l/ext-ctrls-codec.rst drivers/staging/media/sunxi/cedrus/cedrus_h264.c include/media/h264-ctrls.h+60 -110 replies
2/19media: uapi: h264: Further clarify scaling lists orderDocumentation/userspace-api/media/v4l/ext-ctrls-codec.rst+4 -20 replies
3/19media: uapi: h264: Split prediction weight parametersDocumentation/userspace-api/media/v4l/ext-ctrls-codec.rst drivers/media/v4l2-core/v4l2-ctrls.c drivers/staging/media/sunxi/cedrus/cedrus.c +5 more+45 -180 replies
4/19media: uapi: h264: Clarify pic_order_cnt_bit_size fieldDocumentation/userspace-api/media/v4l/ext-ctrls-codec.rst+3 -10 replies
5/19media: uapi: h264: Increase size of 'first_mb_in_slice' fieldDocumentation/userspace-api/media/v4l/ext-ctrls-codec.rst include/media/h264-ctrls.h+3 -20 replies
6/19media: uapi: h264: Clean DPB entry interfaceDocumentation/userspace-api/media/v4l/ext-ctrls-codec.rst drivers/media/v4l2-core/v4l2-h264.c drivers/staging/media/rkvdec/rkvdec-h264.c +1 more+19 -280 replies
7/19media: uapi: h264: Increase size of DPB entry pic_numDocumentation/userspace-api/media/v4l/ext-ctrls-codec.rst drivers/media/v4l2-core/v4l2-ctrls.c include/media/h264-ctrls.h +1 more+22 -50 replies
8/19media: uapi: h264: Drop SLICE_PARAMS 'size' fieldDocumentation/userspace-api/media/v4l/ext-ctrls-codec.rst drivers/staging/media/sunxi/cedrus/cedrus_h264.c include/media/h264-ctrls.h+3 -100 replies
9/19media: uapi: h264: Clarify SLICE_BASED modeDocumentation/userspace-api/media/v4l/ext-ctrls-codec.rst include/media/h264-ctrls.h+10 -330 replies
10/19media: uapi: h264: Clean slice invariants syntax elementsDocumentation/userspace-api/media/v4l/ext-ctrls-codec.rst drivers/media/v4l2-core/v4l2-ctrls.c drivers/media/v4l2-core/v4l2-h264.c +6 more+90 -900 replies
11/19media: uapi: h264: Rename and clarify PPS_FLAG_SCALING_MATRIX_PRESENTDocumentation/userspace-api/media/v4l/ext-ctrls-codec.rst include/media/h264-ctrls.h+4 -30 replies
12/19media: hantro: Don't require unneeded H264_SLICE_PARAMSdrivers/staging/media/hantro/hantro_drv.c drivers/staging/media/hantro/hantro_h264.c drivers/staging/media/hantro/hantro_hw.h+0 -120 replies
13/19media: rkvdec: Don't require unneeded H264_SLICE_PARAMSdrivers/staging/media/rkvdec/rkvdec-h264.c drivers/staging/media/rkvdec/rkvdec.c+0 -90 replies
14/19media: cedrus: h264: Properly configure reference fielddrivers/staging/media/sunxi/cedrus/cedrus_h264.c+2 -40 replies
15/19media: cedrus: h264: Fix frame list constructiondrivers/staging/media/sunxi/cedrus/cedrus_h264.c+9 -60 replies
16/19media: rkvdec: Drop unneeded per_request driver-specific control flagdrivers/staging/media/rkvdec/rkvdec.c drivers/staging/media/rkvdec/rkvdec.h+1 -80 replies
17/19media: rkvdec: Use H264_SCALING_MATRIX only when requireddrivers/staging/media/rkvdec/rkvdec-h264.c drivers/staging/media/rkvdec/rkvdec.c+7 -40 replies
18/19media: hantro: Use H264_SCALING_MATRIX only when requireddrivers/staging/media/hantro/hantro_g1_h264_dec.c drivers/staging/media/hantro/hantro_h264.c+6 -30 replies
19/19media: cedrus: Use H264_SCALING_MATRIX only when requireddrivers/staging/media/sunxi/cedrus/cedrus.c drivers/staging/media/sunxi/cedrus/cedrus_h264.c+7 -10 replies

Reviews trailers per patch

4 of 19 patches have a Reviewed-by or Acked-by.

PatchJonas KarlmanNicolas Dufresne
1/19T-b
2/19T-b
3/19T-b
4/19T-b R-b
5/19T-b
6/19T-b
7/19T-b
8/19T-b
9/19T-b
10/19T-b R-b
11/19T-b
12/19T-b
13/19R-b T-b
14/19R-b
15/19
16/19T-b
17/19T-b
18/19T-b
19/19

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v4 thread

Cover letter [PATCH v4 00/19] Clean H264 stateless uAPI

New round for the H.264 uAPI cleanup, which as discussed aims at being stabilized and promoted as a first-class public uAPI soon.

Changelog:

v3->v4:
* Convert enum v4l2_h264_field_reference to a __u8,
as suggested by Hans. This reduces v4l2_ctrl_h264_slice_params from 536 bytes down to 152 bytes, and doesn't really change the uAPI. This also removes a hole in struct v4l2_h264_reference is removed.
* Drop 'mandatory' requirement on DECODE_MODE and START_MODE, in rkvdec driver.

v2->v3:
* Clarify SCALING_MATRIX present flag.
* Implement optional scaling matrix on hantro, rkvdec and cedrus.
* Make prediction weight table properly optional on cedrus.
* Rename field reference types.

v1->v2:
* Clean SLICE_PARAMS documentation, which we don't expect to be part of an array anymore.
* Clarify how frame-based and slice-based modes are expected to work.
* Add Cedrus patches to fix field references, as requested by Jernej.
* Fix wrongly removed SPS in rkvdec.
* Fix rkvdec DPB reference implementation.
* Fix missing Cedrus and missing control member, for prediction weight table control.
* Say "raster scan" instead of "matrix" in the docs.
* Drop duplicated macros and use v4l2_h264_dpb_reference for the DPB reference signalling.

RFC->v1:
* Split prediction weight table to a separate control.
* Increase size of first_mb_in_slice field.
* Cleanup DPB entry interface, to support field coding.
* Increase of DPB entry pic_num field.
* Move slice invariant fields to the per-frame control.

Ezequiel Garcia (15):
media: uapi: h264: Further clarify scaling lists order
media: uapi: h264: Split prediction weight parameters
media: uapi: h264: Increase size of 'first_mb_in_slice' field
media: uapi: h264: Clean DPB entry interface
media: uapi: h264: Increase size of DPB entry pic_num
media: uapi: h264: Drop SLICE_PARAMS 'size' field
media: uapi: h264: Clarify SLICE_BASED mode
media: uapi: h264: Clean slice invariants syntax elements
media: uapi: h264: Rename and clarify PPS_FLAG_SCALING_MATRIX_PRESENT
media: hantro: Don't require unneeded H264_SLICE_PARAMS
media: rkvdec: Don't require unneeded H264_SLICE_PARAMS
media: rkvdec: Drop unneeded per_request driver-specific control flag
media: rkvdec: Use H264_SCALING_MATRIX only when required
media: hantro: Use H264_SCALING_MATRIX only when required
media: cedrus: Use H264_SCALING_MATRIX only when required

Jernej Skrabec (3):
media: uapi: h264: Update reference lists
media: cedrus: h264: Properly configure reference field
media: cedrus: h264: Fix frame list construction

Philipp Zabel (1):
media: uapi: h264: Clarify pic_order_cnt_bit_size field

 .../media/v4l/ext-ctrls-codec.rst             | 233 ++++++++++--------
 drivers/media/v4l2-core/v4l2-ctrls.c          |  28 +++
 drivers/media/v4l2-core/v4l2-h264.c           |  12 +-
 drivers/staging/media/hantro/hantro_drv.c     |   5 -
 .../staging/media/hantro/hantro_g1_h264_dec.c |  26 +-
 drivers/staging/media/hantro/hantro_h264.c    |  12 +-
 drivers/staging/media/hantro/hantro_hw.h      |   2 -
 drivers/staging/media/rkvdec/rkvdec-h264.c    |  37 ++-
 drivers/staging/media/rkvdec/rkvdec.c         |  14 +-
 drivers/staging/media/rkvdec/rkvdec.h         |   1 -
 drivers/staging/media/sunxi/cedrus/cedrus.c   |   9 +-
 drivers/staging/media/sunxi/cedrus/cedrus.h   |   1 +
 .../staging/media/sunxi/cedrus/cedrus_dec.c   |   2 +
 .../staging/media/sunxi/cedrus/cedrus_h264.c  |  61 +++--
 include/media/h264-ctrls.h                    |  87 ++++---
 include/media/v4l2-ctrls.h                    |   2 +
 include/media/v4l2-h264.h                     |   3 +-
 17 files changed, 290 insertions(+), 245 deletions(-)
Signature · 1 line
2.27.0