Clean H264 stateless uAPI
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v4 Latest19 patches 0 repliesNew
- v319 patches 5 repliesSuperseded
- v214 patches 24 repliesSuperseded
Earlier versions · 1
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v1 | 10 patches | 29 replies | Superseded |
Changes in v4 from the cover letter
* Convert enum v4l2_h264_field_reference to a __u8,
as suggested by Hans. This reduces v4l2_ctrl_h264_slice_params from 536 bytes down to 152 bytes, and doesn't really change the uAPI. This also removes a hole in struct v4l2_h264_reference is removed.
* Drop 'mandatory' requirement on DECODE_MODE and START_MODE, in rkvdec driver.
Patches in v4 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/19 | media: uapi: h264: Update reference listsDocumentation/ drivers/ include/ | +60 | 0 replies | |
| 2/19 | media: uapi: h264: Further clarify scaling lists orderDocumentation/ | +4 | 0 replies | |
| 3/19 | media: uapi: h264: Split prediction weight parametersDocumentation/ drivers/ drivers/ +5 more | +45 | 0 replies | |
| 4/19 | media: uapi: h264: Clarify pic_order_cnt_bit_size fieldDocumentation/ | +3 | 0 replies | |
| 5/19 | media: uapi: h264: Increase size of 'first_mb_in_slice' fieldDocumentation/ include/ | +3 | 0 replies | |
| 6/19 | media: uapi: h264: Clean DPB entry interfaceDocumentation/ drivers/ drivers/ +1 more | +19 | 0 replies | |
| 7/19 | media: uapi: h264: Increase size of DPB entry pic_numDocumentation/ drivers/ include/ +1 more | +22 | 0 replies | |
| 8/19 | media: uapi: h264: Drop SLICE_PARAMS 'size' fieldDocumentation/ drivers/ include/ | +3 | 0 replies | |
| 9/19 | media: uapi: h264: Clarify SLICE_BASED modeDocumentation/ include/ | +10 | 0 replies | |
| 10/19 | media: uapi: h264: Clean slice invariants syntax elementsDocumentation/ drivers/ drivers/ +6 more | +90 | 0 replies | |
| 11/19 | media: uapi: h264: Rename and clarify PPS_FLAG_SCALING_MATRIX_PRESENTDocumentation/ include/ | +4 | 0 replies | |
| 12/19 | media: hantro: Don't require unneeded H264_SLICE_PARAMSdrivers/ drivers/ drivers/ | +0 | 0 replies | |
| 13/19 | media: rkvdec: Don't require unneeded H264_SLICE_PARAMSdrivers/ drivers/ | +0 | 0 replies | |
| 14/19 | media: cedrus: h264: Properly configure reference fielddrivers/ | +2 | 0 replies | |
| 15/19 | media: cedrus: h264: Fix frame list constructiondrivers/ | +9 | 0 replies | |
| 16/19 | media: rkvdec: Drop unneeded per_request driver-specific control flagdrivers/ drivers/ | +1 | 0 replies | |
| 17/19 | media: rkvdec: Use H264_SCALING_MATRIX only when requireddrivers/ drivers/ | +7 | 0 replies | |
| 18/19 | media: hantro: Use H264_SCALING_MATRIX only when requireddrivers/ drivers/ | +6 | 0 replies | |
| 19/19 | media: cedrus: Use H264_SCALING_MATRIX only when requireddrivers/ drivers/ | +7 | 0 replies |
Reviews trailers per patch
4 of 19 patches have a Reviewed-by or Acked-by.
| Patch | Jonas Karlman | Nicolas Dufresne |
|---|---|---|
| 1/19 | T-b | |
| 2/19 | T-b | |
| 3/19 | T-b | |
| 4/19 | T-b | R-b |
| 5/19 | T-b | |
| 6/19 | T-b | |
| 7/19 | T-b | |
| 8/19 | T-b | |
| 9/19 | T-b | |
| 10/19 | T-b | R-b |
| 11/19 | T-b | |
| 12/19 | T-b | |
| 13/19 | R-b T-b | |
| 14/19 | R-b | |
| 15/19 | ||
| 16/19 | T-b | |
| 17/19 | T-b | |
| 18/19 | T-b | |
| 19/19 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v4 00/19] Clean H264 stateless uAPI
New round for the H.264 uAPI cleanup, which as discussed aims at being stabilized and promoted as a first-class public uAPI soon.
Changelog:
v3->v4:
* Convert enum v4l2_h264_field_reference to a __u8,
as suggested by Hans. This reduces v4l2_ctrl_h264_slice_params from 536 bytes down to 152 bytes, and doesn't really change the uAPI. This also removes a hole in struct v4l2_h264_reference is removed.
* Drop 'mandatory' requirement on DECODE_MODE and START_MODE, in rkvdec driver.
v2->v3:
* Clarify SCALING_MATRIX present flag.
* Implement optional scaling matrix on hantro, rkvdec and cedrus.
* Make prediction weight table properly optional on cedrus.
* Rename field reference types.
v1->v2:
* Clean SLICE_PARAMS documentation, which we don't expect to be part of an array anymore.
* Clarify how frame-based and slice-based modes are expected to work.
* Add Cedrus patches to fix field references, as requested by Jernej.
* Fix wrongly removed SPS in rkvdec.
* Fix rkvdec DPB reference implementation.
* Fix missing Cedrus and missing control member, for prediction weight table control.
* Say "raster scan" instead of "matrix" in the docs.
* Drop duplicated macros and use v4l2_h264_dpb_reference for the DPB reference signalling.
RFC->v1:
* Split prediction weight table to a separate control.
* Increase size of first_mb_in_slice field.
* Cleanup DPB entry interface, to support field coding.
* Increase of DPB entry pic_num field.
* Move slice invariant fields to the per-frame control.
Ezequiel Garcia (15):
media: uapi: h264: Further clarify scaling lists order
media: uapi: h264: Split prediction weight parameters
media: uapi: h264: Increase size of 'first_mb_in_slice' field
media: uapi: h264: Clean DPB entry interface
media: uapi: h264: Increase size of DPB entry pic_num
media: uapi: h264: Drop SLICE_PARAMS 'size' field
media: uapi: h264: Clarify SLICE_BASED mode
media: uapi: h264: Clean slice invariants syntax elements
media: uapi: h264: Rename and clarify PPS_FLAG_SCALING_MATRIX_PRESENT
media: hantro: Don't require unneeded H264_SLICE_PARAMS
media: rkvdec: Don't require unneeded H264_SLICE_PARAMS
media: rkvdec: Drop unneeded per_request driver-specific control flag
media: rkvdec: Use H264_SCALING_MATRIX only when required
media: hantro: Use H264_SCALING_MATRIX only when required
media: cedrus: Use H264_SCALING_MATRIX only when required
Jernej Skrabec (3):
media: uapi: h264: Update reference lists
media: cedrus: h264: Properly configure reference field
media: cedrus: h264: Fix frame list construction
Philipp Zabel (1):
media: uapi: h264: Clarify pic_order_cnt_bit_size field
.../media/v4l/ext-ctrls-codec.rst | 233 ++++++++++-------- drivers/media/v4l2-core/v4l2-ctrls.c | 28 +++ drivers/media/v4l2-core/v4l2-h264.c | 12 +- drivers/staging/media/hantro/hantro_drv.c | 5 - .../staging/media/hantro/hantro_g1_h264_dec.c | 26 +- drivers/staging/media/hantro/hantro_h264.c | 12 +- drivers/staging/media/hantro/hantro_hw.h | 2 - drivers/staging/media/rkvdec/rkvdec-h264.c | 37 ++- drivers/staging/media/rkvdec/rkvdec.c | 14 +- drivers/staging/media/rkvdec/rkvdec.h | 1 - drivers/staging/media/sunxi/cedrus/cedrus.c | 9 +- drivers/staging/media/sunxi/cedrus/cedrus.h | 1 + .../staging/media/sunxi/cedrus/cedrus_dec.c | 2 + .../staging/media/sunxi/cedrus/cedrus_h264.c | 61 +++-- include/media/h264-ctrls.h | 87 ++++--- include/media/v4l2-ctrls.h | 2 + include/media/v4l2-h264.h | 3 +- 17 files changed, 290 insertions(+), 245 deletions(-)
Signature · 1 line
2.27.0