Skip to content

arm64: Convert to ARCH_STACKWALK

Mark Brown linux-arm-kernel linux-s390 lkml 3 versions – Applied

Status from this message: Applied to arm64 (for-next/stacktrace), thanks!

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest3 patches 2 repliesApplied
  2. v23 patches 8 repliesSuperseded
  3. v13 patches 4 repliesSuperseded

Changes in v3 from the cover letter

- Rebase onto v5.9-rc3.
- Fix handling of task == current.
- Flip the sense of the walk_stackframe() callback.

Patches in v3 Applied

#Subject and filesSizeRepliesApplied
1/3stacktrace: Remove reliable argument from arch_stack_walk() callbackarch/s390/kernel/stacktrace.c arch/x86/kernel/stacktrace.c include/linux/stacktrace.h +1 more+11 -160 replies
2/3arm64: stacktrace: Make stack walk callback consistent with generic codearch/arm64/include/asm/stacktrace.h arch/arm64/kernel/perf_callchain.c arch/arm64/kernel/return_address.c +1 more+13 -140 replies
3/3arm64: stacktrace: Convert to ARCH_STACKWALKarch/arm64/Kconfig arch/arm64/kernel/stacktrace.c+11 -690 replies

Reviews trailers per patch

1 of 3 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchMiroslav Benes
SeriesR-b
1/3R-b
2/3
3/3

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 0/3] arm64: Convert to ARCH_STACKWALK

This series updates the arm64 stacktrace code to use the newer and much simpler arch_stack_walk() interface, the main benefit being a single entry point to the arch code with no need for the arch code to worry about skipping frames. Along the way I noticed that the reliable parameter to the arch_stack_walk() callback appears to be redundant so there's also a patch here removing that from the existing code to simplify the interface.

This is preparatory work for implementing reliable stack trace for arm64.

v3:
- Rebase onto v5.9-rc3.
- Fix handling of task == current.
- Flip the sense of the walk_stackframe() callback.
v2:
- Rebase onto v5.9-rc1.

Mark Brown (3):
stacktrace: Remove reliable argument from arch_stack_walk() callback
arm64: stacktrace: Make stack walk callback consistent with generic
code
arm64: stacktrace: Convert to ARCH_STACKWALK

 arch/arm64/Kconfig                  |  1 +
 arch/arm64/include/asm/stacktrace.h |  2 +-
 arch/arm64/kernel/perf_callchain.c  |  6 +--
 arch/arm64/kernel/return_address.c  |  8 +--
 arch/arm64/kernel/stacktrace.c      | 84 +++++------------------------
 arch/s390/kernel/stacktrace.c       |  4 +-
 arch/x86/kernel/stacktrace.c        | 10 ++--
 include/linux/stacktrace.h          |  5 +-
 kernel/stacktrace.c                 |  8 ++-
 9 files changed, 32 insertions(+), 96 deletions(-)

base-commit: f75aef392f869018f78cfedf3c320a6b3fcfda6b

Signature · 1 line
2.20.1