Skip to content

qed, qede: add support for new operating modes

Alexander Lobakin linux-scsi lkml netdev 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest16 patches 4 repliesIn review
  2. v214 patches 4 repliesSuperseded
  3. v113 patches 5 repliesSuperseded

Changes in v3 from the cover letter

- dropped custom link mode declaration; qed, qede and qedf switched to Ethtool link modes and definitions (#0001, #0002, per Andrew Lunn's suggestion);
- exchange more .text size to .initconst and .ro_after_init in qede (#0003).

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/16linkmode: introduce linkmode_intersects()include/linux/linkmode.h+6 -01 reply
2/16qed, qede, qedf: convert link mode from u32 to ETHTOOL_LINK_MODEdrivers/net/ethernet/qlogic/qed/qed_main.c drivers/net/ethernet/qlogic/qede/qede_ethtool.c drivers/scsi/qedf/qedf_main.c +1 more+268 -3451 reply
3/16qede: populate supported link modes maps on module initdrivers/net/ethernet/qlogic/qede/qede.h drivers/net/ethernet/qlogic/qede/qede_ethtool.c drivers/net/ethernet/qlogic/qede/qede_main.c+108 -540 replies
4/16qed: reformat public_port::transceiver_data a bitdrivers/net/ethernet/qlogic/qed/qed_hsi.h+55 -530 replies
5/16qed: add support for multi-rate transceiversdrivers/net/ethernet/qlogic/qed/qed_hsi.h drivers/net/ethernet/qlogic/qed/qed_main.c drivers/net/ethernet/qlogic/qed/qed_mcp.c+106 -270 replies
6/16qed: use transceiver data to fill link partner's advertising speedsdrivers/net/ethernet/qlogic/qed/qed_main.c+29 -200 replies
7/16qed: reformat several structures a bitdrivers/net/ethernet/qlogic/qed/qed_hsi.h drivers/net/ethernet/qlogic/qed/qed_mcp.h include/linux/qed/qed_if.h+205 -2000 replies
8/16qed: add support for Forward Error Correctiondrivers/net/ethernet/qlogic/qed/qed_dev.c drivers/net/ethernet/qlogic/qed/qed_hsi.h drivers/net/ethernet/qlogic/qed/qed_main.c +3 more+121 -270 replies
9/16qede: format qede{,_vf}_ethtool_opsdrivers/net/ethernet/qlogic/qede/qede_ethtool.c+68 -690 replies
10/16qede: introduce support for FEC controldrivers/net/ethernet/qlogic/qede/qede_ethtool.c+74 -00 replies
11/16qed: reformat several structures a bitdrivers/net/ethernet/qlogic/qed/qed.h drivers/net/ethernet/qlogic/qed/qed_hsi.h drivers/net/ethernet/qlogic/qed/qed_mcp.h+237 -2290 replies
12/16qed: remove unused qed_hw_info::port_mode and QED_PORT_MODEdrivers/net/ethernet/qlogic/qed/qed.h drivers/net/ethernet/qlogic/qed/qed_dev.c+0 -360 replies
13/16qed: add support for new port modesdrivers/net/ethernet/qlogic/qed/qed_dev.c drivers/net/ethernet/qlogic/qed/qed_hsi.h+10 -00 replies
14/16qed: add missing loopback modesdrivers/net/ethernet/qlogic/qed/qed_hsi.h drivers/net/ethernet/qlogic/qed/qed_main.c include/linux/qed/qed_if.h+29 -00 replies
15/16qed: populate supported link modes maps on module initdrivers/net/ethernet/qlogic/qed/qed_main.c+118 -710 replies
16/16qed: add support for the extended speed and FEC modesdrivers/net/ethernet/qlogic/qed/qed.h drivers/net/ethernet/qlogic/qed/qed_dev.c drivers/net/ethernet/qlogic/qed/qed_hsi.h +4 more+547 -250 replies

Reviews trailers per patch

2 of 16 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchAndrew LunnJakub Kicinski
SeriesA-b
1/16R-b
2/16R-b
3/16
4/16
5/16
6/16
7/16
8/16
9/16
10/16
11/16
12/16
13/16
14/16
15/16
16/16

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 net-next 00/16] qed, qede: add support for new operating modes

This series covers the support for the following:
- new port modes;
- loopback modes, previously missing;
- new speed/link modes;
- several FEC modes;
- multi-rate transceivers;

and also cleans up and optimizes several related parts of code.

v3 (from [2]):
- dropped custom link mode declaration; qed, qede and qedf switched to Ethtool link modes and definitions (#0001, #0002, per Andrew Lunn's suggestion);
- exchange more .text size to .initconst and .ro_after_init in qede (#0003).

v2 (from [1]):
- added a patch (#0010) that drops discussed dead struct member;
- addressed checkpatch complaints on #0014 (former #0013);
- rebased on top of latest net-next;
- no other changes.

[1] https://lore.kernel.org/netdev/[email protected]/
[2] https://lore.kernel.org/netdev/[email protected]/

Alexander Lobakin (16):
linkmode: introduce linkmode_intersects()
qed, qede, qedf: convert link mode from u32 to ETHTOOL_LINK_MODE
qede: populate supported link modes maps on module init
qed: reformat public_port::transceiver_data a bit
qed: add support for multi-rate transceivers
qed: use transceiver data to fill link partner's advertising speeds
qed: reformat several structures a bit
qed: add support for Forward Error Correction
qede: format qede{,_vf}_ethtool_ops
qede: introduce support for FEC control
qed: reformat several structures a bit
qed: remove unused qed_hw_info::port_mode and QED_PORT_MODE
qed: add support for new port modes
qed: add missing loopback modes
qed: populate supported link modes maps on module init
qed: add support for the extended speed and FEC modes

 drivers/net/ethernet/qlogic/qed/qed.h         | 125 ++-
 drivers/net/ethernet/qlogic/qed/qed_dev.c     | 172 +++-
 drivers/net/ethernet/qlogic/qed/qed_hsi.h     | 786 ++++++++++--------
 drivers/net/ethernet/qlogic/qed/qed_main.c    | 765 +++++++++++++----
 drivers/net/ethernet/qlogic/qed/qed_mcp.c     | 126 ++-
 drivers/net/ethernet/qlogic/qed/qed_mcp.h     | 146 ++--
 drivers/net/ethernet/qlogic/qede/qede.h       |   2 +
 .../net/ethernet/qlogic/qede/qede_ethtool.c   | 497 +++++------
 drivers/net/ethernet/qlogic/qede/qede_main.c  |   2 +
 drivers/scsi/qedf/qedf_main.c                 |  78 +-
 include/linux/linkmode.h                      |   6 +
 include/linux/qed/qed_if.h                    | 128 ++-
 12 files changed, 1829 insertions(+), 1004 deletions(-)

--

Netdev maintainers, patch #0001 affects qedf under scsi tree, but could you take it through yours after all necessary acks? It will break incremental buildability and bisecting otherwise. Thanks.

Signature · 1 line
2.25.1