Skip to content

dd support for Tianma nt36672a video mode panel

Sumit Semwal dri-devel linux-devicetree lkml 8 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v7 Latest2 patches 6 repliesIn review
  2. v62 patches 1 replySuperseded
  3. v52 patches 3 repliesSuperseded
Earlier versions · 5
VersionPostedPatchesRepliesStatus
v42 patches2 repliesSuperseded
v3 posting 2/22 patches0 repliesSuperseded
v3 posting 1/22 patches1 replySuperseded
v22 patches2 repliesSuperseded
v12 patches2 repliesSuperseded

Patches in v7 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2dt-bindings: display: panel: Add bindings for Novatek nt36672aDocumentation/devicetree/bindings/display/panel/novatek,nt36672a.yaml+87 -03 replies
2/2drm: panel: Add novatek nt36672a panel driverMAINTAINERS drivers/gpu/drm/panel/Kconfig drivers/gpu/drm/panel/Makefile +1 more+729 -02 replies

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchRob HerringBjorn AnderssonSam Ravnborg
1/2R-b R-b R-b
2/2R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v7 thread

Cover letter [PATCH v7 0/2]dd support for Tianma nt36672a video mode panel

Some Poco F1 phones from Xiaomi have a FHD+ video mode panel based on the Novatek NT36672A display controller; Add support for the same.

Most of the panel data is taken from downstream panel dts, and is converted to drm-panel based driver by me.

It has been validated with v5.9-rc1 based drm-misc-next on Poco F1 phone; my tree with other dependent patches is here [1]

[1]: https://git.linaro.org/people/sumit.semwal/linux-dev.git/log/?h=dev/poco-panel-upstreaming

---
v2: In dt-binding, removed ports node, making port@0 directly under panel@0 node.
Also updated the panel_on delay to a safer 200ms as needed for latest Android.
v3: Replaced port@0 with just port in panel@0 node.
v4: Since "0425662fdf05: drm: Nuke mode->vrefresh", we have to calculate
vrefresh on demand. Update for it.
v5: Fixed review comments from Sam:
- rebased on top of drm-misc-next
remove return of drm_panel_add()
remove drm_panel_detach()
- renamed the panel driver file to reflect that this is a novatek nt36672a display driver and not only for tianma panels. Adjusted some internal names also to reflect the same.
- corrected changelog to add info about the generic Novatek DSI IC
- corrected compatible string accordingly
- removed pinctrl
- used drm_panel* API for prepare/unprepare/disable/remove
v6: Fixed few review comments on v5 from Sam:
- add dev_err_probe() support
- move DRM_* error printing to dev_err()
- removed a few unnecessary bits
v7: Fixed review comments on v6 from Bjorn:
- Reworked the send_mipi_commands functionality
- removed regulator disable_loads; moved active_load setting to probe time
- made function names and struct less generic
- updated the reset_gpio working to active_low
- update MAINTAINERS for file name changes

Sumit Semwal (2):
dt-bindings: display: panel: Add bindings for Novatek nt36672a
drm: panel: Add novatek nt36672a panel driver

 .../display/panel/novatek,nt36672a.yaml       |  87 +++
 MAINTAINERS                                   |   7 +
 drivers/gpu/drm/panel/Kconfig                 |  10 +
 drivers/gpu/drm/panel/Makefile                |   1 +
 .../gpu/drm/panel/panel-novatek-nt36672a.c    | 711 ++++++++++++++++++
 5 files changed, 816 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/display/panel/novatek,nt36672a.yaml
 create mode 100644 drivers/gpu/drm/panel/panel-novatek-nt36672a.c
Signature · 6 lines
2.28.0

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel