Skip to content

Add 4 new keycodes and use them for 4 new hotkeys on new Lenovo Thinkpads

Hans de Goede linux-input platform-driver-x86 2 versions – Applied

Status from this message: I queued up the series, thank you.

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest4 patches 1 replyApplied
  2. v13 patches 9 repliesSuperseded

Patches in v2 Applied

#Subject and filesSizeRepliesApplied
1/4Input: allocate keycodes for notification-center, pickup-phone and hangup-phoneinclude/uapi/linux/input-event-codes.h+3 -00 replies
2/4Input: allocate keycode for Fn + right shiftinclude/uapi/linux/input-event-codes.h+1 -00 replies
3/4platform/x86: thinkpad_acpi: Add support for new hotkeys found on X1C8 / T14drivers/platform/x86/thinkpad_acpi.c+13 -50 replies
4/4platform/x86: thinkpad_acpi: Map Clipping tool hotkey to KEY_SELECTIVE_SCREENSHOTdrivers/platform/x86/thinkpad_acpi.c+1 -10 replies

Reviews trailers per patch

3 of 4 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchAndy ShevchenkoHenrique de Moraes HolschuhBastien Nocera
SeriesA-b
1/4A-b
2/4
3/4A-b
4/4A-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v2 thread

Cover letter [PATCH v2 0/4] Add 4 new keycodes and use them for 4 new hotkeys on new Lenovo Thinkpads

Hi All,

Here is a v2 of my series to get a couple of new hotkeys, and matching thinkpad_acpi hkey event codes seen on the last 2 generations of Thinkpads supported.

New in this version that Lenovo got back to me and explained that the 0x1316 hkey event belongs to Fn + right Shift, so that is mapped now too.

Since these make both include/uapi/linux/input-event-codes.h and drivers/platform/x86 changes one open question with this series is how to merge it.

Dmitry, for v1 of this series you suggested you could merge them all through the input tree ? Andy, one of the drivers/platform/x86 maintainers gave his Acked-by for this:

Alternatively the entire series could be merged through the linux-platform-drivers-x86 repo:

https://git.infradead.org/users/dvhart/linux-platform-drivers-x86.git/shortlog/refs/heads/review-andy

Regards,

Hans