Skip to content

Fix SPL_EARLY_BSS applying to normal build

Brian Moyer u-boot 2 versions – New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest1 patch 0 repliesNew
  2. v11 patch 0 repliesSuperseded

Changes in v2 from the cover letter

- Adding a check to the first SPL_CLEAR_BSS resulted in BSS never getting cleared for u-boot proper. Added an or condition to the second call.
- SPL_CLEAR_BSS is the only bss clearing operation. Renamed to just CLEAR_BSS for clarity.

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/1arm: Add SPL build check to SPL early bss cleararch/arm/lib/crt0.S+5 -51 reply

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH v2 0/1] Fix SPL_EARLY_BSS applying to normal build

SPL_CLEAR_BSS is called regardless of build type if CONFIG_SPL_EARLY_BSS is defined. This seems to break u-boot proper and doesn't seem like the correct behavior.

Early bss clearing in u-boot proper happens before relocation and causes lots of problems because .rel.dyn and .bss overlap.

Changes in v2:
- Adding a check to the first SPL_CLEAR_BSS resulted in BSS never getting cleared for u-boot proper. Added an or condition to the second call.
- SPL_CLEAR_BSS is the only bss clearing operation. Renamed to just CLEAR_BSS for clarity.

Brian Moyer (1):
arm: Add SPL build check to SPL early bss clear

 arch/arm/lib/crt0.S | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)
Signature · 1 line
2.17.1