mtd: rawnand: atmel: Convert the driver to exec_op()
Status from this message: Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git nand/next, thanks.
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v5 Latest6 patches 6 repliesApplied
- v46 patches 1 replySuperseded
Patches in v5 Applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/6 | mtd: rawnand: atmel: Enable the NFC controller at probe timedrivers/ | +6 | 1 reply | |
| 2/6 | mtd: rawnand: atmel: Drop redundant nand_read_page_op()drivers/ | +1 | 1 reply | |
| 3/6 | mtd: rawnand: atmel: Use nand_{write,read}_data_op()drivers/ | +5 | 1 reply | |
| 4/6 | mtd: rawnand: atmel: Use nand_prog_page_end_op()drivers/ | +2 | 1 reply | |
| 5/6 | mtd: rawnand: atmel: Convert the driver to exec_op()drivers/ | +267 | 1 reply | |
| 6/6 | mtd: rawnand: atmel: Get rid of the legacy interface implementationdrivers/ | +1 | 1 reply |
Reviews trailers per patch
All 6 patches have a Reviewed-by or Acked-by.
| Patch | Miquel Raynal | Tudor Ambarus |
|---|---|---|
| 1/6 | R-b | R-b |
| 2/6 | R-b | R-b |
| 3/6 | R-b | R-b |
| 4/6 | R-b | |
| 5/6 | R-b | T-b |
| 6/6 | R-b | T-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v5 0/6] mtd: rawnand: atmel: Convert the driver to exec_op()
Hi,
v5 drops an unused var in atmel_smc_nand_exec_op().
v4 is just a rebase which fixes some small conflicts. There is still a small perf degradation on the write path on sama5, but that can be addressed separately. Below is Boris's cover letter from v3.
Cheers,
ta
Hello,
This v3 addresses a few problems reported by Tudor (one of the fix has been sent separately [1]). There's still a perf regression on sama5 (200KB/s drop in the write path), but it seems to be related to a core change (when switching to exec_op(), the page_prog_end() does a read_status() which was not present in cmdfunc()) and the fact that the NFC is bad at handling simple commands.
What's probably more worrisome is the difference between the NFC and the !NFC case (not introduced by this series). I suspect it was to do with HSMC specific timings, or maybe the NFC simply behaves poorly compared to direct bus accesses. In any case, this issue is orthogonal to the exec_op() conversion, and can, IMHO, be addressed separately.
Regards,
Boris
[1]https://patchwork.ozlabs.org/project/linux-mtd/patch/[email protected]/
Boris Brezillon (6):
mtd: rawnand: atmel: Enable the NFC controller at probe time
mtd: rawnand: atmel: Drop redundant nand_read_page_op()
mtd: rawnand: atmel: Use nand_{write,read}_data_op()
mtd: rawnand: atmel: Use nand_prog_page_end_op()
mtd: rawnand: atmel: Convert the driver to exec_op()
mtd: rawnand: atmel: Get rid of the legacy interface implementation
drivers/mtd/nand/raw/atmel/nand-controller.c | 410 +++++++++++-------- 1 file changed, 233 insertions(+), 177 deletions(-)
Signature · 6 lines
2.25.1 ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/