Skip to content

Fix nbd reconnect dead-locks

Vladimir Sementsov-Ogievskiy qemu-devel 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest5 patches 3 repliesIn review
  2. v13 patches 9 repliesSuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5block/nbd: split nbd_establish_connection out of nbd_client_connectblock/nbd.c block/trace-events+38 -261 reply
2/5block/nbd: allow drain during reconnect attemptblock/nbd.c+14 -01 reply
3/5block/nbd: on shutdown terminate connection attemptblock/nbd.c+11 -40 replies
4/5block/nbd: nbd_co_reconnect_loop(): don't sleep if drainedblock/nbd.c+6 -50 replies
5/5block/nbd: use non-blocking connect: fix vm hang on connect()block/nbd.c+265 -10 replies

Reviews trailers per patch

4 of 5 patches have a Reviewed-by or Acked-by.

PatchEric Blake
1/5R-b
2/5R-b
3/5R-b
4/5R-b
5/5

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 for-5.1? 0/5] Fix nbd reconnect dead-locks

Hi all!

v2: it's a bit updated "[PATCH for-5.1? 0/3] Fix nbd reconnect dead-locks" plus completely rewritten "[PATCH for-5.1? 0/4] non-blocking connect" (which is now the only one patch 05)

01: new
02: rebased on 01, fix (add outer "if")
03-04: add Eric's r-b:
05: new

If 05 is too big for 5.1, it's OK to take only 01-04 or less, as well as postponing everything to 5.2, as it's all not a degradation of 5.1 (it's a degradation of 4.2, together with the whole reconnect feature).

Vladimir Sementsov-Ogievskiy (5):
block/nbd: split nbd_establish_connection out of nbd_client_connect block/nbd: allow drain during reconnect attempt block/nbd: on shutdown terminate connection attempt block/nbd: nbd_co_reconnect_loop(): don't sleep if drained block/nbd: use non-blocking connect: fix vm hang on connect()

 block/nbd.c        | 360 +++++++++++++++++++++++++++++++++++++++++----
 block/trace-events |   4 +-
 2 files changed, 331 insertions(+), 33 deletions(-)
Signature · 1 line
2.21.0