Skip to content

tests/core_hotunplug: Fixes and enhancements

Janusz Krzysztofik igt-dev intel-gfx 6 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v6 Latest24 patches 15 repliesIn review
  2. v521 patches 1 replySuperseded
  3. v420 patches 3 repliesSuperseded
Earlier versions · 3
VersionPostedPatchesRepliesStatus
v319 patches1 replySuperseded
v216 patches1 replySuperseded
v1 RFC15 patches1 replySuperseded

Patches in v6 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/24tests/core_hotunplug: Use igt_assert_fd()tests/core_hotunplug.c+5 -50 replies
2/24tests/core_hotunplug: Constify dev_bus_addr stringtests/core_hotunplug.c+1 -10 replies
3/24tests/core_hotunplug: Clean up device open error handlingtests/core_hotunplug.c+23 -110 replies
4/24tests/core_hotunplug: Consolidate duplicated debug messagestests/core_hotunplug.c+20 -190 replies
5/24tests/core_hotunplug: Assert successful device filter applicationtests/core_hotunplug.c+1 -10 replies
6/24tests/core_hotunplug: Maintain a single data structure instancetests/core_hotunplug.c+26 -300 replies
7/24tests/core_hotunplug: Pass errors via a data structure fieldtests/core_hotunplug.c+47 -490 replies
8/24tests/core_hotunplug: Handle device close errorstests/core_hotunplug.c+58 -180 replies
9/24tests/core_hotunplug: Prepare invariant data once per test runtests/core_hotunplug.c+33 -500 replies
10/24tests/core_hotunplug: Skip selectively on sysfs close errorstests/core_hotunplug.c+2 -30 replies
11/24tests/core_hotunplug: Recover from subtest failurestests/core_hotunplug.c+74 -260 replies
12/24tests/core_hotunplug: Fail subtests on device close errorstests/core_hotunplug.c+3 -00 replies
13/24tests/core_hotunplug: Let the driver time out essential sysfs operationstests/core_hotunplug.c+20 -180 replies
14/24tests/core_hotunplug: Process return values of sysfs operationstests/core_hotunplug.c+10 -40 replies
15/24tests/core_hotunplug: Assert expected device presence/absencetests/core_hotunplug.c+14 -00 replies
16/24tests/core_hotunplug: Explicitly ignore unused return valuestests/core_hotunplug.c+3 -30 replies
17/24tests/core_hotunplug: Also check health of render device nodetests/core_hotunplug.c+31 -110 replies
18/24tests/core_hotunplug: More thorough i915 healthcheck and recoverytests/core_hotunplug.c+101 -140 replies
19/24tests/core_hotunplug: Add 'lateclose before restore' variantstests/core_hotunplug.c+66 -120 replies
20/24tests/core_hotunplug: Check health both before and after late closetests/core_hotunplug.c+20 -60 replies
21/24tests/core_hotunplug: HSW/BDW audio issue workaroundtests/core_hotunplug.c+15 -03 replies
22/24tests/core_hotunplug: Duplicate debug messages in dmesgtests/core_hotunplug.c+15 -90 replies
23/24tests/core_hotunplug: Un-blocklist *bind* subteststests/intel-ci/blacklist.txt+1 -13 replies
24/24tests/core_hotunplug: Add unbind-rebind subtest to BAT scopetests/intel-ci/fast-feedback.testlist+1 -02 replies

Reviews trailers per patch

17 of 24 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchMichał WiniarskiPetri Latvala
SeriesR-b
1/24R-b
2/24R-b
3/24
4/24R-b
5/24R-b
6/24R-b
7/24R-b
8/24R-b
9/24R-b
10/24R-b
11/24R-b
12/24R-b
13/24
14/24R-b
15/24R-b
16/24R-b
17/24
18/24
19/24R-b
20/24
21/24R-b
22/24
23/24A-b
24/24

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v6 thread

Cover letter [igt-dev] [PATCH i-g-t v6 00/24] tests/core_hotunplug: Fixes and enhancements

Clean up the test code, add some new basic subtests, then unblock unbind test variants.

No incompletes / aborts nor subsequently run test issues have been reported by Trybot. The hotrebind-lateclose subtest fails on a so far unidentified driver sysfs issue but the device is fully recovered and left in a usable state. Perceived Haswell/Broadwell issue with audio power management has been worked around and its potential occurrence is reported as an IGT warning.

Series changelog:
v2: New patch "Un-blocklist *bind* subtests added.
v3: Patch "Follow failed subtests with healthcheck" renamed to "Recover
from subtest failures".
- a new patche "Clean up device open error handling" added, an old patch "Fix missing newline" obsoleted by the new one dropped,
- other new patches added:
- "Let the driver time out essential sysfs operations",
- "More thorough i915 healthcheck and recovery",
- a patch "Add 'lateclose before restore' variants" from another series included.
v4: Optional patch "Duplicate debug messages in dmesg" from another
series included.
v5: New patch added with Haswell audio related kernel warning worked
around and replaced with an IGT warning to preserve visibility of the issue.
v6: New patch added for also checking health of render device nodes,
- new patch added with proper handling of health check before late close,
- inclusion of unbind-rebind scenario to BAT scope proposed.

@Michał: Since some patch updates are trivial, I've preserved your v1/v2 Reviewd-by: except for patches with non-trivial changes, where I marked your R-b as v1/v2 applicable. Please have a look and confirm if you are still OK with them.

@Tvrtko: As I already asked before, please support my attempt to remove the unbind test variants from the blocklist.

@Petri, @Martin: Assuming CI results will be as good as those obtained on Trybot, please give me your green light for merging this series if you have no objections.

Thanks,
Janusz

Janusz Krzysztofik (24):
tests/core_hotunplug: Use igt_assert_fd() tests/core_hotunplug: Constify dev_bus_addr string tests/core_hotunplug: Clean up device open error handling tests/core_hotunplug: Consolidate duplicated debug messages tests/core_hotunplug: Assert successful device filter application tests/core_hotunplug: Maintain a single data structure instance tests/core_hotunplug: Pass errors via a data structure field tests/core_hotunplug: Handle device close errors tests/core_hotunplug: Prepare invariant data once per test run tests/core_hotunplug: Skip selectively on sysfs close errors tests/core_hotunplug: Recover from subtest failures tests/core_hotunplug: Fail subtests on device close errors tests/core_hotunplug: Let the driver time out essential sysfs
operations
tests/core_hotunplug: Process return values of sysfs operations tests/core_hotunplug: Assert expected device presence/absence tests/core_hotunplug: Explicitly ignore unused return values tests/core_hotunplug: Also check health of render device node tests/core_hotunplug: More thorough i915 healthcheck and recovery tests/core_hotunplug: Add 'lateclose before restore' variants tests/core_hotunplug: Check health both before and after late close tests/core_hotunplug: HSW/BDW audio issue workaround tests/core_hotunplug: Duplicate debug messages in dmesg tests/core_hotunplug: Un-blocklist *bind* subtests tests/core_hotunplug: Add unbind-rebind subtest to BAT scope

 tests/core_hotunplug.c                | 560 ++++++++++++++++++++------
 tests/intel-ci/blacklist.txt          |   2 +-
 tests/intel-ci/fast-feedback.testlist |   1 +
 3 files changed, 431 insertions(+), 132 deletions(-)
Signature · 6 lines
2.21.1

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev