Skip to content

4.19.134-rc1 review

Greg Kroah-Hartman linux-tegra lkml stable 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest133 patches 31 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/133perf: Make perf able to build with latest libbfdtools/perf/util/srcline.c+15 -10 replies
2/133net: rmnet: fix lower interface leakdrivers/net/ethernet/qualcomm/rmnet/rmnet_config.c+12 -70 replies
3/133genetlink: remove genl_bindinclude/net/genetlink.h net/netlink/genetlink.c+0 -570 replies
4/133ipv4: fill fl4_icmp_{type,code} in ping_v4_sendmsgnet/ipv4/ping.c+3 -00 replies
5/133l2tp: remove skb_dst_set() from l2tp_xmit_skb()net/l2tp/l2tp_core.c+1 -40 replies
6/133llc: make sure applications use ARPHRD_ETHERnet/llc/af_llc.c+7 -30 replies
7/133net: Added pointer check for dst->ops->neigh_lookup in dst_neigh_lookup_skbinclude/net/dst.h+9 -10 replies
8/133net_sched: fix a memory leak in atm_tc_init()net/sched/sch_atm.c+4 -40 replies
9/133net: usb: qmi_wwan: add support for Quectel EG95 LTE modemdrivers/net/usb/qmi_wwan.c+1 -00 replies
10/133tcp: fix SO_RCVLOWAT possible hangs under high mem pressurenet/ipv4/tcp_input.c+2 -00 replies
11/133tcp: make sure listeners dont initialize congestion-control statenet/ipv4/tcp.c net/ipv4/tcp_cong.c+4 -10 replies
12/133tcp: md5: add missing memory barriers in tcp_md5_do_add()/tcp_md5_hash_key()net/ipv4/tcp.c net/ipv4/tcp_ipv4.c+8 -20 replies
13/133tcp: md5: do not send silly options in SYNCOOKIESnet/ipv4/tcp_output.c+5 -30 replies
14/133tcp: md5: refine tcp_md5_do_add()/tcp_md5_hash_key() barriersnet/ipv4/tcp.c net/ipv4/tcp_ipv4.c+13 -70 replies
15/133tcp: md5: allow changing MD5 keys in all socket statesnet/ipv4/tcp.c+1 -40 replies
16/133cgroup: fix cgroup_sk_alloc() for sk_clone_lock()include/linux/cgroup-defs.h include/linux/cgroup.h kernel/cgroup/cgroup.c +1 more+26 -153 replies
17/133cgroup: Fix sock_cgroup_data on big-endian.include/linux/cgroup-defs.h+2 -00 replies
18/133sched: consistently handle layer3 header accesses in the presence of VLANsinclude/linux/if_vlan.h include/net/inet_ecn.h include/net/pkt_sched.h +12 more+70 -410 replies
19/133vlan: consolidate VLAN parsing code and limit max parsing depthinclude/linux/if_vlan.h+22 -350 replies
20/133drm/msm: fix potential memleak in error branchdrivers/gpu/drm/msm/msm_submitqueue.c+3 -10 replies
21/133drm/exynos: fix ref count leak in mic_pre_enabledrivers/gpu/drm/exynos/exynos_drm_mic.c+3 -10 replies
22/133m68k: nommu: register start of the memory with memblockarch/m68k/kernel/setup_no.c+2 -10 replies
23/133m68k: mm: fix node memblock initarch/m68k/mm/mcfmmu.c+1 -10 replies
24/133arm64/alternatives: use subsections for replacement sequencesarch/arm64/include/asm/alternative.h arch/arm64/kernel/vmlinux.lds.S+8 -110 replies
25/133tpm_tis: extra chip->ops check on error path in tpm_tis_core_initdrivers/char/tpm/tpm_tis_core.c+1 -10 replies
26/133gfs2: read-only mounts should grab the sd_freeze_gl glockfs/gfs2/ops_fstype.c+11 -10 replies
27/133i2c: eg20t: Load module automatically if ID matchesdrivers/i2c/busses/i2c-eg20t.c+1 -00 replies
28/133arm64/alternatives: dont patch up internal branchesarch/arm64/kernel/alternative.c+2 -140 replies
29/133iio:magnetometer:ak8974: Fix alignment and data leak issuesdrivers/iio/magnetometer/ak8974.c+7 -30 replies
30/133iio:humidity:hdc100x Fix alignment and data leak issuesdrivers/iio/humidity/hdc100x.c+7 -30 replies
31/133iio: magnetometer: ak8974: Fix runtime PM imbalance on errordrivers/iio/magnetometer/ak8974.c+10 -91 reply
32/133iio: mma8452: Add missed iio_device_unregister() call in mma8452_probe()drivers/iio/accel/mma8452.c+4 -10 replies
33/133iio: pressure: zpa2326: handle pm_runtime_get_sync failuredrivers/iio/pressure/zpa2326.c+3 -10 replies
34/133iio:humidity:hts221 Fix alignment and data leak issuesdrivers/iio/humidity/hts221.h drivers/iio/humidity/hts221_buffer.c+10 -62 replies
35/133iio:pressure:ms5611 Fix buffer element alignmentdrivers/iio/pressure/ms5611_core.c+8 -30 replies
36/133iio:health:afe4403 Fix timestamp alignment and prevent data leak.drivers/iio/health/afe4403.c+8 -50 replies
37/133spi: fix initial SPI_SR value in spi-fsl-dspidrivers/spi/spi-fsl-dspi.c+1 -10 replies
38/133spi: spi-fsl-dspi: Fix lockup if device is shutdown during SPI transferdrivers/spi/spi-fsl-dspi.c+1 -140 replies
39/133net: dsa: bcm_sf2: Fix node reference countdrivers/net/dsa/bcm_sf2.c+2 -00 replies
40/133of: of_mdio: Correct loop scanning logicdrivers/of/of_mdio.c+7 -20 replies
41/133Revert "usb/ohci-platform: Fix a warning when hibernating"drivers/usb/host/ohci-platform.c+0 -55 replies
42/133Revert "usb/xhci-plat: Set PM runtime as active on resume"drivers/usb/host/xhci-plat.c+1 -90 replies
43/133Revert "usb/ehci-platform: Set PM runtime as active on resume"drivers/usb/host/ehci-platform.c+0 -40 replies
44/133net: sfp: add support for module quirksdrivers/net/phy/sfp-bus.c+54 -00 replies
45/133net: sfp: add some quirks for GPON modulesdrivers/net/phy/sfp-bus.c+25 -00 replies
46/133HID: quirks: Remove ITE 8595 entry from hid_have_special_driverdrivers/hid/hid-quirks.c+0 -30 replies
47/133ARM: at91: pm: add quirk for sam9x60s ulp1arch/arm/mach-at91/pm_suspend.S+4 -00 replies
48/133scsi: sr: remove references to BLK_DEV_SR_VENDOR, leave it enabledarch/alpha/defconfig arch/arm/configs/rpc_defconfig arch/arm/configs/s3c2410_defconfig +42 more+0 -601 reply
49/133ALSA: usb-audio: Create a registration quirk for Kingston HyperX Amp (0951:16d8)sound/usb/card.c sound/usb/quirks.c sound/usb/quirks.h+25 -40 replies
50/133doc: dt: bindings: usb: dwc3: Update entries for disabling SS instances in park modeDocumentation/devicetree/bindings/usb/dwc3.txt+2 -00 replies
51/133mmc: sdhci: do not enable card detect interrupt for gpio cd typedrivers/mmc/host/sdhci.c+1 -10 replies
52/133ALSA: usb-audio: Rewrite registration quirk handlingsound/usb/card.c sound/usb/quirks.c sound/usb/quirks.h+32 -130 replies
53/133ACPI: video: Use native backlight on Acer Aspire 5783zdrivers/acpi/video_detect.c+9 -00 replies
54/133ALSA: usb-audio: Add registration quirk for Kingston HyperX Cloud Alpha Ssound/usb/quirks.c+1 -00 replies
55/133Input: mms114 - add extra compatible for mms345ldrivers/input/touchscreen/mms114.c+15 -20 replies
56/133ACPI: video: Use native backlight on Acer TravelMate 5735Zdrivers/acpi/video_detect.c+10 -00 replies
57/133ALSA: usb-audio: Add registration quirk for Kingston HyperX Cloud Flight Ssound/usb/quirks.c+1 -00 replies
58/133iio:health:afe4404 Fix timestamp alignment and prevent data leak.drivers/iio/health/afe4404.c+5 -30 replies
59/133phy: sun4i-usb: fix dereference of pointer phy0 before it is null checkeddrivers/phy/allwinner/phy-sun4i-usb.c+3 -20 replies
60/133arm64: dts: meson: add missing gxl rng clockarch/arm64/boot/dts/amlogic/meson-gxl.dtsi+5 -00 replies
61/133spi: spi-sun6i: sun6i_spi_transfer_one(): fix setting of clock ratedrivers/spi/spi-sun6i.c+6 -80 replies
62/133usb: gadget: udc: atmel: fix uninitialized read in debug printkdrivers/usb/gadget/udc/atmel_usba_udc.c+1 -10 replies
63/133staging: comedi: verify array index is correct before using itdrivers/staging/comedi/drivers/addi_apci_1500.c+7 -30 replies
64/133Revert "thermal: mediatek: fix register index error"drivers/thermal/mtk_thermal.c+2 -40 replies
65/133ARM: dts: socfpga: Align L2 cache-controller nodename with dtschemaarch/arm/boot/dts/socfpga.dtsi arch/arm/boot/dts/socfpga_arria10.dtsi+2 -20 replies
66/133regmap: debugfs: Dont sleep while atomic for fast_io regmapsdrivers/base/regmap/regmap-debugfs.c+29 -232 replies
67/133copy_xstate_to_kernel: Fix typo which caused GDB regressionarch/x86/kernel/fpu/xstate.c+1 -10 replies
68/133apparmor: ensure that dfa state tables have entriessecurity/apparmor/match.c+5 -00 replies
69/133perf stat: Zero all the ena and run array slot stats for interval modetools/perf/util/stat.c+4 -20 replies
70/133soc: qcom: rpmh: Update dirty flag only when data changesdrivers/soc/qcom/rpmh.c+11 -80 replies
71/133soc: qcom: rpmh: Invalidate SLEEP and WAKE TCSes before flushing new datadrivers/soc/qcom/rpmh.c+18 -230 replies
72/133soc: qcom: rpmh-rsc: Clear active mode configuration for wake TCSdrivers/soc/qcom/rpmh-rsc.c+54 -230 replies
73/133soc: qcom: rpmh-rsc: Allow using free WAKE TCS for active requestdrivers/soc/qcom/rpmh-rsc.c+11 -120 replies
74/133mtd: rawnand: marvell: Use nand_cleanup() when the device is not yet registereddrivers/mtd/nand/raw/marvell_nand.c+1 -10 replies
75/133mtd: rawnand: marvell: Fix probe error pathdrivers/mtd/nand/raw/marvell_nand.c+14 -90 replies
76/133mtd: rawnand: timings: Fix default tR_max and tCCS_min timingsdrivers/mtd/nand/raw/nand_timings.c+2 -30 replies
77/133mtd: rawnand: brcmnand: fix CS0 layoutdrivers/mtd/nand/raw/brcmnand/brcmnand.c+3 -20 replies
78/133mtd: rawnand: oxnas: Keep track of registered devicesdrivers/mtd/nand/raw/oxnas_nand.c+4 -40 replies
79/133mtd: rawnand: oxnas: Unregister all devices on errordrivers/mtd/nand/raw/oxnas_nand.c+8 -00 replies
80/133mtd: rawnand: oxnas: Release all devices in the _remove() pathdrivers/mtd/nand/raw/oxnas_nand.c+6 -20 replies
81/133slimbus: core: Fix mismatch in of_node_get/putdrivers/slimbus/core.c+1 -00 replies
82/133HID: magicmouse: do not set up autorepeatdrivers/hid/hid-magicmouse.c+6 -00 replies
83/133HID: quirks: Always poll Obins Anne Pro 2 keyboarddrivers/hid/hid-ids.h drivers/hid/hid-quirks.c+2 -00 replies
84/133HID: quirks: Ignore Simply Automated UPB PIMdrivers/hid/hid-ids.h drivers/hid/hid-quirks.c+3 -00 replies
85/133ALSA: line6: Perform sanity check for each URB creationsound/usb/line6/capture.c sound/usb/line6/playback.c+4 -00 replies
86/133ALSA: line6: Sync the pending work cancel at disconnectionsound/usb/line6/driver.c+1 -10 replies
87/133ALSA: usb-audio: Fix race against the error recovery URB submissionsound/usb/midi.c+12 -50 replies
88/133ALSA: hda/realtek - change to suitable link model for ASUS platformsound/pci/hda/patch_realtek.c+2 -20 replies
89/133ALSA: hda/realtek - Enable Speaker for ASUS UX533 and UX534sound/pci/hda/patch_realtek.c+2 -00 replies
90/133USB: c67x00: fix use after free in c67x00_giveback_urbdrivers/usb/c67x00/c67x00-sched.c+1 -10 replies
91/133usb: dwc2: Fix shutdown callback in platformdrivers/usb/dwc2/platform.c+2 -10 replies
92/133usb: chipidea: core: add wakeup support for extcondrivers/usb/chipidea/core.c+24 -00 replies
93/133usb: gadget: function: fix missing spinlock in f_uac1_legacydrivers/usb/gadget/function/f_uac1_legacy.c+2 -00 replies
94/133USB: serial: iuu_phoenix: fix memory corruptiondrivers/usb/serial/iuu_phoenix.c+5 -34 replies
95/133USB: serial: cypress_m8: enable Simply Automated UPB PIMdrivers/usb/serial/cypress_m8.c drivers/usb/serial/cypress_m8.h+5 -00 replies
96/133USB: serial: ch341: add new Product ID for CH340drivers/usb/serial/ch341.c+1 -00 replies
97/133USB: serial: option: add GosunCn GM500 seriesdrivers/usb/serial/option.c+3 -00 replies
98/133USB: serial: option: add Quectel EG95 LTE modemdrivers/usb/serial/option.c+3 -00 replies
99/133virt: vbox: Fix VBGL_IOCTL_VMMDEV_REQUEST_BIG and _LOG req numbers to match upstreamdrivers/virt/vboxguest/vboxguest_core.c drivers/virt/vboxguest/vboxguest_core.h drivers/virt/vboxguest/vboxguest_linux.c +1 more+22 -40 replies
100/133virt: vbox: Fix guest capabilities mask checkdrivers/virt/vboxguest/vboxguest_core.c drivers/virt/vboxguest/vmmdev.h+3 -10 replies
101/133virtio: virtio_console: add missing MODULE_DEVICE_TABLE() for rproc serialdrivers/char/virtio_console.c+2 -10 replies
102/133serial: mxs-auart: add missed iounmap() in probe failure and removedrivers/tty/serial/mxs-auart.c+8 -40 replies
103/133ovl: inode reference leak in ovl_is_inuse true case.fs/overlayfs/super.c+10 -10 replies
104/133ovl: relax WARN_ON() when decoding lower directory file handlefs/overlayfs/export.c+1 -10 replies
105/133ovl: fix unneeded call to ovl_change_flags()fs/overlayfs/file.c+6 -40 replies
106/133fuse: Fix parameter for FS_IOC_{GET,SET}FLAGSfs/fuse/file.c+11 -10 replies
107/133Revert "zram: convert remaining CLASS_ATTR() to CLASS_ATTR_RO()"drivers/block/zram/zram_drv.c+2 -10 replies
108/133mei: bus: dont clean driver pointerdrivers/misc/mei/bus.c+1 -20 replies
109/133Input: i8042 - add Lenovo XiaoXin Air 12 to i8042 nomux listdrivers/input/serio/i8042-x86ia64io.h+7 -00 replies
110/133uio_pdrv_genirq: fix use without device tree and no interruptdrivers/uio/uio_pdrv_genirq.c+1 -10 replies
111/133timer: Prevent base->clk from moving backwardkernel/time/timer.c+14 -30 replies
112/133timer: Fix wheel index calculation on last levelkernel/time/timer.c+2 -20 replies
113/133MIPS: Fix build for LTS kernel caused by backporting lpj adjustmentarch/mips/kernel/time.c+4 -90 replies
114/133riscv: use 16KB kernel stack on 64-bitarch/riscv/include/asm/thread_info.h+4 -00 replies
115/133hwmon: (emc2103) fix unable to change fan pwm1_enable attributedrivers/hwmon/emc2103.c+1 -10 replies
116/133powerpc/book3s64/pkeys: Fix pkey_access_permitted() for execute disable pkeyarch/powerpc/mm/pkeys.c+7 -50 replies
117/133intel_th: pci: Add Jasper Lake CPU supportdrivers/hwtracing/intel_th/pci.c+5 -00 replies
118/133intel_th: pci: Add Tiger Lake PCH-H supportdrivers/hwtracing/intel_th/pci.c+5 -00 replies
119/133intel_th: pci: Add Emmitsburg PCH supportdrivers/hwtracing/intel_th/pci.c+5 -00 replies
120/133intel_th: Fix a NULL dereference when hub driver is not loadeddrivers/hwtracing/intel_th/core.c drivers/hwtracing/intel_th/sth.c+19 -60 replies
121/133dmaengine: fsl-edma: Fix NULL pointer exception in fsl_edma_tx_handlerdrivers/dma/fsl-edma.c+7 -00 replies
122/133misc: atmel-ssc: lock with mutex instead of spinlockdrivers/misc/atmel-ssc.c+12 -120 replies
123/133thermal/drivers/cpufreq_cooling: Fix wrong frequency converted from powerdrivers/thermal/cpu_cooling.c+3 -35 replies
124/133arm64: ptrace: Override SPSR.SS when single-stepping is enabledarch/arm64/include/asm/debug-monitors.h arch/arm64/kernel/debug-monitors.c arch/arm64/kernel/ptrace.c+20 -60 replies
125/133arm64: ptrace: Consistently use pseudo-singlestep exceptionsarch/arm64/include/asm/thread_info.h arch/arm64/kernel/ptrace.c arch/arm64/kernel/signal.c +1 more+24 -170 replies
126/133arm64: compat: Ensure upper 32 bits of x0 are zero on syscall returnarch/arm64/include/asm/syscall.h arch/arm64/kernel/syscall.c+14 -10 replies
127/133sched: Fix unreliable rseq cpu_id for new taskskernel/sched/core.c+2 -00 replies
128/133sched/fair: handle case of task_h_load() returning 0kernel/sched/fair.c+9 -10 replies
129/133genirq/affinity: Handle affinity setting on inactive interrupts correctlyarch/x86/kernel/apic/vector.c kernel/irq/manage.c+40 -190 replies
130/133printk: queue wake_up_klogd irq_work only if per-CPU areas are readyinclude/linux/printk.h init/main.c kernel/printk/internal.h +2 more+40 -162 replies
131/133libceph: dont omit recovery_deletes in target_copy()net/ceph/osd_client.c+1 -00 replies
132/133rxrpc: Fix trace stringinclude/trace/events/rxrpc.h+1 -10 replies
133/133spi: sprd: switch the sequence of setting WDG_LOAD_LOW and _HIGHdrivers/spi/spi-sprd-adi.c+1 -10 replies

Reviews trailers per patch

52 of 133 patches have a Reviewed-by or Acked-by.

PatchMathieu DesnoyersHerbert XuJerry SnitselaarJarkko SakkinenJohannes BergLinus WalleijMatt RanostayJames ChapmanPaul Wouters[email protected]Bjørn MorkAndrew LunnFlorian FainelliJens AxboeAdrian HunterAndi ShytiAndrew F. DavisNeil ArmstrongMaxime RipardTomasz DuszynskiDouglas AndersonStephen BoydBoris BrezillonYarivSrinivas Rao LEvan GreenIan AbbottSteffen MaierMinchan KimAnna-Maria BehnsenJuri LelliAnup PatelArnd BergmannAndy ShevchenkoRobin GongLuis MachadoViresh KumarAmit KucheriaFlorian WeimerValentin SchneiderDietmar EggemannAmir GoldsteinJeff LaytonJann HornPetr MladekAmit ShahAli SaidiAmmy YiFrank Mori HessAlan SternPhilippe SchenkerMatthias BruggerVladimir OlteanLorenzo BianconiHans de GoedeRob HerringAlexandru EliseiCameron BerkenpasPeter GeisThomas LamprechtJiri Olsa
1/133A-b
2/133
3/133A-b
4/133T-b
5/133A-b T-b
6/133
7/133
8/133Reported-and-tested-by
9/133A-b
10/133
11/133
12/133
13/133
14/133R-b A-b
15/133
16/133T-b T-b T-b
17/133
18/133
19/133
20/133
21/133
22/133
23/133
24/133
25/133R-b R-b
26/133
27/133
28/133T-b
29/133R-b
30/133A-b
31/133R-b
32/133
33/133
34/133A-b
35/133A-b
36/133A-b
37/133
38/133T-b R-b
39/133R-b
40/133R-b
41/133
42/133
43/133
44/133R-b R-b
45/133R-b R-b
46/133
47/133
48/133R-b
49/133
50/133A-b
51/133R-b A-b
52/133
53/133
54/133
55/133R-b
56/133R-b
57/133
58/133A-b
59/133
60/133R-b
61/133A-b
62/133
63/133R-b
64/133R-b
65/133
66/133
67/133
68/133
69/133
70/133R-b R-b R-b R-b
71/133R-b R-b
72/133R-b R-b
73/133R-b R-b
74/133R-b
75/133R-b
76/133R-b
77/133A-b
78/133
79/133
80/133
81/133
82/133T-b
83/133
84/133
85/133
86/133
87/133
88/133
89/133
90/133
91/133R-b T-b R-b R-b
92/133T-b
93/133
94/133
95/133
96/133
97/133
98/133
99/133A-b R-b
100/133A-b
101/133R-b
102/133
103/133R-b
104/133
105/133
106/133
107/133R-b A-b
108/133
109/133
110/133
111/133R-b T-b
112/133
113/133
114/133R-b
115/133
116/133
117/133R-b
118/133R-b
119/133R-b
120/133R-b T-b
121/133R-b
122/133
123/133A-b R-b
124/133T-b
125/133T-b
126/133
127/133T-b
128/133R-b R-b T-b
129/133T-b
130/133T-b R-b
131/133R-b
132/133
133/133

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 61 reviewers.

Read the v1 thread

Cover letter [PATCH 4.19 000/133] 4.19.134-rc1 review

This is the start of the stable review cycle for the 4.19.134 release. There are 133 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.

Responses should be made by Wed, 22 Jul 2020 15:27:31 +0000. Anything received after that time might be too late.

The whole patch series can be found in one patch at:

	https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.19.134-rc1.gz

or in the git tree and branch at:
git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.19.y
and the diffstat can be found below.

thanks,

greg k-h

-------------
Pseudo-Shortlog of commits:

Greg Kroah-Hartman <[email protected]>

    Linux 4.19.134-rc1

Lingling Xu <[email protected]>
spi: sprd: switch the sequence of setting WDG_LOAD_LOW and _HIGH

David Howells <[email protected]>
rxrpc: Fix trace string

Ilya Dryomov <[email protected]>
libceph: don't omit recovery_deletes in target_copy()

Sergey Senozhatsky <[email protected]>
printk: queue wake_up_klogd irq_work only if per-CPU areas are ready

Thomas Gleixner <[email protected]>
genirq/affinity: Handle affinity setting on inactive interrupts correctly

Vincent Guittot <[email protected]>
sched/fair: handle case of task_h_load() returning 0

Mathieu Desnoyers <[email protected]>
sched: Fix unreliable rseq cpu_id for new tasks

Will Deacon <[email protected]>
arm64: compat: Ensure upper 32 bits of x0 are zero on syscall return

Will Deacon <[email protected]>
arm64: ptrace: Consistently use pseudo-singlestep exceptions

Will Deacon <[email protected]>
arm64: ptrace: Override SPSR.SS when single-stepping is enabled

Finley Xiao <[email protected]>
thermal/drivers/cpufreq_cooling: Fix wrong frequency converted from power

Michał Mirosław <[email protected]>
misc: atmel-ssc: lock with mutex instead of spinlock

Krzysztof Kozlowski <[email protected]>
dmaengine: fsl-edma: Fix NULL pointer exception in fsl_edma_tx_handler

Alexander Shishkin <[email protected]>
intel_th: Fix a NULL dereference when hub driver is not loaded

Alexander Shishkin <[email protected]>
intel_th: pci: Add Emmitsburg PCH support

Alexander Shishkin <[email protected]>
intel_th: pci: Add Tiger Lake PCH-H support

Alexander Shishkin <[email protected]>
intel_th: pci: Add Jasper Lake CPU support

Aneesh Kumar K.V <[email protected]>
powerpc/book3s64/pkeys: Fix pkey_access_permitted() for execute disable pkey

Vishwas M <[email protected]>
hwmon: (emc2103) fix unable to change fan pwm1_enable attribute

Andreas Schwab <[email protected]>
riscv: use 16KB kernel stack on 64-bit

Huacai Chen <[email protected]>
MIPS: Fix build for LTS kernel caused by backporting lpj adjustment

Frederic Weisbecker <[email protected]>
timer: Fix wheel index calculation on last level

Frederic Weisbecker <[email protected]>

    timer: Prevent base->clk from moving backward

Esben Haabendal <[email protected]>
uio_pdrv_genirq: fix use without device tree and no interrupt

David Pedersen <[email protected]>
Input: i8042 - add Lenovo XiaoXin Air 12 to i8042 nomux list

Alexander Usyskin <[email protected]>
mei: bus: don't clean driver pointer

Wade Mealing <[email protected]>
Revert "zram: convert remaining CLASS_ATTR() to CLASS_ATTR_RO()"

Chirantan Ekbote <[email protected]>
fuse: Fix parameter for FS_IOC_{GET,SET}FLAGS

Amir Goldstein <[email protected]>
ovl: fix unneeded call to ovl_change_flags()

Amir Goldstein <[email protected]>
ovl: relax WARN_ON() when decoding lower directory file handle

youngjun <[email protected]>
ovl: inode reference leak in ovl_is_inuse true case.

Chuhong Yuan <[email protected]>
serial: mxs-auart: add missed iounmap() in probe failure and remove

Alexander Lobakin <[email protected]>
virtio: virtio_console: add missing MODULE_DEVICE_TABLE() for rproc serial

Hans de Goede <[email protected]>
virt: vbox: Fix guest capabilities mask check

Hans de Goede <[email protected]>
virt: vbox: Fix VBGL_IOCTL_VMMDEV_REQUEST_BIG and _LOG req numbers to match upstream

AceLan Kao <[email protected]>
USB: serial: option: add Quectel EG95 LTE modem

Jörgen Storvist <[email protected]>
USB: serial: option: add GosunCn GM500 series

Igor Moura <[email protected]>
USB: serial: ch341: add new Product ID for CH340

James Hilliard <[email protected]>
USB: serial: cypress_m8: enable Simply Automated UPB PIM

Johan Hovold <[email protected]>
USB: serial: iuu_phoenix: fix memory corruption

Zhang Qiang <[email protected]>
usb: gadget: function: fix missing spinlock in f_uac1_legacy

Peter Chen <[email protected]>
usb: chipidea: core: add wakeup support for extcon

Minas Harutyunyan <[email protected]>
usb: dwc2: Fix shutdown callback in platform

Tom Rix <[email protected]>
USB: c67x00: fix use after free in c67x00_giveback_urb

Kailang Yang <[email protected]>
ALSA: hda/realtek - Enable Speaker for ASUS UX533 and UX534

Kailang Yang <[email protected]>
ALSA: hda/realtek - change to suitable link model for ASUS platform

Takashi Iwai <[email protected]>
ALSA: usb-audio: Fix race against the error recovery URB submission

Takashi Iwai <[email protected]>
ALSA: line6: Sync the pending work cancel at disconnection

Takashi Iwai <[email protected]>
ALSA: line6: Perform sanity check for each URB creation

James Hilliard <[email protected]>
HID: quirks: Ignore Simply Automated UPB PIM

Sebastian Parschauer <[email protected]>
HID: quirks: Always poll Obins Anne Pro 2 keyboard

Dmitry Torokhov <[email protected]>
HID: magicmouse: do not set up autorepeat

Saravana Kannan <[email protected]>
slimbus: core: Fix mismatch in of_node_get/put

Miquel Raynal <[email protected]>
mtd: rawnand: oxnas: Release all devices in the _remove() path

Miquel Raynal <[email protected]>
mtd: rawnand: oxnas: Unregister all devices on error

Miquel Raynal <[email protected]>
mtd: rawnand: oxnas: Keep track of registered devices

Álvaro Fernández Rojas <[email protected]>
mtd: rawnand: brcmnand: fix CS0 layout

Miquel Raynal <[email protected]>
mtd: rawnand: timings: Fix default tR_max and tCCS_min timings

Miquel Raynal <[email protected]>
mtd: rawnand: marvell: Fix probe error path

Miquel Raynal <[email protected]>
mtd: rawnand: marvell: Use nand_cleanup() when the device is not yet registered

Maulik Shah <[email protected]>
soc: qcom: rpmh-rsc: Allow using free WAKE TCS for active request

Raju P.L.S.S.S.N <[email protected]>
soc: qcom: rpmh-rsc: Clear active mode configuration for wake TCS

Maulik Shah <[email protected]>
soc: qcom: rpmh: Invalidate SLEEP and WAKE TCSes before flushing new data

Maulik Shah <[email protected]>
soc: qcom: rpmh: Update dirty flag only when data changes

Jin Yao <[email protected]>
perf stat: Zero all the 'ena' and 'run' array slot stats for interval mode

John Johansen <[email protected]>
apparmor: ensure that dfa state tables have entries

Kevin Buettner <[email protected]>
copy_xstate_to_kernel: Fix typo which caused GDB regression

Douglas Anderson <[email protected]>
regmap: debugfs: Don't sleep while atomic for fast_io regmaps

Krzysztof Kozlowski <[email protected]>
ARM: dts: socfpga: Align L2 cache-controller nodename with dtschema

Enric Balletbo i Serra <[email protected]>
Revert "thermal: mediatek: fix register index error"

Dan Carpenter <[email protected]>
staging: comedi: verify array index is correct before using it

Michał Mirosław <[email protected]>
usb: gadget: udc: atmel: fix uninitialized read in debug printk

Marc Kleine-Budde <[email protected]>
spi: spi-sun6i: sun6i_spi_transfer_one(): fix setting of clock rate

Jerome Brunet <[email protected]>
arm64: dts: meson: add missing gxl rng clock

Colin Ian King <[email protected]>
phy: sun4i-usb: fix dereference of pointer phy0 before it is null checked

Jonathan Cameron <[email protected]>
iio:health:afe4404 Fix timestamp alignment and prevent data leak.

Christoffer Nielsen <[email protected]>
ALSA: usb-audio: Add registration quirk for Kingston HyperX Cloud Flight S

Paul Menzel <[email protected]>
ACPI: video: Use native backlight on Acer TravelMate 5735Z

Stephan Gerhold <[email protected]>
Input: mms114 - add extra compatible for mms345l

Emmanuel Pescosta <[email protected]>
ALSA: usb-audio: Add registration quirk for Kingston HyperX Cloud Alpha S

Hans de Goede <[email protected]>
ACPI: video: Use native backlight on Acer Aspire 5783z

Takashi Iwai <[email protected]>
ALSA: usb-audio: Rewrite registration quirk handling

Haibo Chen <[email protected]>
mmc: sdhci: do not enable card detect interrupt for gpio cd type

Neil Armstrong <[email protected]>
doc: dt: bindings: usb: dwc3: Update entries for disabling SS instances in park mode

Chris Wulff <[email protected]>
ALSA: usb-audio: Create a registration quirk for Kingston HyperX Amp (0951:16d8)

Diego Elio Pettenò <[email protected]>
scsi: sr: remove references to BLK_DEV_SR_VENDOR, leave it enabled

Claudiu Beznea <[email protected]>
ARM: at91: pm: add quirk for sam9x60's ulp1

Hans de Goede <[email protected]>
HID: quirks: Remove ITE 8595 entry from hid_have_special_driver

Russell King <[email protected]>
net: sfp: add some quirks for GPON modules

Russell King <[email protected]>
net: sfp: add support for module quirks

Sasha Levin <[email protected]>
Revert "usb/ehci-platform: Set PM runtime as active on resume"

Sasha Levin <[email protected]>
Revert "usb/xhci-plat: Set PM runtime as active on resume"

Sasha Levin <[email protected]>
Revert "usb/ohci-platform: Fix a warning when hibernating"

Florian Fainelli <[email protected]>
of: of_mdio: Correct loop scanning logic

Florian Fainelli <[email protected]>
net: dsa: bcm_sf2: Fix node reference count

Krzysztof Kozlowski <[email protected]>
spi: spi-fsl-dspi: Fix lockup if device is shutdown during SPI transfer

Angelo Dureghello <[email protected]>
spi: fix initial SPI_SR value in spi-fsl-dspi

Jonathan Cameron <[email protected]>
iio:health:afe4403 Fix timestamp alignment and prevent data leak.

Jonathan Cameron <[email protected]>
iio:pressure:ms5611 Fix buffer element alignment

Jonathan Cameron <[email protected]>
iio:humidity:hts221 Fix alignment and data leak issues

Navid Emamdoost <[email protected]>
iio: pressure: zpa2326: handle pm_runtime_get_sync failure

Chuhong Yuan <[email protected]>
iio: mma8452: Add missed iio_device_unregister() call in mma8452_probe()

Dinghao Liu <[email protected]>
iio: magnetometer: ak8974: Fix runtime PM imbalance on error

Jonathan Cameron <[email protected]>

    iio:humidity:hdc100x Fix alignment and data leak issues

Jonathan Cameron <[email protected]>
iio:magnetometer:ak8974: Fix alignment and data leak issues

Ard Biesheuvel <[email protected]>
arm64/alternatives: don't patch up internal branches

Andy Shevchenko <[email protected]>
i2c: eg20t: Load module automatically if ID matches

Bob Peterson <[email protected]>
gfs2: read-only mounts should grab the sd_freeze_gl glock

Vasily Averin <[email protected]>

    tpm_tis: extra chip->ops check on error path in tpm_tis_core_init

Ard Biesheuvel <[email protected]>
arm64/alternatives: use subsections for replacement sequences

Angelo Dureghello <[email protected]>
m68k: mm: fix node memblock init

Mike Rapoport <[email protected]>
m68k: nommu: register start of the memory with memblock

Navid Emamdoost <[email protected]>
drm/exynos: fix ref count leak in mic_pre_enable

Bernard Zhao <[email protected]>
drm/msm: fix potential memleak in error branch

Toke Høiland-Jørgensen <[email protected]>
vlan: consolidate VLAN parsing code and limit max parsing depth

Toke Høiland-Jørgensen <[email protected]>
sched: consistently handle layer3 header accesses in the presence of VLANs

Cong Wang <[email protected]>
cgroup: Fix sock_cgroup_data on big-endian.

Cong Wang <[email protected]>
cgroup: fix cgroup_sk_alloc() for sk_clone_lock()

Eric Dumazet <[email protected]>
tcp: md5: allow changing MD5 keys in all socket states

Eric Dumazet <[email protected]>

    tcp: md5: refine tcp_md5_do_add()/tcp_md5_hash_key() barriers

Eric Dumazet <[email protected]>
tcp: md5: do not send silly options in SYNCOOKIES

Eric Dumazet <[email protected]>
tcp: md5: add missing memory barriers in tcp_md5_do_add()/tcp_md5_hash_key()

Christoph Paasch <[email protected]>
tcp: make sure listeners don't initialize congestion-control state

Eric Dumazet <[email protected]>
tcp: fix SO_RCVLOWAT possible hangs under high mem pressure

AceLan Kao <[email protected]>
net: usb: qmi_wwan: add support for Quectel EG95 LTE modem

Cong Wang <[email protected]>
net_sched: fix a memory leak in atm_tc_init()

Martin Varghese <[email protected]>

    net: Added pointer check for dst->ops->neigh_lookup in dst_neigh_lookup_skb

Eric Dumazet <[email protected]>
llc: make sure applications use ARPHRD_ETHER

Xin Long <[email protected]>
l2tp: remove skb_dst_set() from l2tp_xmit_skb()

Sabrina Dubroca <[email protected]>
ipv4: fill fl4_icmp_{type,code} in ping_v4_sendmsg

Sean Tranchetti <[email protected]>
genetlink: remove genl_bind

Taehee Yoo <[email protected]>
net: rmnet: fix lower interface leak

Changbin Du <[email protected]>
perf: Make perf able to build with latest libbfd

-------------

Diffstat:

 Documentation/devicetree/bindings/usb/dwc3.txt     |  2 +
 Makefile                                           |  4 +-
 arch/alpha/defconfig                               |  1 -
 arch/arm/boot/dts/socfpga.dtsi                     |  2 +-
 arch/arm/boot/dts/socfpga_arria10.dtsi             |  2 +-
 arch/arm/configs/rpc_defconfig                     |  1 -
 arch/arm/configs/s3c2410_defconfig                 |  1 -
 arch/arm/mach-at91/pm_suspend.S                    |  4 +
 arch/arm64/boot/dts/amlogic/meson-gxl.dtsi         |  5 ++
 arch/arm64/include/asm/alternative.h               | 16 ++--
 arch/arm64/include/asm/debug-monitors.h            |  2 +
 arch/arm64/include/asm/syscall.h                   | 12 ++-
 arch/arm64/include/asm/thread_info.h               |  1 +
 arch/arm64/kernel/alternative.c                    | 16 +---
 arch/arm64/kernel/debug-monitors.c                 | 20 ++++-
 arch/arm64/kernel/ptrace.c                         | 29 +++++--
 arch/arm64/kernel/signal.c                         | 11 +--
 arch/arm64/kernel/syscall.c                        |  5 +-
 arch/arm64/kernel/vmlinux.lds.S                    |  3 -
 arch/ia64/configs/zx1_defconfig                    |  1 -
 arch/m68k/configs/amiga_defconfig                  |  1 -
 arch/m68k/configs/apollo_defconfig                 |  1 -
 arch/m68k/configs/atari_defconfig                  |  1 -
 arch/m68k/configs/bvme6000_defconfig               |  1 -
 arch/m68k/configs/hp300_defconfig                  |  1 -
 arch/m68k/configs/mac_defconfig                    |  1 -
 arch/m68k/configs/multi_defconfig                  |  1 -
 arch/m68k/configs/mvme147_defconfig                |  1 -
 arch/m68k/configs/mvme16x_defconfig                |  1 -
 arch/m68k/configs/q40_defconfig                    |  1 -
 arch/m68k/configs/sun3_defconfig                   |  1 -
 arch/m68k/configs/sun3x_defconfig                  |  1 -
 arch/m68k/kernel/setup_no.c                        |  3 +-
 arch/m68k/mm/mcfmmu.c                              |  2 +-
 arch/mips/configs/bigsur_defconfig                 |  1 -
 arch/mips/configs/fuloong2e_defconfig              |  1 -
 arch/mips/configs/ip27_defconfig                   |  1 -
 arch/mips/configs/ip32_defconfig                   |  1 -
 arch/mips/configs/jazz_defconfig                   |  1 -
 arch/mips/configs/malta_defconfig                  |  1 -
 arch/mips/configs/malta_kvm_defconfig              |  1 -
 arch/mips/configs/malta_kvm_guest_defconfig        |  1 -
 arch/mips/configs/maltaup_xpa_defconfig            |  1 -
 arch/mips/configs/rm200_defconfig                  |  1 -
 arch/mips/kernel/time.c                            | 13 +--
 arch/powerpc/configs/85xx-hw.config                |  1 -
 arch/powerpc/configs/amigaone_defconfig            |  1 -
 arch/powerpc/configs/chrp32_defconfig              |  1 -
 arch/powerpc/configs/g5_defconfig                  |  1 -
 arch/powerpc/configs/maple_defconfig               |  1 -
 arch/powerpc/configs/pasemi_defconfig              |  1 -
 arch/powerpc/configs/pmac32_defconfig              |  1 -
 arch/powerpc/configs/powernv_defconfig             |  1 -
 arch/powerpc/configs/ppc64_defconfig               |  1 -
 arch/powerpc/configs/ppc64e_defconfig              |  1 -
 arch/powerpc/configs/ppc6xx_defconfig              |  1 -
 arch/powerpc/configs/pseries_defconfig             |  1 -
 arch/powerpc/configs/skiroot_defconfig             |  1 -
 arch/powerpc/mm/pkeys.c                            | 12 +--
 arch/riscv/include/asm/thread_info.h               |  4 +
 arch/sh/configs/sh03_defconfig                     |  1 -
 arch/sparc/configs/sparc64_defconfig               |  1 -
 arch/x86/configs/i386_defconfig                    |  1 -
 arch/x86/configs/x86_64_defconfig                  |  1 -
 arch/x86/kernel/apic/vector.c                      | 22 ++---
 arch/x86/kernel/fpu/xstate.c                       |  2 +-
 drivers/acpi/video_detect.c                        | 19 +++++
 drivers/base/regmap/regmap-debugfs.c               | 52 +++++++-----
 drivers/block/zram/zram_drv.c                      |  3 +-
 drivers/char/tpm/tpm_tis_core.c                    |  2 +-
 drivers/char/virtio_console.c                      |  3 +-
 drivers/dma/fsl-edma.c                             |  7 ++
 drivers/gpu/drm/exynos/exynos_drm_mic.c            |  4 +-
 drivers/gpu/drm/msm/msm_submitqueue.c              |  4 +-
 drivers/hid/hid-ids.h                              |  3 +
 drivers/hid/hid-magicmouse.c                       |  6 ++
 drivers/hid/hid-quirks.c                           |  5 +-
 drivers/hwmon/emc2103.c                            |  2 +-
 drivers/hwtracing/intel_th/core.c                  | 21 ++++-
 drivers/hwtracing/intel_th/pci.c                   | 15 ++++
 drivers/hwtracing/intel_th/sth.c                   |  4 +-
 drivers/i2c/busses/i2c-eg20t.c                     |  1 +
 drivers/iio/accel/mma8452.c                        |  5 +-
 drivers/iio/health/afe4403.c                       | 13 +--
 drivers/iio/health/afe4404.c                       |  8 +-
 drivers/iio/humidity/hdc100x.c                     | 10 ++-
 drivers/iio/humidity/hts221.h                      |  7 +-
 drivers/iio/humidity/hts221_buffer.c               |  9 +-
 drivers/iio/magnetometer/ak8974.c                  | 29 ++++---
 drivers/iio/pressure/ms5611_core.c                 | 11 ++-
 drivers/iio/pressure/zpa2326.c                     |  4 +-
 drivers/input/serio/i8042-x86ia64io.h              |  7 ++
 drivers/input/touchscreen/mms114.c                 | 17 +++-
 drivers/misc/atmel-ssc.c                           | 24 +++---
 drivers/misc/mei/bus.c                             |  3 +-
 drivers/mmc/host/sdhci.c                           |  2 +-
 drivers/mtd/nand/raw/brcmnand/brcmnand.c           |  5 +-
 drivers/mtd/nand/raw/marvell_nand.c                | 25 +++---
 drivers/mtd/nand/raw/nand_timings.c                |  5 +-
 drivers/mtd/nand/raw/oxnas_nand.c                  | 24 ++++--
 drivers/net/dsa/bcm_sf2.c                          |  2 +
 drivers/net/ethernet/qualcomm/rmnet/rmnet_config.c | 19 +++--
 drivers/net/phy/sfp-bus.c                          | 79 +++++++++++++++++
 drivers/net/usb/qmi_wwan.c                         |  1 +
 drivers/of/of_mdio.c                               |  9 +-
 drivers/phy/allwinner/phy-sun4i-usb.c              |  5 +-
 drivers/scsi/Kconfig                               |  9 --
 drivers/scsi/sr_vendor.c                           |  8 --
 drivers/slimbus/core.c                             |  1 +
 drivers/soc/qcom/rpmh-rsc.c                        | 98 ++++++++++++++--------
 drivers/soc/qcom/rpmh.c                            | 56 ++++++-------
 drivers/spi/spi-fsl-dspi.c                         | 17 +---
 drivers/spi/spi-sprd-adi.c                         |  2 +-
 drivers/spi/spi-sun6i.c                            | 14 ++--
 drivers/staging/comedi/drivers/addi_apci_1500.c    | 10 ++-
 drivers/thermal/cpu_cooling.c                      |  6 +-
 drivers/thermal/mtk_thermal.c                      |  6 +-
 drivers/tty/serial/mxs-auart.c                     | 12 ++-
 drivers/uio/uio_pdrv_genirq.c                      |  2 +-
 drivers/usb/c67x00/c67x00-sched.c                  |  2 +-
 drivers/usb/chipidea/core.c                        | 24 ++++++
 drivers/usb/dwc2/platform.c                        |  3 +-
 drivers/usb/gadget/function/f_uac1_legacy.c        |  2 +
 drivers/usb/gadget/udc/atmel_usba_udc.c            |  2 +-
 drivers/usb/host/ehci-platform.c                   |  4 -
 drivers/usb/host/ohci-platform.c                   |  5 --
 drivers/usb/host/xhci-plat.c                       | 10 +--
 drivers/usb/serial/ch341.c                         |  1 +
 drivers/usb/serial/cypress_m8.c                    |  2 +
 drivers/usb/serial/cypress_m8.h                    |  3 +
 drivers/usb/serial/iuu_phoenix.c                   |  8 +-
 drivers/usb/serial/option.c                        |  6 ++
 drivers/virt/vboxguest/vboxguest_core.c            |  6 +-
 drivers/virt/vboxguest/vboxguest_core.h            | 15 ++++
 drivers/virt/vboxguest/vboxguest_linux.c           |  3 +-
 drivers/virt/vboxguest/vmmdev.h                    |  2 +
 fs/fuse/file.c                                     | 12 ++-
 fs/gfs2/ops_fstype.c                               | 12 ++-
 fs/overlayfs/export.c                              |  2 +-
 fs/overlayfs/file.c                                | 10 ++-
 fs/overlayfs/super.c                               | 11 ++-
 include/linux/cgroup-defs.h                        |  8 +-
 include/linux/cgroup.h                             |  4 +-
 include/linux/if_vlan.h                            | 29 +++++--
 include/linux/printk.h                             |  5 --
 include/net/dst.h                                  | 10 ++-
 include/net/genetlink.h                            |  8 --
 include/net/inet_ecn.h                             | 23 +++--
 include/net/pkt_sched.h                            | 11 ---
 include/trace/events/rxrpc.h                       |  2 +-
 include/uapi/linux/vboxguest.h                     |  4 +-
 init/main.c                                        |  1 -
 kernel/cgroup/cgroup.c                             | 29 ++++---
 kernel/irq/manage.c                                | 37 +++++++-
 kernel/printk/internal.h                           |  5 ++
 kernel/printk/printk.c                             | 34 ++++++++
 kernel/printk/printk_safe.c                        | 11 +--
 kernel/sched/core.c                                |  2 +
 kernel/sched/fair.c                                | 10 ++-
 kernel/time/timer.c                                | 21 +++--
 net/ceph/osd_client.c                              |  1 +
 net/core/filter.c                                  |  8 +-
 net/core/sock.c                                    |  2 +-
 net/ipv4/ping.c                                    |  3 +
 net/ipv4/tcp.c                                     | 15 ++--
 net/ipv4/tcp_cong.c                                |  2 +-
 net/ipv4/tcp_input.c                               |  2 +
 net/ipv4/tcp_ipv4.c                                | 15 +++-
 net/ipv4/tcp_output.c                              |  8 +-
 net/l2tp/l2tp_core.c                               |  5 +-
 net/llc/af_llc.c                                   | 10 ++-
 net/netlink/genetlink.c                            | 49 -----------
 net/sched/act_connmark.c                           |  9 +-
 net/sched/act_csum.c                               |  2 +-
 net/sched/act_skbedit.c                            |  2 +-
 net/sched/cls_api.c                                |  2 +-
 net/sched/cls_flow.c                               |  8 +-
 net/sched/cls_flower.c                             |  2 +-
 net/sched/em_ipset.c                               |  2 +-
 net/sched/em_meta.c                                |  2 +-
 net/sched/sch_atm.c                                |  8 +-
 net/sched/sch_cake.c                               |  4 +-
 net/sched/sch_dsmark.c                             |  6 +-
 net/sched/sch_teql.c                               |  2 +-
 security/apparmor/match.c                          |  5 ++
 sound/pci/hda/patch_realtek.c                      |  6 +-
 sound/usb/card.c                                   | 12 ++-
 sound/usb/line6/capture.c                          |  2 +
 sound/usb/line6/driver.c                           |  2 +-
 sound/usb/line6/playback.c                         |  2 +
 sound/usb/midi.c                                   | 17 ++--
 sound/usb/quirks.c                                 | 36 ++++++++
 sound/usb/quirks.h                                 |  2 +
 tools/perf/util/srcline.c                          | 16 +++-
 tools/perf/util/stat.c                             |  6 +-
 195 files changed, 1033 insertions(+), 591 deletions(-)