Skip to content

arm: don't call addr_limit_user_check for nommu

Christoph Hellwig linux-arch linux-arm-kernel linux-riscv lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest6 patches 16 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6syscalls: use uaccess_kernel in addr_limit_user_checkinclude/linux/syscalls.h+1 -112 replies
2/6nds32: use uaccess_kernel in show_regsarch/nds32/kernel/process.c+1 -10 replies
3/6riscv: include <asm/pgtable.h> in <asm/uaccess.h>arch/riscv/include/asm/uaccess.h+2 -00 replies
4/6uaccess: remove segment_eqarch/alpha/include/asm/uaccess.h arch/arc/include/asm/segment.h arch/arm/include/asm/uaccess.h +21 more+25 -321 reply
5/6uaccess: add force_uaccess_{begin,end} helpersarch/arm64/kernel/sdei.c arch/m68k/include/asm/tlbflush.h arch/mips/kernel/unaligned.c +9 more+63 -561 reply
6/6exec: use force_uaccess_begin during exec and exitfs/exec.c kernel/exit.c+7 -22 replies

Reviews trailers per patch

4 of 6 patches have a Reviewed-by or Acked-by.

PatchGreentime HuGeert UytterhoevenMark RutlandEric W. BiedermanGuenter Roeck
1/6T-b
2/6A-b
3/6
4/6A-b A-b
5/6A-b A-b A-b
6/6A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 5 reviewers.

Read the v1 thread

Cover letter [PATCH 0/6] arm: don't call addr_limit_user_check for nommu

On arm nommu kernel use the same constant for USER_DS and KERNEL_DS, and seqment_eq always returns false. With the current check in addr_limit_user_check that works by accident, but when replacing seqment_eq with uaccess_kerne it will fail. Just remove the not needed check entirely.

---

Andrew: this should preferably go before the other patches in this series.

 arch/arm/kernel/signal.c | 2 ++
 1 file changed, 2 insertions(+)
arch/arm/kernel/signal.c +2 -0
index ab2568996ddb0c..c9dc912b83f012 100644
@@ -713,7 +713,9 @@ struct page *get_signal_page(void)
 /* Defer to generic check */
 asmlinkage void addr_limit_check_failed(void)
 {
+#ifdef CONFIG_MMU
 	addr_limit_user_check();
+#endif
 }
 
 #ifdef CONFIG_DEBUG_RSEQ
Signature · 1 line
2.27.0