Skip to content

raw/ioat: enhancements and new hardware support

Bruce Richardson dpdk-dev 6 versions – Applied

Status from this message: Applied, thanks

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v6 Latest25 patches 1 replyApplied
  2. v525 patches 0 repliesSuperseded
  3. v425 patches 3 repliesSuperseded
Earlier versions · 3
VersionPostedPatchesRepliesStatus
v325 patches2 repliesSuperseded
v218 patches7 repliesSuperseded
v120 patches0 repliesSuperseded

Changes in v6 from the cover letter

* Add explicit __rte_experimental tag on all functions. [Previously header just had note saying all contents are experimental]

Patches in v6 Applied

#Subject and filesSizeRepliesApplied
1/25doc/api: add ioat driver to indexdoc/api/doxy-api-index.md doc/api/doxy-api.conf.in+2 -00 replies
2/25raw/ioat: fix missing close functiondrivers/raw/ioat/ioat_rawdev.c+7 -00 replies
3/25raw/ioat: enable use from C++ codedrivers/raw/ioat/rte_ioat_rawdev.h+17 -60 replies
4/25raw/ioat: include extra info in error messagesdrivers/raw/ioat/ioat_rawdev_test.c+35 -180 replies
5/25raw/ioat: add a flag to control copying handle parametersdoc/guides/rawdevs/ioat.rst doc/guides/rel_notes/release_20_11.rst drivers/raw/ioat/ioat_rawdev.c +1 more+45 -110 replies
6/25raw/ioat: split header for readabilitydrivers/raw/ioat/meson.build drivers/raw/ioat/rte_ioat_rawdev.h drivers/raw/ioat/rte_ioat_rawdev_fns.h+175 -1410 replies
7/25raw/ioat: rename functions to be operation-agnosticdoc/guides/rawdevs/ioat.rst doc/guides/rel_notes/release_20_11.rst doc/guides/sample_app_ug/ioat.rst +5 more+56 -310 replies
8/25raw/ioat: add separate API for fence calldoc/guides/rawdevs/ioat.rst doc/guides/rel_notes/release_20_11.rst drivers/raw/ioat/ioat_rawdev_test.c +3 more+51 -230 replies
9/25raw/ioat: make the HW register spec privatedrivers/raw/ioat/ioat_rawdev.c drivers/raw/ioat/ioat_spec.h drivers/raw/ioat/meson.build +1 more+44 -310 replies
10/25usertools/dpdk-devbind.py: add support for DSA HWdoc/guides/rel_notes/release_20_11.rst usertools/dpdk-devbind.py+7 -10 replies
11/25raw/ioat: add skeleton for VFIO/UIO based DSA devicedoc/guides/rawdevs/ioat.rst drivers/raw/ioat/idxd_pci.c drivers/raw/ioat/ioat_private.h +2 more+108 -590 replies
12/25raw/ioat: add vdev probe for DSA/idxd devicesdoc/guides/rawdevs/ioat.rst drivers/raw/ioat/idxd_vdev.c drivers/raw/ioat/meson.build+192 -50 replies
13/25raw/ioat: include example configuration scriptdoc/guides/rawdevs/ioat.rst drivers/raw/ioat/dpdk_idxd_cfg.py+81 -00 replies
14/25raw/ioat: create rawdev instances on idxd PCI probedrivers/raw/ioat/idxd_pci.c drivers/raw/ioat/ioat_common.c drivers/raw/ioat/ioat_private.h +4 more+442 -30 replies
15/25raw/ioat: create rawdev instances for idxd vdevsdrivers/raw/ioat/idxd_vdev.c drivers/raw/ioat/ioat_private.h+109 -10 replies
16/25raw/ioat: add datapath data structures for idxd devicesdrivers/raw/ioat/idxd_pci.c drivers/raw/ioat/idxd_vdev.c drivers/raw/ioat/ioat_common.c +3 more+120 -10 replies
17/25raw/ioat: add configure function for idxd devicesdrivers/raw/ioat/idxd_pci.c drivers/raw/ioat/idxd_vdev.c drivers/raw/ioat/ioat_common.c +2 more+70 -00 replies
18/25raw/ioat: add start and stop functions for idxd devicesdrivers/raw/ioat/idxd_pci.c+50 -00 replies
19/25raw/ioat: add data path for idxd devicesdrivers/raw/ioat/ioat_common.c drivers/raw/ioat/ioat_rawdev.c drivers/raw/ioat/rte_ioat_rawdev_fns.h+192 -110 replies
20/25raw/ioat: add info function for idxd devicesdrivers/raw/ioat/idxd_pci.c drivers/raw/ioat/idxd_vdev.c drivers/raw/ioat/ioat_common.c +1 more+23 -00 replies
21/25raw/ioat: create separate statistics structuredrivers/raw/ioat/ioat_rawdev.c drivers/raw/ioat/rte_ioat_rawdev_fns.h+29 -410 replies
22/25raw/ioat: move xstats functions to common filedrivers/raw/ioat/ioat_common.c drivers/raw/ioat/ioat_private.h drivers/raw/ioat/ioat_rawdev.c+69 -580 replies
23/25raw/ioat: add xstats tracking for idxd devicesdrivers/raw/ioat/idxd_pci.c drivers/raw/ioat/idxd_vdev.c drivers/raw/ioat/ioat_rawdev_test.c +1 more+13 -10 replies
24/25raw/ioat: clean up use of common test functiondrivers/raw/ioat/idxd_pci.c drivers/raw/ioat/idxd_vdev.c drivers/raw/ioat/ioat_private.h +2 more+4 -130 replies
25/25raw/ioat: add fill operationdoc/guides/rawdevs/ioat.rst doc/guides/rel_notes/release_20_11.rst drivers/raw/ioat/ioat_rawdev_test.c +2 more+161 -50 replies

Reviews trailers per patch

All 25 patches have a Reviewed-by or Acked-by.

PatchKevin LaatzRadu NicolauBruce RichardsonSunil Pai G
1/25R-b A-b
2/25A-b R-b A-b
3/25R-b A-b
4/25R-b A-b
5/25R-b A-b
6/25R-b A-b
7/25R-b A-b
8/25R-b A-b
9/25R-b A-b
10/25A-b
11/25R-b A-b
12/25A-b
13/25R-b A-b
14/25R-b A-b
15/25A-b
16/25R-b A-b
17/25R-b A-b
18/25R-b A-b
19/25R-b A-b
20/25R-b A-b
21/25R-b A-b
22/25R-b A-b
23/25R-b A-b
24/25R-b A-b
25/25A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.

Read the v6 thread

Cover letter [dpdk-dev] [PATCH v6 00/25] raw/ioat: enhancements and new hardware support

This patchset adds some small enhancements, some rework and also support for new hardware to the ioat rawdev driver. Most rework and enhancements are largely self-explanatory from the individual patches.

The new hardware support is for the Intel(R) DSA accelerator which will be present in future Intel processors. A description of this new hardware is covered in [1]. Functions specific to the new hardware use the "idxd" prefix, for consistency with the kernel driver.

[1] https://01.org/blogs/2019/introducing-intel-data-streaming-accelerator

---
V6:
* Add explicit __rte_experimental tag on all functions. [Previously header just had note saying all contents are experimental]

V5:
* Rebased to latest main branch.

V4:
* Fixed compile with FreeBSD clang
* Improved autotests for fill operation

V3:
* More doc updates including release note updates throughout the set
* Added in fill operation
* Added in fix for missing close operation
* Added in fix for doc building to ensure ioat is in in the index

V2:
* Included documentation additions in the set
* Split off the rawdev unit test changes to a separate patchset for easier review
* General code improvements and cleanups

Bruce Richardson (19):
doc/api: add ioat driver to index
raw/ioat: enable use from C++ code
raw/ioat: include extra info in error messages raw/ioat: split header for readability raw/ioat: rename functions to be operation-agnostic raw/ioat: add separate API for fence call raw/ioat: make the HW register spec private raw/ioat: add skeleton for VFIO/UIO based DSA device raw/ioat: include example configuration script raw/ioat: create rawdev instances on idxd PCI probe raw/ioat: add datapath data structures for idxd devices raw/ioat: add configure function for idxd devices raw/ioat: add start and stop functions for idxd devices raw/ioat: add data path for idxd devices raw/ioat: add info function for idxd devices raw/ioat: create separate statistics structure raw/ioat: move xstats functions to common file raw/ioat: add xstats tracking for idxd devices raw/ioat: clean up use of common test function

Cheng Jiang (1):
raw/ioat: add a flag to control copying handle parameters

Kevin Laatz (5):
raw/ioat: fix missing close function usertools/dpdk-devbind.py: add support for DSA HW raw/ioat: add vdev probe for DSA/idxd devices raw/ioat: create rawdev instances for idxd vdevs raw/ioat: add fill operation

 doc/api/doxy-api-index.md                     |   1 +
 doc/api/doxy-api.conf.in                      |   1 +
 doc/guides/rawdevs/ioat.rst                   | 163 +++--
 doc/guides/rel_notes/release_20_11.rst        |  23 +
 doc/guides/sample_app_ug/ioat.rst             |   8 +-
 drivers/raw/ioat/dpdk_idxd_cfg.py             |  79 +++
 drivers/raw/ioat/idxd_pci.c                   | 345 ++++++++++
 drivers/raw/ioat/idxd_vdev.c                  | 233 +++++++
 drivers/raw/ioat/ioat_common.c                | 244 +++++++
 drivers/raw/ioat/ioat_private.h               |  82 +++
 drivers/raw/ioat/ioat_rawdev.c                |  92 +--
 drivers/raw/ioat/ioat_rawdev_test.c           | 130 +++-
 .../raw/ioat/{rte_ioat_spec.h => ioat_spec.h} |  90 ++-
 drivers/raw/ioat/meson.build                  |  15 +-
 drivers/raw/ioat/rte_ioat_rawdev.h            | 226 +++----
 drivers/raw/ioat/rte_ioat_rawdev_fns.h        | 595 ++++++++++++++++++
 examples/ioat/ioatfwd.c                       |  16 +-
 lib/librte_eal/include/rte_common.h           |   1 +
 usertools/dpdk-devbind.py                     |   6 +-
 19 files changed, 1996 insertions(+), 354 deletions(-)
 create mode 100755 drivers/raw/ioat/dpdk_idxd_cfg.py
 create mode 100644 drivers/raw/ioat/idxd_pci.c
 create mode 100644 drivers/raw/ioat/idxd_vdev.c
 create mode 100644 drivers/raw/ioat/ioat_common.c
 create mode 100644 drivers/raw/ioat/ioat_private.h
 rename drivers/raw/ioat/{rte_ioat_spec.h => ioat_spec.h} (74%)
 create mode 100644 drivers/raw/ioat/rte_ioat_rawdev_fns.h
Signature · 1 line
2.25.1