Skip to content

RFC: move logical block size checking to the block core

Maxim Levitsky linux-block linux-mmc linux-scsi lkml virtualization 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest10 patches 22 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/10block: introduce blk_is_valid_logical_block_sizeblock/blk-settings.c include/linux/blkdev.h+19 -05 replies
2/10block: virtio-blk: check logical block sizedrivers/block/virtio_blk.c+13 -27 replies
3/10block: loop: use blk_is_valid_logical_block_sizedrivers/block/loop.c+5 -181 reply
4/10block: nbd: use blk_is_valid_logical_block_sizedrivers/block/nbd.c+2 -101 reply
5/10block: null: use blk_is_valid_logical_block_sizedrivers/block/null_blk_main.c+3 -32 replies
6/10block: ms_block: use blk_is_valid_logical_block_sizedrivers/memstick/core/ms_block.c+1 -11 reply
7/10block: mspro_blk: use blk_is_valid_logical_block_sizedrivers/memstick/core/mspro_block.c+6 -01 reply
8/10block: nvme: use blk_is_valid_logical_block_sizedrivers/nvme/host/core.c+8 -91 reply
9/10block: scsi: sd: use blk_is_valid_logical_block_sizedrivers/scsi/sd.c+1 -42 replies
10/10block: scsi: sr: use blk_is_valid_logical_block_sizedrivers/scsi/sr.c+13 -181 reply

Reviews trailers per patch

7 of 10 patches have a Reviewed-by or Acked-by.

PatchDamien Le MoalStefan Hajnoczi
1/10
2/10R-b R-b
3/10R-b
4/10R-b
5/10
6/10R-b
7/10R-b
8/10R-b
9/10R-b
10/10

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 00/10] RFC: move logical block size checking to the block core

This patch series aims to move the logical block size checking to the block code.

This was inspired by missing check for valid logical block size in virtio-blk which causes the kernel to crash in a weird way later on when it is invalid.

I added blk_is_valid_logical_block_size which returns true iff the block size is one of supported sizes.

I added this check to virtio-blk, and also converted few block drivers that I am familiar with to use this interface instead of their own implementation.

Best regards,
Maxim Levitsky

Maxim Levitsky (10):
block: introduce blk_is_valid_logical_block_size
block: virtio-blk: check logical block size
block: loop: use blk_is_valid_logical_block_size
block: nbd: use blk_is_valid_logical_block_size
block: null: use blk_is_valid_logical_block_size
block: ms_block: use blk_is_valid_logical_block_size
block: mspro_blk: use blk_is_valid_logical_block_size
block: nvme: use blk_is_valid_logical_block_size
block: scsi: sd: use blk_is_valid_logical_block_size
block: scsi: sr: use blk_is_valid_logical_block_size

 block/blk-settings.c                | 18 +++++++++++++++++
 drivers/block/loop.c                | 23 +++++----------------
 drivers/block/nbd.c                 | 12 ++---------
 drivers/block/null_blk_main.c       |  6 +++---
 drivers/block/virtio_blk.c          | 15 ++++++++++++--
 drivers/memstick/core/ms_block.c    |  2 +-
 drivers/memstick/core/mspro_block.c |  6 ++++++
 drivers/nvme/host/core.c            | 17 ++++++++--------
 drivers/scsi/sd.c                   |  5 +----
 drivers/scsi/sr.c                   | 31 ++++++++++++-----------------
 include/linux/blkdev.h              |  1 +
 11 files changed, 71 insertions(+), 65 deletions(-)
Signature · 1 line
2.26.2