RFC: move logical block size checking to the block core
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest10 patches 22 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/10 | block: introduce blk_is_valid_logical_block_sizeblock/ include/ | +19 | 5 replies | |
| 2/10 | block: virtio-blk: check logical block sizedrivers/ | +13 | 7 replies | |
| 3/10 | block: loop: use blk_is_valid_logical_block_sizedrivers/ | +5 | 1 reply | |
| 4/10 | block: nbd: use blk_is_valid_logical_block_sizedrivers/ | +2 | 1 reply | |
| 5/10 | block: null: use blk_is_valid_logical_block_sizedrivers/ | +3 | 2 replies | |
| 6/10 | block: ms_block: use blk_is_valid_logical_block_sizedrivers/ | +1 | 1 reply | |
| 7/10 | block: mspro_blk: use blk_is_valid_logical_block_sizedrivers/ | +6 | 1 reply | |
| 8/10 | block: nvme: use blk_is_valid_logical_block_sizedrivers/ | +8 | 1 reply | |
| 9/10 | block: scsi: sd: use blk_is_valid_logical_block_sizedrivers/ | +1 | 2 replies | |
| 10/10 | block: scsi: sr: use blk_is_valid_logical_block_sizedrivers/ | +13 | 1 reply |
Reviews trailers per patch
7 of 10 patches have a Reviewed-by or Acked-by.
| Patch | Damien Le Moal | Stefan Hajnoczi |
|---|---|---|
| 1/10 | ||
| 2/10 | R-b | R-b |
| 3/10 | R-b | |
| 4/10 | R-b | |
| 5/10 | ||
| 6/10 | R-b | |
| 7/10 | R-b | |
| 8/10 | R-b | |
| 9/10 | R-b | |
| 10/10 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH 00/10] RFC: move logical block size checking to the block core
This patch series aims to move the logical block size checking to the block code.
This was inspired by missing check for valid logical block size in virtio-blk which causes the kernel to crash in a weird way later on when it is invalid.
I added blk_is_valid_logical_block_size which returns true iff the block size is one of supported sizes.
I added this check to virtio-blk, and also converted few block drivers that I am familiar with to use this interface instead of their own implementation.
Best regards,
Maxim Levitsky
Maxim Levitsky (10):
block: introduce blk_is_valid_logical_block_size
block: virtio-blk: check logical block size
block: loop: use blk_is_valid_logical_block_size
block: nbd: use blk_is_valid_logical_block_size
block: null: use blk_is_valid_logical_block_size
block: ms_block: use blk_is_valid_logical_block_size
block: mspro_blk: use blk_is_valid_logical_block_size
block: nvme: use blk_is_valid_logical_block_size
block: scsi: sd: use blk_is_valid_logical_block_size
block: scsi: sr: use blk_is_valid_logical_block_size
block/blk-settings.c | 18 +++++++++++++++++ drivers/block/loop.c | 23 +++++---------------- drivers/block/nbd.c | 12 ++--------- drivers/block/null_blk_main.c | 6 +++--- drivers/block/virtio_blk.c | 15 ++++++++++++-- drivers/memstick/core/ms_block.c | 2 +- drivers/memstick/core/mspro_block.c | 6 ++++++ drivers/nvme/host/core.c | 17 ++++++++-------- drivers/scsi/sd.c | 5 +---- drivers/scsi/sr.c | 31 ++++++++++++----------------- include/linux/blkdev.h | 1 + 11 files changed, 71 insertions(+), 65 deletions(-)
Signature · 1 line
2.26.2