Skip to content

hw/nvram/fw_cfg: Let fw_cfg_add_from_generator() return boolean value

Philippe Mathieu-Daudé qemu-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v2 Latest2 patches 2 repliesIn review

Changes in v2 from the cover letter

- Addressed Markus review comments
- Added patch to clarify fw_cfg_add_from_generator (Markus)

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2hw/nvram/fw_cfg: Simplify fw_cfg_add_from_generator() error propagationhw/nvram/fw_cfg.c include/hw/nvram/fw_cfg.h+4 -31 reply
2/2hw/nvram/fw_cfg: Let fw_cfg_add_from_generator() return boolean valuehw/nvram/fw_cfg.c include/hw/nvram/fw_cfg.h softmmu/vl.c+10 -100 replies

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchLaszlo ErsekMarkus Armbruster
1/2R-b
2/2R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/2] hw/nvram/fw_cfg: Let fw_cfg_add_from_generator() return boolean value

Since v1:
- Addressed Markus review comments
- Added patch to clarify fw_cfg_add_from_generator (Markus)

Philippe Mathieu-Daudé (2):
hw/nvram/fw_cfg: Simplify fw_cfg_add_from_generator() error
propagation
hw/nvram/fw_cfg: Let fw_cfg_add_from_generator() return boolean value

 include/hw/nvram/fw_cfg.h |  8 ++++++--
 hw/nvram/fw_cfg.c         | 13 +++++++------
 softmmu/vl.c              |  6 +-----
 3 files changed, 14 insertions(+), 13 deletions(-)
Signature · 1 line
2.21.3