Skip to content

udp_tunnel: convert Intel drivers with shared tables

Jakub Kicinski netdev 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest10 patches 3 repliesIn review
  2. v17 patches 14 repliesSuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/10udp_tunnel: add the ability to share port tablesinclude/net/udp_tunnel.h net/ipv4/udp_tunnel_nic.c+110 -100 replies
2/10netdevsim: add warnings on unexpected UDP tunnel port errorsdrivers/net/netdevsim/udp_tunnels.c+9 -40 replies
3/10netdevsim: shared UDP tunnel port table supportdrivers/net/netdevsim/netdevsim.h drivers/net/netdevsim/udp_tunnels.c+22 -20 replies
4/10selftests: net: add a test for shared UDP tunnel info tablestools/testing/selftests/drivers/net/netdevsim/udp_tunnel_nic.sh+109 -00 replies
5/10i40e: convert to new udp_tunnel infrastructuredrivers/net/ethernet/intel/i40e/i40e.h drivers/net/ethernet/intel/i40e/i40e_main.c+51 -2190 replies
6/10ice: remove unused args from ice_get_open_tunnel_port()drivers/net/ethernet/intel/ice/ice_ethtool_fdir.c drivers/net/ethernet/intel/ice/ice_fdir.c drivers/net/ethernet/intel/ice/ice_flex_pipe.c +1 more+6 -120 replies
7/10ice: convert to new udp_tunnel infrastructuredrivers/net/ethernet/intel/ice/ice_flex_pipe.c drivers/net/ethernet/intel/ice/ice_flex_pipe.h drivers/net/ethernet/intel/ice/ice_flex_type.h +2 more+135 -2060 replies
8/10netdevsim: support the static IANA VXLAN port flagdrivers/net/netdevsim/netdevsim.h drivers/net/netdevsim/udp_tunnels.c+5 -00 replies
9/10selftests: net: add a test for static UDP tunnel portstools/testing/selftests/drivers/net/netdevsim/udp_tunnel_nic.sh+58 -00 replies
10/10docs: vxlan: add info about device featuresDocumentation/networking/vxlan.rst+28 -00 replies

Reviews trailers per patch

None of the 10 patches has a Reviewed-by or Acked-by.

PatchAaron Brown
1/10
2/10
3/10
4/10
5/10T-b
6/10T-b
7/10T-b
8/10
9/10
10/10

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH net-next v2 00/10] udp_tunnel: convert Intel drivers with shared tables

This set converts Intel drivers which have the ability to spawn multiple netdevs, but have only one UDP tunnel port table.

Appropriate support is added to the core infra in patch 1, followed by netdevsim support and a selftest.

The table sharing works by core attaching the same table structure to all devices sharing the table. This means the reference count has to accommodate potentially large values.

Once core is ready i40e and ice are converted. These are complex drivers, but we got a tested-by from Aaron, so we should be good :)

Compared to v1 I've made sure the selftest is executable.

Other than that patches 8 and 9 are actually from the Mellanox conversion series were kept out to avoid Mellanox vs Intel conflicts.

Last patch is new, some docs to let users knows ethtool can now display UDP tunnel info.

Jakub Kicinski (10):
udp_tunnel: add the ability to share port tables
netdevsim: add warnings on unexpected UDP tunnel port errors
netdevsim: shared UDP tunnel port table support
selftests: net: add a test for shared UDP tunnel info tables
i40e: convert to new udp_tunnel infrastructure
ice: remove unused args from ice_get_open_tunnel_port()
ice: convert to new udp_tunnel infrastructure
netdevsim: support the static IANA VXLAN port flag
selftests: net: add a test for static UDP tunnel ports
docs: vxlan: add info about device features

 Documentation/networking/vxlan.rst            |  28 ++
 drivers/net/ethernet/intel/i40e/i40e.h        |   6 +-
 drivers/net/ethernet/intel/i40e/i40e_main.c   | 264 ++++--------------
 .../net/ethernet/intel/ice/ice_ethtool_fdir.c |   6 +-
 drivers/net/ethernet/intel/ice/ice_fdir.c     |   2 +-
 .../net/ethernet/intel/ice/ice_flex_pipe.c    | 231 +++++++--------
 .../net/ethernet/intel/ice/ice_flex_pipe.h    |  11 +-
 .../net/ethernet/intel/ice/ice_flex_type.h    |   5 +-
 drivers/net/ethernet/intel/ice/ice_main.c     |  97 ++-----
 drivers/net/ethernet/intel/ice/ice_type.h     |   3 +
 drivers/net/netdevsim/netdevsim.h             |   8 +-
 drivers/net/netdevsim/udp_tunnels.c           |  34 ++-
 include/net/udp_tunnel.h                      |  24 ++
 net/ipv4/udp_tunnel_nic.c                     |  96 ++++++-
 .../drivers/net/netdevsim/udp_tunnel_nic.sh   | 167 +++++++++++
 15 files changed, 531 insertions(+), 451 deletions(-)
 mode change 100644 => 100755 tools/testing/selftests/drivers/net/netdevsim/udp_tunnel_nic.sh
Signature · 1 line
2.26.2