Skip to content

qed, qede: improve chain API and add XDP_REDIRECT support

Alexander Lobakin bpf linux-rdma lkml netdev 2 versions In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest15 patches 3 repliesIn review
  2. v115 patches 1 replySuperseded

Changes in v2 from the cover letter

- add missing includes to #003 to pass the build on Alpha;
- no functional changes.

[1] https://lore.kernel.org/netdev/[email protected]/

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/15qed: reformat "qed_chain.h" a bitinclude/linux/qed/qed_chain.h+66 -601 reply
2/15qed: reformat Makefiledrivers/net/ethernet/qlogic/qed/Makefile+29 -70 replies
3/15qed: move chain methods to a separate filedrivers/net/ethernet/qlogic/qed/Makefile drivers/net/ethernet/qlogic/qed/qed_chain.c drivers/net/ethernet/qlogic/qed/qed_dev.c+303 -2730 replies
4/15qed: prevent possible double-frees of the chainsdrivers/net/ethernet/qlogic/qed/qed_chain.c+3 -10 replies
5/15qed: sanitize PBL chains allocationdrivers/net/ethernet/qlogic/qed/qed_chain.c drivers/net/ethernet/qlogic/qed/qed_sp_commands.c include/linux/qed/qed_chain.h+20 -210 replies
6/15qed: move chain initialization inlines next to allocation functionsdrivers/net/ethernet/qlogic/qed/qed_chain.c include/linux/qed/qed_chain.h+47 -1120 replies
7/15qed: simplify initialization of the chains with an external PBLdrivers/net/ethernet/qlogic/qed/qed_chain.c+19 -180 replies
8/15qed: simplify chain allocation with init params structdrivers/infiniband/hw/qedr/main.c drivers/infiniband/hw/qedr/verbs.c drivers/net/ethernet/qlogic/qed/qed_chain.c +7 more+242 -2330 replies
9/15qed: add support for different page sizes for chainsdrivers/infiniband/hw/qedr/verbs.c drivers/net/ethernet/qlogic/qed/qed_chain.c include/linux/qed/qed_chain.h+33 -180 replies
10/15qed: optimize common chain accessorsinclude/linux/qed/qed_chain.h+33 -270 replies
11/15qed: introduce qed_chain_get_elem_used{,u32}()include/linux/qed/qed_chain.h+14 -40 replies
12/15qede: reformat several structures in "qede.h"drivers/net/ethernet/qlogic/qede/qede.h+89 -770 replies
13/15qede: reformat net_device_ops declarationsdrivers/net/ethernet/qlogic/qede/qede_main.c+61 -610 replies
14/15qede: refactor XDP Tx processingdrivers/net/ethernet/qlogic/qede/qede.h drivers/net/ethernet/qlogic/qede/qede_fp.c+45 -450 replies
15/15qede: add .ndo_xdp_xmit() and XDP_REDIRECT supportdrivers/net/ethernet/qlogic/qede/qede.h drivers/net/ethernet/qlogic/qede/qede_fp.c drivers/net/ethernet/qlogic/qede/qede_main.c+118 -50 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH v2 net-next 00/15] qed, qede: improve chain API and add XDP_REDIRECT support

This series adds missing XDP_REDIRECT case handling in QLogic Everest Ethernet driver with all necessary prerequisites and ops. QEDE Tx relies heavily on chain API, so make sure it is in its best at first.

v2 (from [1]):
- add missing includes to #003 to pass the build on Alpha;
- no functional changes.

[1] https://lore.kernel.org/netdev/[email protected]/

Alexander Lobakin (15):
qed: reformat "qed_chain.h" a bit
qed: reformat Makefile
qed: move chain methods to a separate file
qed: prevent possible double-frees of the chains
qed: sanitize PBL chains allocation
qed: move chain initialization inlines next to allocation functions
qed: simplify initialization of the chains with an external PBL
qed: simplify chain allocation with init params struct
qed: add support for different page sizes for chains
qed: optimize common chain accessors
qed: introduce qed_chain_get_elem_used{,u32}()
qede: reformat several structures in "qede.h"
qede: reformat net_device_ops declarations
qede: refactor XDP Tx processing
qede: add .ndo_xdp_xmit() and XDP_REDIRECT support

 drivers/infiniband/hw/qedr/main.c             |  20 +-
 drivers/infiniband/hw/qedr/verbs.c            |  97 ++---
 drivers/net/ethernet/qlogic/qed/Makefile      |  37 +-
 drivers/net/ethernet/qlogic/qed/qed_chain.c   | 369 ++++++++++++++++++
 drivers/net/ethernet/qlogic/qed/qed_dev.c     | 273 -------------
 drivers/net/ethernet/qlogic/qed/qed_dev_api.h |  32 +-
 drivers/net/ethernet/qlogic/qed/qed_iscsi.c   |  39 +-
 drivers/net/ethernet/qlogic/qed/qed_ll2.c     |  44 ++-
 .../net/ethernet/qlogic/qed/qed_sp_commands.c |   4 +-
 drivers/net/ethernet/qlogic/qed/qed_spq.c     |  90 +++--
 drivers/net/ethernet/qlogic/qede/qede.h       | 175 +++++----
 drivers/net/ethernet/qlogic/qede/qede_fp.c    | 174 ++++++---
 drivers/net/ethernet/qlogic/qede/qede_main.c  | 185 +++++----
 include/linux/qed/qed_chain.h                 | 328 ++++++----------
 include/linux/qed/qed_if.h                    |   9 +-
 15 files changed, 1018 insertions(+), 858 deletions(-)
 create mode 100644 drivers/net/ethernet/qlogic/qed/qed_chain.c

--

Netdev folks, could you please take the entire series through your tree after the necessary acks and reviews? Patches 8-9 also touch qedr driver under rdma tree, but these changes can't be separated as it would break incremental buildability and bisecting.

Signature · 1 line
2.25.1