Skip to content

Some leaked root fixes

Josef Bacik linux-btrfs 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest2 patches 3 repliesIn review
  2. v22 patches 9 repliesSuperseded
  3. v12 patches 10 repliesSuperseded

Changes in v3 from the cover letter

- Reworked the pretty print for roots so it's a little cleaner, also made it so only reloc roots spit out the offset, since that's the only time we care.
- Added Nikolay's reviewed-by for the first patch.

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2btrfs: free fs roots on failed mountfs/btrfs/disk-io.c+2 -01 reply
2/2btrfs: pretty print leaked root namefs/btrfs/disk-io.c fs/btrfs/print-tree.c fs/btrfs/print-tree.h+46 -22 replies

Reviews trailers per patch

1 of 2 patches has a Reviewed-by or Acked-by.

PatchNikolay Borisov
1/2R-b
2/2

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH 0/2][v3] Some leaked root fixes

v2->v3:
- Reworked the pretty print for roots so it's a little cleaner, also made it so only reloc roots spit out the offset, since that's the only time we care.
- Added Nikolay's reviewed-by for the first patch.

--- Original email ---
Hello,

These are two fixes for a leaked root problem I noticed a while ago. One is the actual leaked root fix, the other is to add a pretty print for the leaked root message, as figuring out that some giant %llu number was the data reloc root is not a feat meant for humans. Thanks,

Josef

Josef Bacik (2):
btrfs: free fs roots on failed mount
btrfs: pretty print leaked root name

 fs/btrfs/disk-io.c    |  8 ++++++--
 fs/btrfs/print-tree.c | 39 +++++++++++++++++++++++++++++++++++++++
 fs/btrfs/print-tree.h |  3 +++
 3 files changed, 48 insertions(+), 2 deletions(-)
Signature · 1 line
2.24.1