Skip to content

Fix BPF socket lookup with reuseport groups with connections

Jakub Sitnicki bpf netdev 1 version Applied

Status from this message: Applied to bpf-next. Thanks

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 2 repliesApplied

Patches in v1 Applied

#Subject and filesSizeRepliesApplied
1/2udp: Don't discard reuseport selection when group has connectionsnet/ipv4/udp.c net/ipv6/udp.c+2 -80 replies
2/2selftests/bpf: Test BPF socket lookup and reuseport with connectionstools/testing/selftests/bpf/prog_tests/sk_lookup.c+53 -10 replies

Reviews trailers per patch

None of the 2 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchKuniyuki Iwashima
SeriesA-b
1/2
2/2

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH bpf-next 0/2] Fix BPF socket lookup with reuseport groups with connections

This mini series contains a fix for a bug noticed when analyzing a reported merge conflict between bpf-next and net tree [0].

Apart from fixing a corner-case that affects use of BPF sk_lookup in tandem with UDP reuseport groups with connected sockets, it should make the conflict resolution with net tree easier.

These changes don't replicate the improved UDP socket lookup behavior from net tree, where commit efc6b6f6c311 ("udp: Improve load balancing for SO_REUSEPORT.") is present.

Happy to do it as a follow up. For the moment I didn't want to make things more confusing when it comes to what got fixed where and why.

Thanks,
-jkbs

Cc Kuniyuki Iwashima <[email protected]>
Cc Willem de Bruijn <[email protected]>

[0] https://lore.kernel.org/linux-next/[email protected]/

Jakub Sitnicki (2):
udp: Don't discard reuseport selection when group has connections selftests/bpf: Test BPF socket lookup and reuseport with connections

 net/ipv4/udp.c                                |  5 +-
 net/ipv6/udp.c                                |  5 +-
 .../selftests/bpf/prog_tests/sk_lookup.c      | 54 ++++++++++++++++++-
 3 files changed, 55 insertions(+), 9 deletions(-)
Signature · 1 line
2.25.4