Skip to content

Use standard C string APIs in FDT helper

Abner Chang opensbi 2 versions – New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest3 patches 0 repliesNew
  2. v13 patches 0 repliesSuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3Use standard C string APIs in FDT helperinclude/sbi/sbi_string.h lib/sbi/sbi_string.c+20 -01 reply
2/3Use standard C string APIs in FDT helperlib/utils/libfdt/libfdt_env.h+1 -01 reply
3/3Use standard C string APIs in FDT helperlib/utils/fdt/fdt_helper.c+1 -11 reply

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by.

PatchAtish PatraAnup Patel
1/3R-b R-b
2/3R-b R-b
3/3R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/3] Use standard C string APIs in FDT helper

Use strncmp instead of using sbi_strcmp directly in fdthelp.c.
- This keeps the consistency with lidfdt implementation and utilizing libfdt_evn.h for the different build environment even fdlhelp.c is not part of standard fdt library.
- In libfdt_evn.h, a macro overrides strncmp with sbi_strncmp.
- For edk2 firmware solution, similar macro is used to repalce strncmp with EDK2 string API.
- Use strncmp instead of strcmp, which is much safer.
- Still keep sbi_strcmp() for the completeness of supporting string functions.

Abner Chang (3):
Use standard C string APIs in FDT helper
Use standard C string APIs in FDT helper
Use standard C string APIs in FDT helper

 include/sbi/sbi_string.h      |  7 +++++++
 lib/sbi/sbi_string.c          | 13 +++++++++++++
 lib/utils/fdt/fdt_helper.c    |  2 +-
 lib/utils/libfdt/libfdt_env.h |  1 +
 4 files changed, 22 insertions(+), 1 deletion(-)
Signature · 1 line
2.25.0