Skip to content

*memory: Cleanup, improve and compile test memory drivers

Krzysztof Kozlowski linux-arm-kernel linux-mediatek linux-omap linux-samsung-soc linux-tegra lkml 2 versions – Applied

Status from this message: Applied to drivers/memory tree.

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest29 patches 25 repliesApplied
  2. v1 RFC23 patches 20 repliesSuperseded

Changes in v2 from the cover letter

1. Few new patches,
2. Please see individual logs (per patch).

Patches in v2 Applied

#Subject and filesSizeRepliesApplied
1/29memory: omap-gpmc: Remove unneeded asm/mach-types.h inclusiondrivers/memory/omap-gpmc.c+0 -21 reply
2/29memory: omap-gpmc: Remove unused file-scope phys_base and mem_sizedrivers/memory/omap-gpmc.c+0 -41 reply
3/29memory: omap-gpmc: Include <linux/sizes.h> for SZ_16Mdrivers/memory/omap-gpmc.c+1 -01 reply
4/29memory: ti-aemif: Rename SS to SSTROBE to avoid name conflictsdrivers/memory/ti-aemif.c+8 -81 reply
5/29memory: jz4780-nemc: Do not enable by default on every compile testdrivers/memory/Kconfig+1 -12 replies
6/29memory: Enable compile testing for most of the driversdrivers/memory/Kconfig+22 -171 reply
7/29memory: of: Remove unused headersdrivers/memory/of_memory.c+0 -20 replies
8/29memory: of: Remove __func__ in device related messagesdrivers/memory/of_memory.c+8 -80 replies
9/29memory: of: Correct indentationdrivers/memory/of_memory.c+6 -40 replies
10/29memory: of: Remove unneeded extern from function declarationsdrivers/memory/of_memory.h+11 -100 replies
11/29memory: emif-asm-offsets: Add GPLv2 SPDX license headerdrivers/memory/emif-asm-offsets.c+1 -91 reply
12/29memory: emif: Put constant in comparison on the right sidedrivers/memory/emif.c+1 -11 reply
13/29memory: emif: Fix whitespace coding style violationsdrivers/memory/emif.c+7 -91 reply
14/29memory: emif: Silence platform_get_irq() error in driverdrivers/memory/emif.c+1 -41 reply
15/29memory: ti-emif-pm: Fix cast to iomem pointerdrivers/memory/ti-emif-pm.c+1 -11 reply
16/29memory: renesas-rpc-if: Simplify with PTR_ERR_OR_ZEROdrivers/memory/renesas-rpc-if.c+1 -31 reply
17/29memory: brcmstb_dpfe: Constify the contents of stringdrivers/memory/brcmstb_dpfe.c+1 -11 reply
18/29memory: brcmstb_dpfe: Remove unneeded bracesdrivers/memory/brcmstb_dpfe.c+1 -21 reply
19/29memory: mtk-smi: Add argument to function pointer definitiondrivers/memory/mtk-smi.c+1 -11 reply
20/29memory: omap-gpmc: Return meaningful error codes in gpmc_cs_set_timings()drivers/memory/omap-gpmc.c+3 -31 reply
21/29memory: omap-gpmc: Remove GPMC_SET_ONE_CD_MAX macro for safetydrivers/memory/omap-gpmc.c+93 -441 reply
22/29memory: omap-gpmc: Fix whitespace issuedrivers/memory/omap-gpmc.c+4 -31 reply
23/29memory: pl172: Add GPLv2 SPDX license headerdrivers/memory/pl172.c+1 -41 reply
24/29memory: tegra: tegra210-emc: Fix indentationdrivers/memory/tegra/tegra210-emc-cc-r21021.c+1 -11 reply
25/29MAINTAINERS: Add Krzysztof Kozlowski as maintainer of memory controllersMAINTAINERS+7 -00 replies
26/29memory: fsl_ifc: Fix whitespace issuesdrivers/memory/fsl_ifc.c+15 -151 reply
27/29memory: da8xx-ddrctl: Remove unused 'node' variabledrivers/memory/da8xx-ddrctl.c+0 -21 reply
28/29memory: Describe the MEMORY Kconfig entrydrivers/memory/Kconfig+6 -00 replies
29/29memory: samsung: exynos-srom: Describe the Kconfig entrydrivers/memory/samsung/Kconfig+7 -00 replies

Reviews trailers per patch

3 of 29 patches have a Reviewed-by or Acked-by.

PatchFlorian FainelliMarkus Mayer
1/29
2/29
3/29
4/29
5/29
6/29
7/29
8/29
9/29
10/29
11/29
12/29
13/29
14/29
15/29
16/29
17/29A-b A-b
18/29A-b A-b
19/29
20/29
21/29
22/29
23/29
24/29
25/29A-b
26/29
27/29
28/29
29/29

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 00/29] *memory: Cleanup, improve and compile test memory drivers

Dear All,

Changes since v1:
1. Few new patches,
2. Please see individual logs (per patch).

The drivers/memory directory contains generic code (of_memory.c) and a bunch of drivers. Changes to generic code were coming usually through different trees with the driver code.

Over last days, memory drivers grew in numbers but not necessarily in quality. They lacked compile testing and code cleanup. Also lacked maintainer.

I would be happy to take care about this part.

If there are no objections, I will collect the patches and push them through arm-soc maintainers.

Driver-specific changes in the patchset were only compile-tested. Tests are welcome. The generic code was tested on ARMv7 Exynos based boards with a exynos5422-dmc memory controller driver.

Best regards,
Krzysztof

Krzysztof Kozlowski (29):
memory: omap-gpmc: Remove unneeded asm/mach-types.h inclusion
memory: omap-gpmc: Remove unused file-scope phys_base and mem_size
memory: omap-gpmc: Include <linux/sizes.h> for SZ_16M
memory: ti-aemif: Rename SS to SSTROBE to avoid name conflicts
memory: jz4780-nemc: Do not enable by default on every compile test
memory: Enable compile testing for most of the drivers
memory: of: Remove unused headers
memory: of: Remove __func__ in device related messages
memory: of: Correct indentation
memory: of: Remove unneeded extern from function declarations
memory: emif-asm-offsets: Add GPLv2 SPDX license header
memory: emif: Put constant in comparison on the right side
memory: emif: Fix whitespace coding style violations
memory: emif: Silence platform_get_irq() error in driver
memory: ti-emif-pm: Fix cast to iomem pointer
memory: renesas-rpc-if: Simplify with PTR_ERR_OR_ZERO
memory: brcmstb_dpfe: Constify the contents of string
memory: brcmstb_dpfe: Remove unneeded braces
memory: mtk-smi: Add argument to function pointer definition
memory: omap-gpmc: Return meaningful error codes in
gpmc_cs_set_timings()
memory: omap-gpmc: Remove GPMC_SET_ONE_CD_MAX macro for safety
memory: omap-gpmc: Fix whitespace issue
memory: pl172: Add GPLv2 SPDX license header
memory: tegra: tegra210-emc: Fix indentation
MAINTAINERS: Add Krzysztof Kozlowski as maintainer of memory
controllers
memory: fsl_ifc: Fix whitespace issues
memory: da8xx-ddrctl: Remove unused 'node' variable
memory: Describe the MEMORY Kconfig entry
memory: samsung: exynos-srom: Describe the Kconfig entry

 MAINTAINERS                                   |   7 +
 drivers/memory/Kconfig                        |  47 ++++--
 drivers/memory/brcmstb_dpfe.c                 |   5 +-
 drivers/memory/da8xx-ddrctl.c                 |   2 -
 drivers/memory/emif-asm-offsets.c             |  10 +-
 drivers/memory/emif.c                         |  23 +--
 drivers/memory/fsl_ifc.c                      |  30 ++--
 drivers/memory/mtk-smi.c                      |   2 +-
 drivers/memory/of_memory.c                    |  28 ++--
 drivers/memory/of_memory.h                    |  21 +--
 drivers/memory/omap-gpmc.c                    | 155 +++++++++++-------
 drivers/memory/pl172.c                        |   5 +-
 drivers/memory/renesas-rpc-if.c               |   4 +-
 drivers/memory/samsung/Kconfig                |   7 +
 drivers/memory/tegra/tegra210-emc-cc-r21021.c |   2 +-
 drivers/memory/ti-aemif.c                     |  16 +-
 drivers/memory/ti-emif-pm.c                   |   2 +-
 17 files changed, 208 insertions(+), 158 deletions(-)
Signature · 1 line
2.17.1