Skip to content

introduce PLDM firmware update library

Jacob Keller netdev 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest5 patches 1 replyIn review

Changes since v2 RFC from the cover letter

* Removed overwrite mode patches, as this can become a follow up series with a separate discussion
* Fixed a minor bug in the pldm_timestamp structure not being packed.
* Dropped Cc for other driver maintainers, as this series no longer includes changes to the core flash update command.
* Re-ordered patches slightly.

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5Add pldmfw library for PLDM firmware updateDocumentation/driver-api/index.rst Documentation/driver-api/pldmfw/driver-ops.rst Documentation/driver-api/pldmfw/file-format.rst +8 more+1630 -00 replies
2/5ice: Add support for unified NVM update flow capabilitydrivers/net/ethernet/intel/ice/ice_adminq_cmd.h drivers/net/ethernet/intel/ice/ice_common.c drivers/net/ethernet/intel/ice/ice_type.h+11 -00 replies
3/5ice: Add AdminQ commands for FW updatedrivers/net/ethernet/intel/ice/ice_adminq_cmd.h drivers/net/ethernet/intel/ice/ice_common.h drivers/net/ethernet/intel/ice/ice_nvm.c +2 more+281 -20 replies
4/5ice: add flags indicating pending update of firmware moduledrivers/net/ethernet/intel/ice/ice_adminq_cmd.h drivers/net/ethernet/intel/ice/ice_common.c drivers/net/ethernet/intel/ice/ice_type.h+24 -00 replies
5/5ice: implement device flash update via devlinkdrivers/net/ethernet/intel/Kconfig drivers/net/ethernet/intel/ice/Makefile drivers/net/ethernet/intel/ice/ice.h +6 more+1007 -10 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [net-next v1 0/5] introduce PLDM firmware update library

This series goal is to enable support for updating the ice hardware flash using the devlink flash command.

The ice firmware update files are distributed using the file format described by the "PLDM for Firmware Update" standard:

https://www.dmtf.org/documents/pmci/pldm-firmware-update-specification-100

Because this file format is standard, this series introduces a new library that handles the generic logic for parsing the PLDM file header. The library uses a design that is very similar to the Mellanox mlxfw module. That is, a simple ops table is setup and device drivers instantiate an instance of the pldmfw library with the device specific operations.

Doing so allows for each device to implement the low level behavior for how to interact with its firmware.

This series includes the library and an implementation for the ice hardware. I've removed all of the parameters, and the proposed changes to support overwrite mode. I'll be working on the overwrite mask suggestion from Jakub as a follow-up series.

Because the PLDM file format is a standard and not something that is specific to the Intel hardware, I opted to place this update library in lib/pldmfw. I should note that while I tried to make the library generic, it does not attempt to mimic the complete "Update Agent" as defined in the standard. This is mostly due to the fact that the actual interfaces exposed to software for the ice hardware would not allow this.

This series depends on some work just recently and is based on top of the patch series sent by Tony published at:

https://lore.kernel.org/netdev/[email protected]/T/#t

Changes since v2 RFC
* Removed overwrite mode patches, as this can become a follow up series with a separate discussion
* Fixed a minor bug in the pldm_timestamp structure not being packed.
* Dropped Cc for other driver maintainers, as this series no longer includes changes to the core flash update command.
* Re-ordered patches slightly.
Changes since v1 RFC
* Removed the "allow_downgrade_on_flash_update" parameter. Instead, the driver will always attempt to flash the device, even when firmware indicates that it would be a downgrade. A dev_warn is used to indicate when this occurs.
* Removed the "ignore_pending_flash_update". Instead, the driver will always check for and cancel any previous pending update. A devlink flash status message will be sent when this cancellation occurs.
* Removed the "reset_after_flash_update" parameter. This will instead be implemented as part of a devlink reset interface, work left for a future change.
* Replaced the "flash_update_preservation_level" parameter with a new "overwrite" mode attribute on the flash update command. For ice, this mode will select the preservation level. For all other drivers, I modified them to check that the mode is "OVERWRITE_NOTHING", and have Cc'd the maintainers to get their input.

Cc Jiri Pirko <[email protected]>
Cc Jakub Kicinski <[email protected]>

Cudzilo, Szymon T (1):
ice: Add AdminQ commands for FW update

Jacek Naczyk (1):
ice: Add support for unified NVM update flow capability

Jacob Keller (3):
Add pldmfw library for PLDM firmware update
ice: add flags indicating pending update of firmware module
ice: implement device flash update via devlink

 Documentation/driver-api/index.rst            |   1 +
 .../driver-api/pldmfw/driver-ops.rst          |  56 ++
 .../driver-api/pldmfw/file-format.rst         | 203 ++++
 Documentation/driver-api/pldmfw/index.rst     |  72 ++
 MAINTAINERS                                   |   7 +
 drivers/net/ethernet/intel/Kconfig            |   1 +
 drivers/net/ethernet/intel/ice/Makefile       |   1 +
 drivers/net/ethernet/intel/ice/ice.h          |   9 +
 .../net/ethernet/intel/ice/ice_adminq_cmd.h   |  83 ++
 drivers/net/ethernet/intel/ice/ice_common.c   |  21 +-
 drivers/net/ethernet/intel/ice/ice_common.h   |   4 +-
 drivers/net/ethernet/intel/ice/ice_devlink.c  |  54 ++
 .../net/ethernet/intel/ice/ice_fw_update.c    | 773 +++++++++++++++
 .../net/ethernet/intel/ice/ice_fw_update.h    |  12 +
 drivers/net/ethernet/intel/ice/ice_main.c     | 154 +++
 drivers/net/ethernet/intel/ice/ice_nvm.c      | 186 ++++
 drivers/net/ethernet/intel/ice/ice_nvm.h      |  16 +
 drivers/net/ethernet/intel/ice/ice_type.h     |  12 +
 include/linux/pldmfw.h                        | 165 ++++
 lib/Kconfig                                   |   4 +
 lib/Makefile                                  |   3 +
 lib/pldmfw/Makefile                           |   2 +
 lib/pldmfw/pldmfw.c                           | 879 ++++++++++++++++++
 lib/pldmfw/pldmfw_private.h                   | 238 +++++
 24 files changed, 2953 insertions(+), 3 deletions(-)
 create mode 100644 Documentation/driver-api/pldmfw/driver-ops.rst
 create mode 100644 Documentation/driver-api/pldmfw/file-format.rst
 create mode 100644 Documentation/driver-api/pldmfw/index.rst
 create mode 100644 drivers/net/ethernet/intel/ice/ice_fw_update.c
 create mode 100644 drivers/net/ethernet/intel/ice/ice_fw_update.h
 create mode 100644 include/linux/pldmfw.h
 create mode 100644 lib/pldmfw/Makefile
 create mode 100644 lib/pldmfw/pldmfw.c
 create mode 100644 lib/pldmfw/pldmfw_private.h

base-commit: 0d127fc31b70b1aa28f8bc3014c7e6d11a4dd1bc

Signature · 1 line
2.28.0.rc1.139.gd6b33fda9dd1