Skip to content

IDE: SRST and other fixes

John Snow qemu-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest7 patches 2 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/7ide: rename cmd_write to ctrl_writehw/ide/core.c hw/ide/ioport.c hw/ide/macio.c +4 more+24 -231 reply
2/7ide: don't tamper with the device registerhw/ide/core.c+2 -20 replies
3/7ide: model HOB correctlyhw/ide/core.c include/hw/ide/internal.h+8 -80 replies
4/7ide: reorder set/get sector functionshw/ide/core.c+15 -111 reply
5/7ide: remove magic constants from the device registerhw/ide/core.c include/hw/ide/internal.h+25 -120 replies
6/7ide: clear interrupt on command writehw/ide/core.c+1 -00 replies
7/7ide: cancel pending callbacks on SRSThw/ide/core.c+40 -180 replies

Reviews trailers per patch

2 of 7 patches have a Reviewed-by or Acked-by.

PatchPhilippe Mathieu-Daudé
1/7R-b
2/7
3/7
4/7R-b
5/7
6/7
7/7

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/7] IDE: SRST and other fixes

The goal of this series is to fix the Software Reset (SRST) routine. That said, the first six patches are almost entirely unrelated...

Patches 2, 3, and 6 fix extremely minor deviations from the spec I noticed while researching SRST. (One of them gets rid of a FIXME from 2003.)

Patches 1, 4, and 5 are very small code cleanups that don't cause any functional changes that should make patches 2, 3, and 6 more obvious to review.

Patch 7 fixes SRST; it depends on the other patches only for a changed constant name. With a small rebase, it could be suitable for 5.1.

John Snow (7):
ide: rename cmd_write to ctrl_write
ide: don't tamper with the device register
ide: model HOB correctly
ide: reorder set/get sector functions
ide: remove magic constants from the device register
ide: clear interrupt on command write
ide: cancel pending callbacks on SRST

 include/hw/ide/internal.h |  21 +++++--
 hw/ide/core.c             | 124 +++++++++++++++++++++++---------------
 hw/ide/ioport.c           |   2 +-
 hw/ide/macio.c            |   2 +-
 hw/ide/mmio.c             |   8 +--
 hw/ide/pci.c              |  12 ++--
 hw/ide/trace-events       |   2 +-
 7 files changed, 106 insertions(+), 65 deletions(-)
Signature · 1 line
2.26.2