Improve FreeBSD and macOS jobs in the Cirrus-CI
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v2 Latest4 patches 3 repliesIn review
- v13 patches 18 repliesSuperseded
Changes in v2 from the cover letter
- Split the -Werror enablement patch into two, one for FreeBSD and one for macOS
- Use -Wno-error=deprecated-declarations instead of --disable-sasl on macOS to work-around the deprecation messages from Apple.
Patches in v2 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/4 | configure: Fix atomic64 test for --enable-werror on macOSconfigure | +5 | 0 replies | |
| 2/4 | cirrus.yml: Compile FreeBSD with -Werror.cirrus.yml | +1 | 1 reply | |
| 3/4 | cirrus.yml: Compile macOS with -Werror.cirrus.yml | +5 | 1 reply | |
| 4/4 | cirrus.yml: Update the macOS jobs to Catalina.cirrus.yml | +2 | 1 reply |
Reviews trailers per patch
All 4 patches have a Reviewed-by or Acked-by.
| Patch | Christian Schoenebeck | Alex Bennée | Ed Maste | Daniel P. Berrangé |
|---|---|---|---|---|
| 1/4 | R-b | R-b T-b | ||
| 2/4 | R-b | R-b | ||
| 3/4 | R-b | |||
| 4/4 | R-b | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.
Cover letter [PATCH v2 0/4] Improve FreeBSD and macOS jobs in the Cirrus-CI
Our configure script does not enable -Werror on macOS and FreeBSD by default yet. That's bad in the CI, since we might miss compiler warnings and thus bugs this way. So after fixing a problem in the configure script in the first patch, we now turn on -Werror here in the second and third patch. The fourth patch is just a cosmetical one, since Cirrus-CI seems to upgrade all jobs automatically to Cataline these days.
v2:
- Split the -Werror enablement patch into two, one for FreeBSD and one for macOS
- Use -Wno-error=deprecated-declarations instead of --disable-sasl on macOS to work-around the deprecation messages from Apple.
Thomas Huth (4):
configure: Fix atomic64 test for --enable-werror on macOS cirrus.yml: Compile FreeBSD with -Werror cirrus.yml: Compile macOS with -Werror cirrus.yml: Update the macOS jobs to Catalina
.cirrus.yml | 13 ++++++++----- configure | 10 +++++----- 2 files changed, 13 insertions(+), 10 deletions(-)
Signature · 1 line
2.18.1