Skip to content

l2tp: avoid multiple assignment, remove BUG_ON

Tom Parkin netdev 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest9 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/9l2tp: avoid multiple assignmentsnet/l2tp/l2tp_core.c net/l2tp/l2tp_ip.c net/l2tp/l2tp_ip6.c+15 -90 replies
2/9l2tp: WARN_ON rather than BUG_ON in l2tp_dfs_seq_startnet/l2tp/l2tp_debugfs.c+4 -10 replies
3/9l2tp: remove BUG_ON in l2tp_session_queue_purgenet/l2tp/l2tp_core.c+0 -10 replies
4/9l2tp: remove BUG_ON in l2tp_tunnel_closeallnet/l2tp/l2tp_core.c+0 -20 replies
5/9l2tp: don't BUG_ON session magic checks in l2tp_pppnet/l2tp/l2tp_ppp.c+7 -30 replies
6/9l2tp: don't BUG_ON seqfile checks in l2tp_pppnet/l2tp/l2tp_ppp.c+5 -10 replies
7/9l2tp: WARN_ON rather than BUG_ON in l2tp_session_queue_purgenet/l2tp/l2tp_core.c+4 -30 replies
8/9l2tp: remove BUG_ON refcount value in l2tp_session_freenet/l2tp/l2tp_core.c+0 -20 replies
9/9l2tp: WARN_ON rather than BUG_ON in l2tp_session_freenet/l2tp/l2tp_core.c+3 -10 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH net-next 0/9] l2tp: avoid multiple assignment, remove BUG_ON

l2tp hasn't been kept up to date with the static analysis checks offered by checkpatch.pl.

This patchset builds on the series: "l2tp: cleanup checkpatch.pl warnings" and "l2tp: further checkpatch.pl cleanups" to resolve some of the remaining checkpatch warnings in l2tp.

Tom Parkin (9):
l2tp: avoid multiple assignments
l2tp: WARN_ON rather than BUG_ON in l2tp_dfs_seq_start
l2tp: remove BUG_ON in l2tp_session_queue_purge
l2tp: remove BUG_ON in l2tp_tunnel_closeall
l2tp: don't BUG_ON session magic checks in l2tp_ppp
l2tp: don't BUG_ON seqfile checks in l2tp_ppp
l2tp: WARN_ON rather than BUG_ON in l2tp_session_queue_purge
l2tp: remove BUG_ON refcount value in l2tp_session_free
l2tp: WARN_ON rather than BUG_ON in l2tp_session_free

 net/l2tp/l2tp_core.c    | 22 ++++++++++------------
 net/l2tp/l2tp_debugfs.c |  5 ++++-
 net/l2tp/l2tp_ip.c      | 12 ++++++++----
 net/l2tp/l2tp_ip6.c     |  6 ++++--
 net/l2tp/l2tp_ppp.c     | 16 ++++++++++++----
 5 files changed, 38 insertions(+), 23 deletions(-)
Signature · 1 line
2.17.1