fuse: Implement FUSE_HANDLE_KILLPRIV_V2 and enable SB_NOSEC
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v3 Latest6 patches 11 repliesIn review
- v26 patches 5 repliesSuperseded
- v1 RFC5 patches 7 repliesSuperseded
Changes in v3 from the cover letter
- Based on Miklos's feedback, dropped a patch where we send ATTR_MODE as that's racy. To help the case of writeback_cache with killpriv_v2, I fallback to a synchronous WRITE if suid/sgid is set on file.
Patches in v3 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/6 | fuse: Introduce the notion of FUSE_HANDLE_KILLPRIV_V2fs/ fs/ include/ | +17 | 0 replies | |
| 2/6 | fuse: Set FUSE_WRITE_KILL_PRIV in cached write pathfs/ | +2 | 0 replies | |
| 3/6 | fuse: setattr should set FATTR_KILL_PRIV upon size changefs/ include/ | +3 | 7 replies | |
| 4/6 | fuse: Don't send ATTR_MODE to kill suid/sgid for handle_killpriv_v2fs/ fs/ | +9 | 0 replies | |
| 5/6 | fuse: Add a flag FUSE_OPEN_KILL_PRIV for open() requestfs/ include/ | +14 | 4 replies | |
| 6/6 | fuse: Support SB_NOSEC flag to improve direct write performancefs/ | +13 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v3 yet.
Cover letter [PATCH v3 0/6] fuse: Implement FUSE_HANDLE_KILLPRIV_V2 and enable SB_NOSEC
Hi All,
Please find attached V3 of the patches to enable SB_NOSEC for fuse. I posted V1 and V2 here.
v2:
https://lore.kernel.org/linux-fsdevel/[email protected]/
v1:
https://lore.kernel.org/linux-fsdevel/[email protected]/
Changes since v2:
- Based on Miklos's feedback, dropped a patch where we send ATTR_MODE as that's racy. To help the case of writeback_cache with killpriv_v2, I fallback to a synchronous WRITE if suid/sgid is set on file.
I have generated these patches on top of.
https://git.kernel.org/pub/scm/linux/kernel/git/mszeredi/fuse.git/log/?h=for-nex
+t
I have taken care of feedback from last round. For the case of random write peformance has jumped from 50MB/s to 250MB/s. So I am really looking forward to these changes so that fuse/virtiofs performance can be improved for direct random writes.
Thanks
Vivek
Vivek Goyal (6):
fuse: Introduce the notion of FUSE_HANDLE_KILLPRIV_V2
fuse: Set FUSE_WRITE_KILL_PRIV in cached write path
fuse: setattr should set FATTR_KILL_PRIV upon size change
fuse: Don't send ATTR_MODE to kill suid/sgid for handle_killpriv_v2
fuse: Add a flag FUSE_OPEN_KILL_PRIV for open() request
fuse: Support SB_NOSEC flag to improve direct write performance
fs/fuse/dir.c | 4 +++- fs/fuse/file.c | 16 +++++++++++++++- fs/fuse/fuse_i.h | 6 ++++++ fs/fuse/inode.c | 17 ++++++++++++++++- include/uapi/linux/fuse.h | 18 +++++++++++++++++- 5 files changed, 57 insertions(+), 4 deletions(-)
Signature · 1 line
2.25.4