Fix convert to qcow2 compressed to NBD
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v2 Latest4 patches 11 repliesIn review
- v12 patches 10 repliesSuperseded
Changes in v2 from the cover letter
- Include complete code for creating OVA file [Eric]
- Use qcow2 for source file to avoid issues with random CI filesystem [Max]
- Fix many typos [Eric, Max]
- Make qemu_nbd_popen a context manager
- Add more qemu_img_* helpers
- Verify OVA file contents
Patches in v2 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/4 | block: nbd: Fix convert qcow2 compressed to nbdblock/ | +30 | 3 replies | |
| 2/4 | iotests: Make qemu_nbd_popen() a contextmanagertests/ tests/ tests/ | +56 | 5 replies | |
| 3/4 | iotests: Add more qemu_img helperstests/ | +6 | 2 replies | |
| 4/4 | iotests: Test convert to qcow2 compressed to NBDtests/ tests/ tests/ | +159 | 1 reply |
Reviews trailers per patch
All 4 patches have a Reviewed-by or Acked-by.
| Patch | Vladimir Sementsov-Ogievskiy | Eric Blake |
|---|---|---|
| 1/4 | R-b | R-b |
| 2/4 | R-b | |
| 3/4 | R-b | |
| 4/4 | T-b R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v2 0/4] Fix convert to qcow2 compressed to NBD
Fix qemu-img convert -O qcow2 -c to NBD URL and add missing test for this usage.
This already works now, but unfortunately qemu-img fails when trying to truncate the target image to the same size at the end of the operation.
Changes since v1:
- Include complete code for creating OVA file [Eric]
- Use qcow2 for source file to avoid issues with random CI filesystem [Max]
- Fix many typos [Eric, Max]
- Make qemu_nbd_popen a context manager
- Add more qemu_img_* helpers
- Verify OVA file contents
v1 was here:
https://lists.nongnu.org/archive/html/qemu-block/2020-07/msg01543.html
Nir Soffer (4):
block: nbd: Fix convert qcow2 compressed to nbd
iotests: Make qemu_nbd_popen() a contextmanager
iotests: Add more qemu_img helpers
iotests: Test convert to qcow2 compressed to NBD
block/nbd.c | 30 ++++++++ tests/qemu-iotests/264 | 76 ++++++++------------ tests/qemu-iotests/264.out | 2 + tests/qemu-iotests/302 | 127 ++++++++++++++++++++++++++++++++++ tests/qemu-iotests/302.out | 31 +++++++++ tests/qemu-iotests/group | 1 + tests/qemu-iotests/iotests.py | 34 ++++++++- 7 files changed, 251 insertions(+), 50 deletions(-) create mode 100755 tests/qemu-iotests/302 create mode 100644 tests/qemu-iotests/302.out
Signature · 1 line
2.25.4