Skip to content

Fixes for setting event freq/periods

Ian Rogers bpf lkml netdev 3 versions – Applied

Status from this message: Thanks, applied.

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest4 patches 7 repliesApplied
  2. v25 patches 26 repliesApplied
  3. v11 patch 1 replySuperseded

Patches in v3 Applied

#Subject and filesSizeRepliesApplied
1/4perf record: Set PERF_RECORD_PERIOD if attr->freq is set.tools/perf/util/evsel.c+6 -10 replies
2/4perf record: Prevent override of attr->sample_period for libpfm4 eventstools/perf/util/evsel.c+1 -20 replies
3/4perf record: Don't clear event's period if set by a termtools/perf/util/record.c+26 -85 replies
4/4perf test: Leader sampling shouldn't clear sample periodtools/perf/tests/attr/README tools/perf/tests/attr/test-record-group2+30 -01 reply

Reviews trailers per patch

2 of 4 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchIan RogersJiri OlsaAdrian Hunter
SeriesA-b
1/4
2/4R-b
3/4A-b
4/4

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v3 thread

Cover letter [PATCH v3 0/4] Fixes for setting event freq/periods

Some fixes that address issues for regular and pfm4 events with 2 additional perf_event_attr tests. Various authors, David Sharp isn't currently at Google.

v3. moved a loop into a helper following Adrian Hunter's suggestion. v2. corrects the commit message following Athira Rajeev's suggestion.

David Sharp (1):
perf record: Set PERF_RECORD_PERIOD if attr->freq is set.

Ian Rogers (2):
perf record: Don't clear event's period if set by a term perf test: Leader sampling shouldn't clear sample period

Stephane Eranian (1):
perf record: Prevent override of attr->sample_period for libpfm4
events

 tools/perf/tests/attr/README             |  1 +
 tools/perf/tests/attr/test-record-group2 | 29 ++++++++++++++++++++
 tools/perf/util/evsel.c                  | 10 ++++---
 tools/perf/util/record.c                 | 34 ++++++++++++++++++------
 4 files changed, 63 insertions(+), 11 deletions(-)
 create mode 100644 tools/perf/tests/attr/test-record-group2
Signature · 1 line
2.28.0.618.gf4bc123cb7-goog