Skip to content

target-hppa fixes v4

Helge Deller qemu-devel 4 versions – New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest12 patches 0 repliesNew
  2. v38 patches 12 repliesSuperseded
  3. v24 patches 8 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v14 patches5 repliesSuperseded

Changes to v3 from the cover letter

* Fix memory fallouts due to commit 5d971f9e6725
* Fix graphic rendering bugs and screen refreshes with dtwm on HP-UX

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/12hw/hppa: Sync hppa_hardware.h file with SeaBIOS sourceshw/hppa/hppa_hardware.h hw/hppa/lasi.c+6 -20 replies
2/12seabios-hppa: Update to SeaBIOS hppa version 1pc-bios/hppa-firmware.img roms/seabios-hppa+1 -10 replies
3/12hw/hppa: Implement proper SeaBIOS version checkhw/hppa/machine.c+22 -00 replies
4/12hw/display/artist.c: fix out of bounds checkhw/display/artist.c+11 -130 replies
5/12hw/hppa/lasi: Don't abort on invalid IMR valuehw/hppa/lasi.c+5 -20 replies
6/12hw/display/artist: Check offset in draw_line to avoid buffer over-runhw/display/artist.c+7 -20 replies
7/12hw/display/artist: Refactor artist_rop8() to avoid buffer over-runhw/display/artist.c+25 -150 replies
8/12Revert "hw/display/artist: Avoid drawing line when nothing to display"hw/display/artist.c+0 -30 replies
9/12hw/display/artist: Prevent out of VRAM buffer accesseshw/display/artist.c+64 -390 replies
10/12hw/display/artist: Unbreak size mismatch memory accesseshw/display/artist.c+4 -80 replies
11/12hw/display/artist: Fix invalidation of lines in artist_draw_line()hw/display/artist.c+4 -10 replies
12/12hw/display/artist: Fix invalidation of lines near screen borderhw/display/artist.c+6 -10 replies

Reviews trailers per patch

3 of 12 patches have a Reviewed-by or Acked-by.

PatchRichard HendersonAlexander Bulekov
1/12A-b
2/12
3/12
4/12R-b
5/12
6/12
7/12
8/12
9/12A-b
10/12
11/12
12/12

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v4 thread

Cover letter [PATCH v4 00/12] target-hppa fixes v4

A few late fixes for target-hppa:

* Fix the SeaBIOS-hppa firmware build with gcc-10 on Debian

* Fix the SeaBIOS-hppa firmware to boot NetBSD again

* Fix many artist framebuffer out-of-bounds accesses as found by Alexander Bulekov

* Fix artist memory access bugs due to commit 5d971f9e6725 ("memory: Revert "memory: accept mismatching sizes in memory_region_access_valid")

* Fix various artist screen updates when running dtwm on HP-UX

In addition the SeaBIOS-hppa firmware now includes a version check to prevent starting when it's incompatible to the emulated qemu hardware.

The patchset can be pulled from
https://github.com/hdeller/qemu-hppa.git target-hppa

Helge

----------------------------------------------------------------
Changes to v3:
* Fix memory fallouts due to commit 5d971f9e6725
* Fix graphic rendering bugs and screen refreshes with dtwm on HP-UX

Changes to v2:
* added more Acks by Richard Henderson
* added more artist framebuffer out-of-bounds fixes by Philippe Mathieu-Daudé which were reported by Alexander Bulekov
* fix NetBSD boot

Changes to v1:
* added Ack by Richard Henderson for the first patch
* revised out of bounds check based on Richards feedback

Helge Deller (7):
hw/hppa: Sync hppa_hardware.h file with SeaBIOS sources
seabios-hppa: Update to SeaBIOS hppa version 1
hw/hppa: Implement proper SeaBIOS version check hw/hppa/lasi: Don't abort on invalid IMR value
Revert "hw/display/artist: Avoid drawing line when nothing to display" hw/display/artist: Prevent out of VRAM buffer accesses hw/display/artist: Unbreak size mismatch memory accesses

Philippe Mathieu-Daudé (2):
hw/display/artist: Check offset in draw_line to avoid buffer over-run hw/display/artist: Refactor artist_rop8() to avoid buffer over-run

Sven Schnelle (3):
hw/display/artist.c: fix out of bounds check hw/display/artist: Fix invalidation of lines in artist_draw_line() hw/display/artist: Fix invalidation of lines near screen border

 hw/display/artist.c       | 179 +++++++++++++++++++++++---------------
 hw/hppa/hppa_hardware.h   |   6 ++
 hw/hppa/lasi.c            |   9 +-
 hw/hppa/machine.c         |  22 +++++
 pc-bios/hppa-firmware.img | Bin 766136 -> 783192 bytes
 roms/seabios-hppa         |   2 +-
 6 files changed, 143 insertions(+), 75 deletions(-)

--
2.21.3