Skip to content

Multiple fixes to XENMEM_acquire_resource

Andrew Cooper xen-devel 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest7 patches 21 repliesIn review
  2. v211 patches 28 repliesSuperseded
  3. v15 patches 31 repliesSuperseded

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/7xen/gnttab: Rework resource acquisitionxen/common/grant_table.c xen/common/memory.c xen/include/xen/grant_table.h+62 -7910 replies
2/7xen/memory: Fix acquire_resource size semanticsxen/arch/x86/mm.c xen/common/grant_table.c xen/common/memory.c +4 more+109 -173 replies
3/7tools/foreignmem: Support querying the size of a resourcetools/include/xenforeignmemory.h tools/libs/foreignmemory/Makefile tools/libs/foreignmemory/core.c +3 more+68 -70 replies
4/7xen/memory: Clarify the XENMEM_acquire_resource ABI descriptionxen/include/public/memory.h+5 -20 replies
5/7xen/memory: Improve compat XENMEM_acquire_resource handlingxen/common/compat/memory.c+40 -253 replies
6/7xen/memory: Indent part of acquire_resource()xen/common/memory.c+34 -320 replies
7/7xen/memory: Fix mapping grant tables with XENMEM_acquire_resourcexen/arch/x86/mm.c xen/common/compat/memory.c xen/common/grant_table.c +1 more+167 -485 replies

Reviews trailers per patch

6 of 7 patches have a Reviewed-by or Acked-by.

PatchRoger Pau MonnéPaul DurrantJan BeulichIan Jackson
1/7R-b A-b
2/7R-b R-b
3/7R-b
4/7R-b
5/7R-b
6/7R-b
7/7

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.

Read the v3 thread

Cover letter [PATCH v3 0/7] Multiple fixes to XENMEM_acquire_resource

I thought this was going to be a very simple small bugfix for Michał's Processor Trace series. Serves me right for expecting it not to be full of bear traps...

The sole implementation of acquire_resource never asks for size, so its little surprise that Xen is broken for compat callers, and returns incorrect information for regular callers.

v2 was delayed substantially due to the discovery of XSA-334, but is complete now, permitting the mapping of arbitrary sized resouces, along with fixes to the compat XLAT logic.

v3 was delayed substanitally due to other security work. The major change from v2 is how the size request works from userspace, which now depends on:

https://lore.kernel.org/xen-devel/[email protected]/T/#u

to fix the IOCTL in Linux without breaking ioctl-restrict usecases.

A branch can be obtained from:

https://xenbits.xen.org/gitweb/?p=people/andrewcoop/xen.git;a=shortlog;h=refs/heads/xen-acquire-resource

Andrew Cooper (7):
xen/gnttab: Rework resource acquisition
xen/memory: Fix acquire_resource size semantics tools/foreignmem: Support querying the size of a resource xen/memory: Clarify the XENMEM_acquire_resource ABI description xen/memory: Improve compat XENMEM_acquire_resource handling xen/memory: Indent part of acquire_resource() xen/memory: Fix mapping grant tables with XENMEM_acquire_resource

 tools/include/xenforeignmemory.h                 |  15 ++
 tools/libs/foreignmemory/Makefile                |   2 +-
 tools/libs/foreignmemory/core.c                  |  18 ++
 tools/libs/foreignmemory/freebsd.c               |  18 +-
 tools/libs/foreignmemory/libxenforeignmemory.map |   4 +
 tools/libs/foreignmemory/linux.c                 |  18 +-
 xen/arch/x86/mm.c                                |  24 ++-
 xen/common/compat/memory.c                       | 147 ++++++++++++----
 xen/common/grant_table.c                         | 106 +++++++++---
 xen/common/memory.c                              | 210 ++++++++++++++---------
 xen/include/asm-x86/mm.h                         |   3 +
 xen/include/public/memory.h                      |  23 ++-
 xen/include/xen/grant_table.h                    |  21 ++-
 xen/include/xen/mm.h                             |   6 +
 14 files changed, 445 insertions(+), 170 deletions(-)
Signature · 1 line
2.11.0