Multiple fixes to XENMEM_acquire_resource
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v3 Latest7 patches 21 repliesIn review
- v211 patches 28 repliesSuperseded
- v15 patches 31 repliesSuperseded
Patches in v3 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/7 | xen/gnttab: Rework resource acquisitionxen/ xen/ xen/ | +62 | 10 replies | |
| 2/7 | xen/memory: Fix acquire_resource size semanticsxen/ xen/ xen/ +4 more | +109 | 3 replies | |
| 3/7 | tools/foreignmem: Support querying the size of a resourcetools/ tools/ tools/ +3 more | +68 | 0 replies | |
| 4/7 | xen/memory: Clarify the XENMEM_acquire_resource ABI descriptionxen/ | +5 | 0 replies | |
| 5/7 | xen/memory: Improve compat XENMEM_acquire_resource handlingxen/ | +40 | 3 replies | |
| 6/7 | xen/memory: Indent part of acquire_resource()xen/ | +34 | 0 replies | |
| 7/7 | xen/memory: Fix mapping grant tables with XENMEM_acquire_resourcexen/ xen/ xen/ +1 more | +167 | 5 replies |
Reviews trailers per patch
6 of 7 patches have a Reviewed-by or Acked-by.
| Patch | Roger Pau Monné | Paul Durrant | Jan Beulich | Ian Jackson |
|---|---|---|---|---|
| 1/7 | R-b | A-b | ||
| 2/7 | R-b | R-b | ||
| 3/7 | R-b | |||
| 4/7 | R-b | |||
| 5/7 | R-b | |||
| 6/7 | R-b | |||
| 7/7 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.
Cover letter [PATCH v3 0/7] Multiple fixes to XENMEM_acquire_resource
I thought this was going to be a very simple small bugfix for Michał's Processor Trace series. Serves me right for expecting it not to be full of bear traps...
The sole implementation of acquire_resource never asks for size, so its little surprise that Xen is broken for compat callers, and returns incorrect information for regular callers.
v2 was delayed substantially due to the discovery of XSA-334, but is complete now, permitting the mapping of arbitrary sized resouces, along with fixes to the compat XLAT logic.
v3 was delayed substanitally due to other security work. The major change from v2 is how the size request works from userspace, which now depends on:
https://lore.kernel.org/xen-devel/[email protected]/T/#u
to fix the IOCTL in Linux without breaking ioctl-restrict usecases.
A branch can be obtained from:
Andrew Cooper (7):
xen/gnttab: Rework resource acquisition
xen/memory: Fix acquire_resource size semantics tools/foreignmem: Support querying the size of a resource xen/memory: Clarify the XENMEM_acquire_resource ABI description xen/memory: Improve compat XENMEM_acquire_resource handling xen/memory: Indent part of acquire_resource() xen/memory: Fix mapping grant tables with XENMEM_acquire_resource
tools/include/xenforeignmemory.h | 15 ++ tools/libs/foreignmemory/Makefile | 2 +- tools/libs/foreignmemory/core.c | 18 ++ tools/libs/foreignmemory/freebsd.c | 18 +- tools/libs/foreignmemory/libxenforeignmemory.map | 4 + tools/libs/foreignmemory/linux.c | 18 +- xen/arch/x86/mm.c | 24 ++- xen/common/compat/memory.c | 147 ++++++++++++---- xen/common/grant_table.c | 106 +++++++++--- xen/common/memory.c | 210 ++++++++++++++--------- xen/include/asm-x86/mm.h | 3 + xen/include/public/memory.h | 23 ++- xen/include/xen/grant_table.h | 21 ++- xen/include/xen/mm.h | 6 + 14 files changed, 445 insertions(+), 170 deletions(-)
Signature · 1 line
2.11.0