Skip to content

netfilter: conntrack: Fix CT offload timeout on heavily loaded systems

Roi Dayan netdev 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest2 patches 3 repliesIn review
  2. v12 patches 4 repliesSuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2netfilter: conntrack: Move nf_ct_offload_timeout to header fileinclude/net/netfilter/nf_conntrack.h net/netfilter/nf_conntrack_core.c+12 -122 replies
2/2netfilter: flowtable: Set offload timeout when adding flownet/netfilter/nf_flow_table_core.c+2 -00 replies

Reviews trailers per patch

1 of 2 patches has a Reviewed-by or Acked-by.

PatchOz Shlomo
1/2R-b
2/2

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH net v2 0/2] netfilter: conntrack: Fix CT offload timeout on heavily loaded systems

On heavily loaded systems the GC can take time to go over all existing conns and reset their timeout. At that time other calls like from nf_conntrack_in() can call of nf_ct_is_expired() and see the conn as expired. To fix this when we set the offload bit we should also reset the timeout instead of counting on GC to finish first iteration over all conns before the initial timeout.

First commit is to expose the function that updates the timeout. Second commit is to use it from flow_offload_add().

Roi Dayan (2):
netfilter: conntrack: Move nf_ct_offload_timeout to header file
netfilter: flowtable: Set offload timeout when adding flow

 include/net/netfilter/nf_conntrack.h | 12 ++++++++++++
 net/netfilter/nf_conntrack_core.c    | 12 ------------
 net/netfilter/nf_flow_table_core.c   |  2 ++
 3 files changed, 14 insertions(+), 12 deletions(-)
Signature · 1 line
2.8.4