Skip to content

btrfs-progs: convert: better ENOSPC handling

Qu Wenruo linux-btrfs 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 5 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3btrfs-progs: convert: handle errors better in ext2_copy_inodes()convert/source-ext2.c+31 -110 replies
2/3btrfs-progs: convert: update error message to reflect original fs unmodified casesconvert/main.c+7 -10 replies
3/3btrfs-progs: convert: report available space before convertion happensconvert/common.h convert/main.c convert/source-fs.c+34 -23 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/3] btrfs-progs: convert: better ENOSPC handling

This patchset is to address a bug report [1], where even with the bit overflow bug fixed, the user is still unable to convert an ext4 fs to btrfs.

The error is -ENOSPC, which triggers BUG_ON() and brings the end to the convertion.

We're still waiting for the image dump to determine what's the real cause is, but considering the user is still reporting around 40% free space, I guess it's something wrong with the extent allocator.

But still, we can enhance btrfs-convert to make it handle errors more gracefully, with better error message, and even some debugging info like the available space / total space ratio.

Qu Wenruo (3):
btrfs-progs: convert: handle errors better in ext2_copy_inodes()
btrfs-progs: convert: update error message to reflect original fs
unmodified cases
btrfs-progs: convert: report available space before convertion happens

 convert/common.h      |  9 +++++++++
 convert/main.c        | 34 +++++++++++++++++++++++++++++++---
 convert/source-ext2.c | 42 +++++++++++++++++++++++++++++++-----------
 convert/source-fs.c   |  1 +
 4 files changed, 72 insertions(+), 14 deletions(-)
Signature · 1 line
2.27.0