Skip to content

Add Broadcom VK driver

Scott Branden lkml 11 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v10 Latest13 patches 2 repliesIn review
  2. v913 patches 1 replySuperseded
  3. v813 patches 5 repliesSuperseded
Earlier versions · 8
VersionPostedPatchesRepliesStatus
v713 patches2 repliesSuperseded
v614 patches2 repliesSuperseded
v515 patches17 repliesSuperseded
v416 patches8 repliesSuperseded
v33 patches11 repliesSuperseded
v2 posting 2/23 patches12 repliesSuperseded
v2 posting 1/23 patches0 repliesSuperseded
v13 patches0 repliesSuperseded

Changes in v10 from the cover letter

- fix compile if CONFIG_TTY not set
- use if-else statement instead of conditional expression in set_q_num
- generate bcm_vk_msg_remove call in proper patch
(was generated in tty patch when should be in msg patch)

Patches in v10 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/13bcm-vk: add bcm_vk UAPIinclude/uapi/linux/misc/bcm_vk.h+84 -00 replies
2/13misc: bcm-vk: add Broadcom VK driverdrivers/misc/Kconfig drivers/misc/Makefile drivers/misc/bcm-vk/Kconfig +3 more+197 -00 replies
3/13misc: bcm-vk: add autoload supportdrivers/misc/bcm-vk/bcm_vk.h drivers/misc/bcm-vk/bcm_vk_dev.c+973 -00 replies
4/13misc: bcm-vk: add misc device to Broadcom VK driverdrivers/misc/bcm-vk/bcm_vk.h drivers/misc/bcm-vk/bcm_vk_dev.c+37 -10 replies
5/13misc: bcm-vk: add triggers when host panic or reboots to notify carddrivers/misc/bcm-vk/bcm_vk.h drivers/misc/bcm-vk/bcm_vk_dev.c+30 -10 replies
6/13misc: bcm-vk: add open/releasedrivers/misc/bcm-vk/Makefile drivers/misc/bcm-vk/bcm_vk.h drivers/misc/bcm-vk/bcm_vk_dev.c +2 more+199 -10 replies
7/13misc: bcm-vk: add ioctl load_imagedrivers/misc/bcm-vk/bcm_vk.h drivers/misc/bcm-vk/bcm_vk_dev.c+98 -00 replies
8/13misc: bcm-vk: add get_card_info, peerlog_info, and proc_mon_infodrivers/misc/bcm-vk/bcm_vk.h drivers/misc/bcm-vk/bcm_vk_dev.c+165 -00 replies
9/13misc: bcm-vk: add VK messaging supportdrivers/misc/bcm-vk/Makefile drivers/misc/bcm-vk/bcm_vk.h drivers/misc/bcm-vk/bcm_vk_dev.c +4 more+2095 -30 replies
10/13misc: bcm-vk: reset_pid supportdrivers/misc/bcm-vk/bcm_vk.h drivers/misc/bcm-vk/bcm_vk_dev.c drivers/misc/bcm-vk/bcm_vk_msg.c+191 -80 replies
11/13misc: bcm-vk: add mmap function for exposing BAR2drivers/misc/bcm-vk/bcm_vk_dev.c+24 -00 replies
12/13MAINTAINERS: bcm-vk: add maintainer for Broadcom VK DriverMAINTAINERS+7 -00 replies
13/13misc: bcm-vk: add ttyVK supportdrivers/misc/bcm-vk/Makefile drivers/misc/bcm-vk/bcm_vk.h drivers/misc/bcm-vk/bcm_vk_dev.c +1 more+402 -10 replies

Reviews trailers per patch

All 13 patches have a Reviewed-by or Acked-by.

PatchOlof Johansson
1/13A-b
2/13A-b
3/13A-b
4/13A-b
5/13A-b
6/13A-b
7/13A-b
8/13A-b
9/13A-b
10/13A-b
11/13A-b
12/13A-b
13/13A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v10 thread

Cover letter [PATCH v10 00/13] Add Broadcom VK driver

This patch series drops previous patches in [1] that were incorporated by Kees Cook into patch series "Introduce partial kernel_read_file() support" [2].

Remaining patches are contained in this series to add Broadcom VK driver. (which depends on request_firmware_into_buf API addition which has now been accepted into the upstream kernel as of v5.10-rc1).

[1] https://lore.kernel.org/lkml/[email protected]/
[2] https://lore.kernel.org/lkml/[email protected]/

Changes from v9:
- fix compile if CONFIG_TTY not set
- use if-else statement instead of conditional expression in set_q_num
- generate bcm_vk_msg_remove call in proper patch
(was generated in tty patch when should be in msg patch)
Changes from v8:
- add ack's by Olof Johansson
Changes from v7:
- add more information in Kconfig help description
Changes from v6:
- drop QSTATS patch as it needs to be reviewed if trace_printk makes sense
- add wdog and IPC interface alerts
- add boundary check to msgq and peerlog
- clear additional registers on reset
Changes from v5:
- dropped sysfs patch from series for now as rework to use hwmon
- tty patch still at end of series to drop if another solution available
- updated cover letter commit to point to Kees' latest patch submission in [2]
- specified --base with Kees' patches applied (kernel branches don't have these yet)
- removed trivial comment
- moved location of const to before the struct in two declarations
- changed dev_info to dev_warn and only print when irq don't match expected
- changed dev_info to dev_dbg when printing debug QSTATS
- removed unnecessary %p print
Changes from v4:
- fixed memory leak in probe function on failure
- changed -1 to -EBUSY in bcm_vk_tty return code
- move bcm_vk_tty patch to end of patch series so it
can be dropped from current patch series if needed
and rearchitected if needed.
Changes from v3:
- split driver into more incremental commits for acceptance/review
- lowered some dev_info to dev_dbg
- remove ANSI stdint types and replace with linux u8, etc types
- changed an EIO return to EPFNOSUPPORT
- move vk_msg_cmd internal to driver to not expose to UAPI at this time
Changes from v2:
- open code BIT macro in uapi header
- A0/B0 boot improvements
Changes from v1:
- declare bcm_vk_intf_ver_chk as static

Scott Branden (13):
bcm-vk: add bcm_vk UAPI
misc: bcm-vk: add Broadcom VK driver
misc: bcm-vk: add autoload support
misc: bcm-vk: add misc device to Broadcom VK driver
misc: bcm-vk: add triggers when host panic or reboots to notify card
misc: bcm-vk: add open/release
misc: bcm-vk: add ioctl load_image
misc: bcm-vk: add get_card_info, peerlog_info, and proc_mon_info
misc: bcm-vk: add VK messaging support
misc: bcm-vk: reset_pid support
misc: bcm-vk: add mmap function for exposing BAR2
MAINTAINERS: bcm-vk: add maintainer for Broadcom VK Driver
misc: bcm-vk: add ttyVK support

 MAINTAINERS                      |    7 +
 drivers/misc/Kconfig             |    1 +
 drivers/misc/Makefile            |    1 +
 drivers/misc/bcm-vk/Kconfig      |   17 +
 drivers/misc/bcm-vk/Makefile     |   12 +
 drivers/misc/bcm-vk/bcm_vk.h     |  513 +++++++++
 drivers/misc/bcm-vk/bcm_vk_dev.c | 1664 ++++++++++++++++++++++++++++++
 drivers/misc/bcm-vk/bcm_vk_msg.c | 1356 ++++++++++++++++++++++++
 drivers/misc/bcm-vk/bcm_vk_msg.h |  163 +++
 drivers/misc/bcm-vk/bcm_vk_sg.c  |  275 +++++
 drivers/misc/bcm-vk/bcm_vk_sg.h  |   61 ++
 drivers/misc/bcm-vk/bcm_vk_tty.c |  333 ++++++
 include/uapi/linux/misc/bcm_vk.h |   84 ++
 13 files changed, 4487 insertions(+)
 create mode 100644 drivers/misc/bcm-vk/Kconfig
 create mode 100644 drivers/misc/bcm-vk/Makefile
 create mode 100644 drivers/misc/bcm-vk/bcm_vk.h
 create mode 100644 drivers/misc/bcm-vk/bcm_vk_dev.c
 create mode 100644 drivers/misc/bcm-vk/bcm_vk_msg.c
 create mode 100644 drivers/misc/bcm-vk/bcm_vk_msg.h
 create mode 100644 drivers/misc/bcm-vk/bcm_vk_sg.c
 create mode 100644 drivers/misc/bcm-vk/bcm_vk_sg.h
 create mode 100644 drivers/misc/bcm-vk/bcm_vk_tty.c
 create mode 100644 include/uapi/linux/misc/bcm_vk.h
Signature · 1 line
2.17.1