KVM: arm64: Rewrite page-table code and fault handling

Will Deacon kvmarm linux-arm-kernel 5 versions Jul 30, 2020 – Sep 11, 2020 In review

Get series with b4

b4 am [email protected]

Versions newest first · linked by author and title

v5 Latest Sep 11, 202021 patches 6 repliesIn review
v4 Sep 7, 202021 patches 30 repliesSuperseded
v3 Aug 25, 202021 patches 64 repliesSuperseded

Earlier versions · 2

Version	Posted	Patches	Replies	Status
v2	Aug 18, 2020	22 patches	3 replies	Superseded
v1	Jul 30, 2020	20 patches	7 replies	Superseded

Patches in v5 No applies recorded yet

#	Subject and files	Size	Replies
1/21	KVM: arm64: Remove kvm_mmu_free_memory_caches()`arch/arm64/include/asm/kvm_mmu.h` `arch/arm64/kvm/arm.c` `arch/arm64/kvm/mmu.c`	+1 -8	0 replies
2/21	KVM: arm64: Add stand-alone page-table walker infrastructure`arch/arm64/include/asm/kvm_pgtable.h` `arch/arm64/kvm/hyp/Makefile` `arch/arm64/kvm/hyp/pgtable.c`	+390 -1	0 replies
3/21	KVM: arm64: Add support for creating kernel-agnostic stage-1 page tables`arch/arm64/include/asm/kvm_pgtable.h` `arch/arm64/kvm/hyp/pgtable.c`	+173 -0	0 replies
4/21	KVM: arm64: Use generic allocator for hyp stage-1 page-tables`arch/arm64/include/asm/kvm_mmu.h` `arch/arm64/include/asm/kvm_pgtable.h` `arch/arm64/include/asm/pgtable-hwdef.h` +2 more	+45 ~~-464~~	0 replies
5/21	KVM: arm64: Add support for creating kernel-agnostic stage-2 page tables`arch/arm64/include/asm/kvm_host.h` `arch/arm64/include/asm/kvm_pgtable.h` `arch/arm64/kvm/hyp/pgtable.c` +1 more	+102 ~~-26~~	0 replies
6/21	KVM: arm64: Add support for stage-2 map()/unmap() in generic page-table`arch/arm64/include/asm/kvm_pgtable.h` `arch/arm64/kvm/hyp/pgtable.c`	+319 -0	1 reply
7/21	KVM: arm64: Convert kvm_phys_addr_ioremap() to generic page-table API`arch/arm64/kvm/mmu.c`	+14 ~~-16~~	0 replies
8/21	KVM: arm64: Convert kvm_set_spte_hva() to generic page-table API`arch/arm64/kvm/mmu.c`	+10 ~~-13~~	0 replies
9/21	KVM: arm64: Convert unmap_stage2_range() to generic page-table API`arch/arm64/kvm/mmu.c`	+37 ~~-25~~	1 reply
10/21	KVM: arm64: Add support for stage-2 page-aging in generic page-table`arch/arm64/include/asm/kvm_pgtable.h` `arch/arm64/kvm/hyp/pgtable.c`	+130 -0	0 replies
11/21	KVM: arm64: Convert page-aging and access faults to generic page-table API`arch/arm64/kvm/mmu.c`	+16 ~~-58~~	0 replies
12/21	KVM: arm64: Add support for stage-2 write-protect in generic page-table`arch/arm64/include/asm/kvm_pgtable.h` `arch/arm64/kvm/hyp/pgtable.c`	+24 -0	0 replies
13/21	KVM: arm64: Convert write-protect operation to generic page-table API`arch/arm64/kvm/mmu.c`	+4 ~~-21~~	0 replies
14/21	KVM: arm64: Add support for stage-2 cache flushing in generic page-table`arch/arm64/include/asm/kvm_pgtable.h` `arch/arm64/kvm/hyp/pgtable.c`	+41 -0	0 replies
15/21	KVM: arm64: Convert memslot cache-flushing code to generic page-table API`arch/arm64/kvm/mmu.c`	+1 ~~-12~~	0 replies
16/21	KVM: arm64: Add support for relaxing stage-2 perms in generic page-table code`arch/arm64/include/asm/kvm_pgtable.h` `arch/arm64/kvm/hyp/pgtable.c`	+39 -0	1 reply
17/21	KVM: arm64: Convert user_mem_abort() to generic page-table API`arch/arm64/kvm/mmu.c`	+44 ~~-80~~	0 replies
18/21	KVM: arm64: Check the pgt instead of the pgd when modifying page-table`arch/arm64/kvm/mmu.c`	+3 -3	0 replies
19/21	KVM: arm64: Remove unused page-table code`arch/arm64/include/asm/kvm_mmu.h` `arch/arm64/include/asm/pgtable-hwdef.h` `arch/arm64/include/asm/pgtable-prot.h` +2 more	+0 ~~-1172~~	0 replies
20/21	KVM: arm64: Remove unused 'pgd' field from 'struct kvm_s2_mmu'`arch/arm64/include/asm/kvm_host.h` `arch/arm64/kvm/mmu.c`	+0 -3	0 replies
21/21	KVM: arm64: Don't constrain maximum IPA size based on host configuration`arch/arm64/kvm/reset.c`	+6 ~~-34~~	0 replies

Reviews trailers per patch

20 of 21 patches have a Reviewed-by or Acked-by.

Patch	Gavin Shan	Alexandru Elisei
1/21	R-b
2/21	R-b
3/21	R-b
4/21
5/21	R-b
6/21	R-b
7/21	R-b
8/21	R-b
9/21	R-b
10/21	R-b
11/21	R-b	R-b
12/21	R-b
13/21	R-b
14/21	R-b
15/21	R-b
16/21	R-b
17/21	R-b	R-b
18/21	R-b
19/21	R-b
20/21	R-b
21/21	R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v5 thread

Cover letter [PATCH v5 00/21] KVM: arm64: Rewrite page-table code and fault handling

It's me again, with version five of the KVM page-table rework previously seen at:

v1: https://lore.kernel.org/r/[email protected]
v2: https://lore.kernel.org/r/[email protected]
v3: https://lore.kernel.org/r/[email protected]
v4: https://lore.kernel.org/r/[email protected]

Changes since v4 include:

* Add comments to the kerneldoc describing alignment behaviour for addresses and size parameters
* Fix formatting of IPA size messages
* Fix handling of unaligned addresses in kvm_phys_addr_ioremap()
* Add DSB after zeroing stage-2 PGD pages
* Add reviewer tags

Once again, thanks to Alex, Gavin and Andrew for their comments.

Will

Cc Marc Zyngier <[email protected]>

Cc Quentin Perret <[email protected]>

Cc James Morse <[email protected]>

Cc Suzuki Poulose <[email protected]>

Cc Catalin Marinas <[email protected]>

Cc Gavin Shan <[email protected]>

Cc Alexandru Elisei <[email protected]>

Cc Andrew Scull <[email protected]>

Cc [email protected]

--->8

Quentin Perret (4):
KVM: arm64: Add support for stage-2 write-protect in generic
page-table
KVM: arm64: Convert write-protect operation to generic page-table API
KVM: arm64: Add support for stage-2 cache flushing in generic
page-table
KVM: arm64: Convert memslot cache-flushing code to generic page-table
API

Will Deacon (17):
KVM: arm64: Remove kvm_mmu_free_memory_caches()
KVM: arm64: Add stand-alone page-table walker infrastructure
KVM: arm64: Add support for creating kernel-agnostic stage-1 page
tables
KVM: arm64: Use generic allocator for hyp stage-1 page-tables
KVM: arm64: Add support for creating kernel-agnostic stage-2 page
tables
KVM: arm64: Add support for stage-2 map()/unmap() in generic
page-table
KVM: arm64: Convert kvm_phys_addr_ioremap() to generic page-table API
KVM: arm64: Convert kvm_set_spte_hva() to generic page-table API
KVM: arm64: Convert unmap_stage2_range() to generic page-table API
KVM: arm64: Add support for stage-2 page-aging in generic page-table
KVM: arm64: Convert page-aging and access faults to generic page-table
API
KVM: arm64: Add support for relaxing stage-2 perms in generic
page-table code
KVM: arm64: Convert user_mem_abort() to generic page-table API
KVM: arm64: Check the pgt instead of the pgd when modifying page-table
KVM: arm64: Remove unused page-table code
KVM: arm64: Remove unused 'pgd' field from 'struct kvm_s2_mmu'
KVM: arm64: Don't constrain maximum IPA size based on host
configuration

 arch/arm64/include/asm/kvm_host.h       |    2 +-
 arch/arm64/include/asm/kvm_mmu.h        |  251 +---
 arch/arm64/include/asm/kvm_pgtable.h    |  309 ++++
 arch/arm64/include/asm/pgtable-hwdef.h  |   24 -
 arch/arm64/include/asm/pgtable-prot.h   |   19 -
 arch/arm64/include/asm/stage2_pgtable.h |  215 ---
 arch/arm64/kvm/arm.c                    |    2 +-
 arch/arm64/kvm/hyp/Makefile             |    2 +-
 arch/arm64/kvm/hyp/pgtable.c            |  883 ++++++++++++
 arch/arm64/kvm/mmu.c                    | 1748 ++++-------------------
 arch/arm64/kvm/reset.c                  |   40 +-
 11 files changed, 1479 insertions(+), 2016 deletions(-)
 create mode 100644 arch/arm64/include/asm/kvm_pgtable.h
 create mode 100644 arch/arm64/kvm/hyp/pgtable.c

Signature · 6 lines

2.28.0.618.gf4bc123cb7-goog

_______________________________________________
kvmarm mailing list
[email protected]
https://lists.cs.columbia.edu/mailman/listinfo/kvmarm

Read the cover letter in its thread