Skip to content

rework stolen pre-OS fb allocation handling (v3)

Alex Deucher amd-gfx 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest17 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/17drm/amdgpu: handle bo size 0 in amdgpu_bo_create_kernel_at (v2)drivers/gpu/drm/amd/amdgpu/amdgpu_object.c+3 -00 replies
2/17drm/amdgpu: use create_at for the stolen pre-OS bufferdrivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c+4 -40 replies
3/17drm/amdgpu: use a define for the memory size of the vga emulatordrivers/gpu/drm/amd/amdgpu/amdgpu.h drivers/gpu/drm/amd/amdgpu/gmc_v10_0.c drivers/gpu/drm/amd/amdgpu/gmc_v6_0.c +3 more+8 -60 replies
4/17drm/amdgpu: move stolen vga bo from amdgpu to amdgpu.gmcdrivers/gpu/drm/amd/amdgpu/amdgpu.h drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.h drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c +5 more+11 -110 replies
5/17drm/amdgpu: move keep stolen memory check into gmc coredrivers/gpu/drm/amd/amdgpu/amdgpu_gmc.h drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c+12 -90 replies
6/17drm/amdgpu: add support for extended stolen vga memorydrivers/gpu/drm/amd/amdgpu/amdgpu_gmc.h drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c+13 -20 replies
7/17drm/amdgpu/gmc: add new helper to get the FB size used by pre-OS consoledrivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.h+48 -00 replies
8/17drm/amdgpu/gmc6: switch to using amdgpu_gmc_get_vbios_allocationsdrivers/gpu/drm/amd/amdgpu/gmc_v6_0.c+2 -40 replies
9/17drm/amdgpu/gmc7: switch to using amdgpu_gmc_get_vbios_allocationsdrivers/gpu/drm/amd/amdgpu/gmc_v7_0.c+4 -50 replies
10/17drm/amdgpu/gmc8: switch to using amdgpu_gmc_get_vbios_allocationsdrivers/gpu/drm/amd/amdgpu/gmc_v8_0.c+4 -50 replies
11/17drm/amdgpu/gmc9: switch to using amdgpu_gmc_get_vbios_allocationsdrivers/gpu/drm/amd/amdgpu/gmc_v9_0.c+38 -740 replies
12/17drm/amdgpu/gmc10: switch to using amdgpu_gmc_get_vbios_allocationsdrivers/gpu/drm/amd/amdgpu/gmc_v10_0.c+25 -320 replies
13/17drm/amdgpu: drop the CPU pointers for the stolen vga bosdrivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c+5 -110 replies
14/17drm/amdgpu/gmc: disable keep_stolen_vga_memory on arcturusdrivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c+0 -10 replies
15/17drm/amdgpu: move stolen memory from gmc to mmandrivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.h drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c +1 more+22 -210 replies
16/17drm/amdgpu: move IP discovery data to mmandrivers/gpu/drm/amd/amdgpu/amdgpu.h drivers/gpu/drm/amd/amdgpu/amdgpu_device.c drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c +2 more+44 -440 replies
17/17drm/amdgpu: move vram usage by vbios to mman (v2)drivers/gpu/drm/amd/amdgpu/amdgpu.h drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c drivers/gpu/drm/amd/amdgpu/amdgpu_atomfirmware.c +3 more+23 -291 reply

Reviews trailers per patch

All 17 patches have a Reviewed-by or Acked-by.

PatchChristian KönigFelix Kuehling
1/17R-b R-b
2/17R-b R-b
3/17R-b R-b
4/17R-b R-b
5/17R-b R-b
6/17R-b R-b
7/17R-b R-b
8/17R-b R-b
9/17R-b R-b
10/17R-b R-b
11/17R-b R-b
12/17R-b R-b
13/17R-b R-b
14/17R-b R-b
15/17R-b
16/17R-b
17/17R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 00/17] rework stolen pre-OS fb allocation handling (v3)

Split the allocations into two so we can still support the S3 workarounds required on some platforms while also avoiding any artifacts when transitioning from bios to driver.

In the future we could integrate handling of the ip discovery data and other vbios allocations into this helper function to consolidate handling of all of the vbios reservations.

v2: Check if bo object is NULL rather than checking size
Move all vbios/firmware allocations into mman structure
v3: Inline fw vram usage structure

Alex Deucher (17):
drm/amdgpu: handle bo size 0 in amdgpu_bo_create_kernel_at (v2) drm/amdgpu: use create_at for the stolen pre-OS buffer drm/amdgpu: use a define for the memory size of the vga emulator drm/amdgpu: move stolen vga bo from amdgpu to amdgpu.gmc drm/amdgpu: move keep stolen memory check into gmc core drm/amdgpu: add support for extended stolen vga memory drm/amdgpu/gmc: add new helper to get the FB size used by pre-OS
console
drm/amdgpu/gmc6: switch to using amdgpu_gmc_get_vbios_allocations drm/amdgpu/gmc7: switch to using amdgpu_gmc_get_vbios_allocations drm/amdgpu/gmc8: switch to using amdgpu_gmc_get_vbios_allocations drm/amdgpu/gmc9: switch to using amdgpu_gmc_get_vbios_allocations drm/amdgpu/gmc10: switch to using amdgpu_gmc_get_vbios_allocations drm/amdgpu: drop the CPU pointers for the stolen vga bos drm/amdgpu/gmc: disable keep_stolen_vga_memory on arcturus drm/amdgpu: move stolen memory from gmc to mman drm/amdgpu: move IP discovery data to mman
drm/amdgpu: move vram usage by vbios to mman (v2)

 drivers/gpu/drm/amd/amdgpu/amdgpu.h           |  20 +--
 drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c  |   4 +-
 .../gpu/drm/amd/amdgpu/amdgpu_atomfirmware.c  |   4 +-
 drivers/gpu/drm/amd/amdgpu/amdgpu_device.c    |   4 +-
 drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c |  54 ++++----
 drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c       |  42 +++++++
 drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.h       |   6 +-
 drivers/gpu/drm/amd/amdgpu/amdgpu_object.c    |   3 +
 drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c       |  64 ++++++----
 drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.h       |  17 +++
 drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c      |   6 +-
 drivers/gpu/drm/amd/amdgpu/gmc_v10_0.c        |  57 ++++-----
 drivers/gpu/drm/amd/amdgpu/gmc_v6_0.c         |   8 +-
 drivers/gpu/drm/amd/amdgpu/gmc_v7_0.c         |  11 +-
 drivers/gpu/drm/amd/amdgpu/gmc_v8_0.c         |  11 +-
 drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c         | 119 ++++++------------
 16 files changed, 219 insertions(+), 211 deletions(-)
Signature · 6 lines
2.25.4

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx