Skip to content

perf tools: Add wallclock time conversion support

Jiri Olsa lkml 2 versions – Applied

Status from this message: Thanks, applied.

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest7 patches 6 repliesApplied
  2. v16 patches 17 repliesSuperseded

Changes in v2 from the cover letter

- fixed HEADER_CLOCK_DATA doc, typo, print format [Namhyung]
- moved clockid related code into separate object [Andi]

Patches in v2 Applied

#Subject and filesSizeRepliesApplied
1/7perf tools: Move parse_clockid into clockid objecttools/perf/builtin-record.c tools/perf/util/Build tools/perf/util/clockid.c +1 more+119 -971 reply
2/7perf tools: Add clockid_name functiontools/perf/util/clockid.c tools/perf/util/clockid.h+13 -00 replies
3/7perf tools: Store clock references for -k/--clockid optiontools/perf/Documentation/perf.data-file-format.txt tools/perf/builtin-record.c tools/perf/util/env.h +2 more+180 -01 reply
4/7perf tools: Move clockid_res_ns under clock structtools/perf/builtin-record.c tools/perf/util/env.h tools/perf/util/header.c+8 -81 reply
5/7perf tools: Add support to store time of day in CTF data conversiontools/perf/Documentation/perf-data.txt tools/perf/builtin-data.c tools/perf/util/data-convert-bt.c +1 more+42 -201 reply
6/7perf script: Change enum perf_output_field values to be 64 bitstools/perf/builtin-script.c+32 -321 reply
7/7perf script: Add tod field to display time of daytools/perf/builtin-script.c+98 -331 reply

Reviews trailers per patch

None of the 7 patches has a Reviewed-by or Acked-by.

PatchDavid Ahern
1/7
2/7
3/7Original-patch-by
4/7
5/7
6/7
7/7Original-patch-by

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/7] perf tools: Add wallclock time conversion support

hi,
this patchset is based on changes made by David Ahern long time ago. The perf code moved a lot since then, but the idea is the same.

The patchset is adding the ability to display TOD/wallclock timestamp in 'perf script' output and in 'perf data convert --to-ctf' subcommand, so the converted CTF data contain TOD/wallclock timestamps.

It's done by adding new header FEATURE 'CLOCK_DATA' to perf.data, that stores reference times for both TOD/wallclock time and for the clock that perf record is configured to use. These reference times are then used to convert sample's timestamps to TOD/wallclock timestamps.

The feature is available only for recording with clockid specified, because it's the only case where we can get reference time to TOD/wallclock time. We can't do that with perf clock yet.

Also available in here:
git://git.kernel.org/pub/scm/linux/kernel/git/jolsa/perf.git
perf/abs_time

v2 changes:
- fixed HEADER_CLOCK_DATA doc, typo, print format [Namhyung]
- moved clockid related code into separate object [Andi]

thanks,
jirka

---
Jiri Olsa (7):
perf tools: Move parse_clockid into clockid object
perf tools: Add clockid_name function
perf tools: Store clock references for -k/--clockid option perf tools: Move clockid_res_ns under clock struct
perf tools: Add support to store time of day in CTF data conversion perf script: Change enum perf_output_field values to be 64 bits perf script: Add tod field to display time of day

 tools/perf/Documentation/perf-data.txt             |   3 ++
 tools/perf/Documentation/perf.data-file-format.txt |  13 +++++++
 tools/perf/builtin-data.c                          |   1 +
 tools/perf/builtin-record.c                        | 145 +++++++++++++++++++++++---------------------------------------------------
 tools/perf/builtin-script.c                        | 195 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++----------------------------------
 tools/perf/util/Build                              |   1 +
 tools/perf/util/clockid.c                          | 119 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
 tools/perf/util/clockid.h                          |  11 ++++++
 tools/perf/util/data-convert-bt.c                  |  57 ++++++++++++++++++-----------
 tools/perf/util/data-convert.h                     |   1 +
 tools/perf/util/env.h                              |  14 +++++++-
 tools/perf/util/header.c                           | 121 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++---
 tools/perf/util/header.h                           |   1 +
 13 files changed, 492 insertions(+), 190 deletions(-)
 create mode 100644 tools/perf/util/clockid.c
 create mode 100644 tools/perf/util/clockid.h