8390: core cleanups
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v5 Latest6 patches 3 repliesIn review
- v43 patches 2 repliesSuperseded
- v32 patches 2 repliesSuperseded
Earlier versions · 1
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v2 | 2 patches | 3 replies | Superseded |
Changes in v5 from the cover letter
- sort includes
- do not realign comments
- move pr_cont() -> netdev_err() change to separate patch
- remove unused DRV_RELDATA and DRV_NAME
- break 8390.c changes into separate patches
Patches in v5 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/6 | lib8390: Fix coding style issues and remove version printingdrivers/ | +186 | 1 reply | |
| 2/6 | lib8390: Replace pr_cont() with SMP-safe constructdrivers/ | +12 | 1 reply | |
| 3/6 | 8390: Replace version string with MODULE_* macrosdrivers/ | +5 | 0 replies | |
| 4/6 | 8390: Include necessary librariesdrivers/ | +7 | 0 replies | |
| 5/6 | 8390: Fix coding style issuesdrivers/ | +2 | 0 replies | |
| 6/6 | 8390: Remove version stringdrivers/ drivers/ drivers/ +5 more | +20 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v5 yet.
Cover letter [PATCH net-next v5 0/6] 8390: core cleanups
The purpose of this patchset is to do some
cleanups in lib8390.c and 8390.c
While most changes are coding style related, pr_cont() usage in lib8390.c was replaced by
a more SMP-safe construct.
Other functional changes include the removal of version-printing in lib8390.c so modules using lib8390.c do not need a global version-string in order to compile successfully.
Patches do compile and run flawless on 5.9.0-rc3 with a RTL8029AS nic using ne2k-pci.
v5 changes:
- sort includes
- do not realign comments
- move pr_cont() -> netdev_err() change to separate patch
- remove unused DRV_RELDATA and DRV_NAME
- break 8390.c changes into separate patches
v4 changes:
- remove unused version string to prevent warnings
v3 changes:
- swap commits to not break buildability (sorry)
- move MODULE_LICENCE at the bottom and remove MODULE_VERSION in 8390.c
v2 changes:
- change "librarys" to "libraries" in 8390.c commit
- improve 8390.c commit
- prevent uneven whitespaces in error message (lib8390.c)
- do not destroy kernel doc comments in lib8390.c
- fix some typos in lib8390.c
Armin Wolf (6):
lib8390: Fix coding style issues and remove version printing
lib8390: Replace pr_cont() with SMP-safe construct 8390: Replace version string with MODULE_* macros 8390: Include necessary libraries
8390: Fix coding style issues
8390: Remove version string
drivers/net/ethernet/8390/8390.c | 18 +- drivers/net/ethernet/8390/8390p.c | 15 +- drivers/net/ethernet/8390/ax88796.c | 3 - drivers/net/ethernet/8390/etherh.c | 3 - drivers/net/ethernet/8390/hydra.c | 7 +- drivers/net/ethernet/8390/lib8390.c | 433 ++++++++++++-------------- drivers/net/ethernet/8390/mac8390.c | 3 - drivers/net/ethernet/8390/mcf8390.c | 3 - drivers/net/ethernet/8390/xsurf100.c | 3 - drivers/net/ethernet/8390/zorro8390.c | 5 +- 10 files changed, 232 insertions(+), 261 deletions(-)
--
2.20.1