Skip to content

Fix init for device stats for seed devices

Josef Bacik linux-btrfs 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest2 patches 1 replyIn review
  2. v22 patches 8 repliesSuperseded
  3. v11 patch 3 repliesSuperseded

Changes in v3 from the cover letter

- fixed the name and arguments in the first patch.
- use goto out for the error case with seed devices.

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2btrfs: init device stats for seed devicesfs/btrfs/volumes.c+48 -410 replies
2/2btrfs: return error if we're unable to read device statsfs/btrfs/volumes.c+16 -80 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v3 yet.

Read the v3 thread

Cover letter [PATCH v3 0/2] Fix init for device stats for seed devices

v2->v3:
- fixed the name and arguments in the first patch.
- use goto out for the error case with seed devices.

v1->v2:
- Rework initial fix to work with the new seed_list.
- Add a follow up patch to address the fact that we were ignoring errors on reading the device tree.

Hello,

We see a lot of messages in the fleet where we use seed devices because we're not init'ing the stats for seed devices properly. I have an xfstest that shows this (which I need to update), and this patch fixes the problem. It's relatively straightforward, simply init the stats on seed devices at the same time we init them on our primary devices. Thanks,

Josef

Josef Bacik (2):
btrfs: init device stats for seed devices
btrfs: return error if we're unable to read device stats

 fs/btrfs/volumes.c | 93 +++++++++++++++++++++++++++-------------------
 1 file changed, 54 insertions(+), 39 deletions(-)
Signature · 1 line
2.26.2