Skip to content

PCI: dwc: Driver clean-ups

Rob Herring linux-amlogic linux-arm-kernel linux-arm-msm linux-omap linux-pci linux-samsung-soc linux-tegra oe-kbuild-all 2 versions – Applied

Status from this message: Applied the series to pci/dwc, thanks.

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest40 patches 10 repliesApplied
  2. v1 RFC27 patches 0 repliesSuperseded

Patches in v2 Applied

#Subject and filesSizeRepliesApplied
1/40PCI: Allow root and child buses to have different pci_opsdrivers/pci/probe.c include/linux/pci.h+8 -10 replies
2/40PCI: dwc: Use DBI accessors instead of own config accessorsdrivers/pci/controller/dwc/pcie-designware-host.c+19 -360 replies
3/40PCI: dwc: Allow overriding bridge pci_opsdrivers/pci/controller/dwc/pcie-designware-host.c drivers/pci/controller/dwc/pcie-designware.h+11 -52 replies
4/40PCI: dwc: Add a default pci_ops.map_bus for root portdrivers/pci/controller/dwc/pcie-designware-host.c drivers/pci/controller/dwc/pcie-designware.h+13 -00 replies
5/40PCI: dwc: al: Use pci_ops for child config space accessorsdrivers/pci/controller/dwc/pcie-al.c+13 -500 replies
6/40PCI: dwc: keystone: Use pci_ops for config space accessorsdrivers/pci/controller/dwc/pci-keystone.c+18 -220 replies
7/40PCI: dwc: tegra: Use pci_ops for root config space accessorsdrivers/pci/controller/dwc/pcie-tegra194.c+16 -140 replies
8/40PCI: dwc: meson: Use pci_ops for root config space accessorsdrivers/pci/controller/dwc/pci-meson.c+10 -130 replies
9/40PCI: dwc: kirin: Use pci_ops for root config space accessorsdrivers/pci/controller/dwc/pcie-kirin.c+21 -180 replies
10/40PCI: dwc: exynos: Use pci_ops for root config space accessorsdrivers/pci/controller/dwc/pci-exynos.c+25 -200 replies
11/40PCI: dwc: histb: Use pci_ops for root config space accessorsdrivers/pci/controller/dwc/pcie-histb.c+23 -180 replies
12/40PCI: dwc: Remove dwc specific config accessor opsdrivers/pci/controller/dwc/pcie-designware-host.c drivers/pci/controller/dwc/pcie-designware.h+0 -200 replies
13/40PCI: dwc: Use generic config accessorsdrivers/pci/controller/dwc/pcie-designware-host.c+37 -820 replies
14/40PCI: Also call .add_bus() callback for root busdrivers/pci/probe.c+6 -00 replies
15/40PCI: dwc: keystone: Convert .scan_bus() callback to use add_busdrivers/pci/controller/dwc/pci-keystone.c+9 -30 replies
16/40PCI: dwc: Convert to use pci_host_probe()drivers/pci/controller/dwc/pcie-designware-host.c drivers/pci/controller/dwc/pcie-designware.h+3 -190 replies
17/40PCI: dwc: Remove root_bus pointerdrivers/pci/controller/dwc/pcie-designware-host.c drivers/pci/controller/dwc/pcie-designware.h drivers/pci/controller/dwc/pcie-tegra194.c+4 -50 replies
18/40PCI: dwc: Remove storing of PCI resourcesdrivers/pci/controller/dwc/pci-keystone.c drivers/pci/controller/dwc/pcie-al.c drivers/pci/controller/dwc/pcie-designware-host.c +1 more+19 -290 replies
19/40PCI: dwc: Simplify config space handlingdrivers/pci/controller/dwc/pci-keystone.c drivers/pci/controller/dwc/pcie-designware-host.c drivers/pci/controller/dwc/pcie-designware.h+20 -550 replies
20/40PCI: dwc/keystone: Drop duplicated 'num-viewport'drivers/pci/controller/dwc/pci-keystone.c+1 -100 replies
21/40PCI: dwc: Check CONFIG_PCI_MSI inside dw_pcie_msi_init()drivers/pci/controller/dwc/pci-imx6.c drivers/pci/controller/dwc/pci-meson.c drivers/pci/controller/dwc/pcie-artpec6.c +6 more+11 -340 replies
22/40PCI: dwc/imx6: Remove duplicate define PCIE_LINK_WIDTH_SPEED_CONTROLdrivers/pci/controller/dwc/pci-imx6.c+0 -20 replies
23/40PCI: dwc: Add a 'num_lanes' field to struct dw_pciedrivers/pci/controller/dwc/pcie-designware.c drivers/pci/controller/dwc/pcie-designware.h+7 -70 replies
24/40PCI: dwc: Ensure FAST_LINK_MODE is cleareddrivers/pci/controller/dwc/pcie-designware.c drivers/pci/controller/dwc/pcie-designware.h+5 -10 replies
25/40PCI: dwc/meson: Drop the duplicate number of lanes setupdrivers/pci/controller/dwc/pci-meson.c+1 -280 replies
26/40PCI: dwc/meson: Drop unnecessary RC config space initializationdrivers/pci/controller/dwc/pci-meson.c+0 -200 replies
27/40PCI: dwc/meson: Rework PCI config and DW port logic register accessesdrivers/pci/controller/dwc/pci-meson.c+25 -510 replies
28/40PCI: dwc/imx6: Use common PCI register definitionsdrivers/pci/controller/dwc/pci-imx6.c+14 -230 replies
29/40PCI: dwc/qcom: Use common PCI register definitionsdrivers/pci/controller/dwc/pcie-qcom.c+8 -100 replies
30/40PCI: dwc: Remove hardcoded PCI_CAP_ID_EXP offsetdrivers/pci/controller/dwc/pci-dra7xx.c drivers/pci/controller/dwc/pci-keystone.c drivers/pci/controller/dwc/pcie-spear13xx.c+7 -120 replies
31/40PCI: dwc/tegra: Use common Designware port logic register definitionsdrivers/pci/controller/dwc/pcie-designware.h drivers/pci/controller/dwc/pcie-tegra194.c+28 -340 replies
32/40PCI: dwc: Remove read_dbi2 codedrivers/pci/controller/dwc/pci-keystone.c drivers/pci/controller/dwc/pcie-designware.c drivers/pci/controller/dwc/pcie-designware.h+0 -360 replies
33/40PCI: dwc: Make ATU accessors privatedrivers/pci/controller/dwc/pcie-designware.c drivers/pci/controller/dwc/pcie-designware.h+6 -180 replies
34/40PCI: dwc: Centralize link gen settingdrivers/pci/controller/dwc/pci-dra7xx.c drivers/pci/controller/dwc/pci-imx6.c drivers/pci/controller/dwc/pci-keystone.c +8 more+40 -1490 replies
35/40PCI: dwc: Set PORT_LINK_DLL_LINK_EN in common setup codedrivers/pci/controller/dwc/pcie-designware.c drivers/pci/controller/dwc/pcie-intel-gw.c+1 -40 replies
36/40PCI: dwc/intel-gw: Drop unnecessary checking of DT 'device_type' propertydrivers/pci/controller/dwc/pcie-intel-gw.c+0 -60 replies
37/40PCI: dwc/intel-gw: Move getting PCI_CAP_ID_EXP offset to intel_pcie_link_setup()drivers/pci/controller/dwc/pcie-intel-gw.c+1 -140 replies
38/40PCI: dwc/intel-gw: Drop unused max_widthdrivers/pci/controller/dwc/pcie-intel-gw.c+0 -40 replies
39/40PCI: dwc: Move N_FTS setup to common setupdrivers/pci/controller/dwc/pcie-artpec6.c drivers/pci/controller/dwc/pcie-designware.c drivers/pci/controller/dwc/pcie-designware.h +2 more+35 -852 replies
40/40PCI: dwc: Use DBI accessorsdrivers/pci/controller/dwc/pcie-spear13xx.c drivers/pci/controller/dwc/pcie-tegra194.c+8 -100 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH v2 00/40] PCI: dwc: Driver clean-ups

This is a series of clean-ups for the Designware PCI driver. The series initially reworks the config space accessors to use the existing pci_ops struct. Then there's removal of various private data that's also present in the pci_host_bridge struct. There's also some duplicated common (PCI and DWC) register defines which I converted to use the common defines. Finally, the initialization for speed/gen, number of lanes, and N_FTS are all moved to the common DWC code.

This is compile tested only as I don't have any DWC based h/w, so any testing would be helpful. A branch is here[1].

Rob

[1] git://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git pci-dw-cleanups

Rob Herring (40):
PCI: Allow root and child buses to have different pci_ops
PCI: dwc: Use DBI accessors instead of own config accessors
PCI: dwc: Allow overriding bridge pci_ops
PCI: dwc: Add a default pci_ops.map_bus for root port
PCI: dwc: al: Use pci_ops for child config space accessors
PCI: dwc: keystone: Use pci_ops for config space accessors
PCI: dwc: tegra: Use pci_ops for root config space accessors
PCI: dwc: meson: Use pci_ops for root config space accessors
PCI: dwc: kirin: Use pci_ops for root config space accessors
PCI: dwc: exynos: Use pci_ops for root config space accessors
PCI: dwc: histb: Use pci_ops for root config space accessors
PCI: dwc: Remove dwc specific config accessor ops
PCI: dwc: Use generic config accessors
PCI: Also call .add_bus() callback for root bus
PCI: dwc: keystone: Convert .scan_bus() callback to use add_bus
PCI: dwc: Convert to use pci_host_probe()
PCI: dwc: Remove root_bus pointer
PCI: dwc: Remove storing of PCI resources
PCI: dwc: Simplify config space handling
PCI: dwc/keystone: Drop duplicated 'num-viewport'
PCI: dwc: Check CONFIG_PCI_MSI inside dw_pcie_msi_init()
PCI: dwc/imx6: Remove duplicate define PCIE_LINK_WIDTH_SPEED_CONTROL
PCI: dwc: Add a 'num_lanes' field to struct dw_pcie
PCI: dwc: Ensure FAST_LINK_MODE is cleared
PCI: dwc/meson: Drop the duplicate number of lanes setup
PCI: dwc/meson: Drop unnecessary RC config space initialization
PCI: dwc/meson: Rework PCI config and DW port logic register accesses
PCI: dwc/imx6: Use common PCI register definitions
PCI: dwc/qcom: Use common PCI register definitions
PCI: dwc: Remove hardcoded PCI_CAP_ID_EXP offset
PCI: dwc/tegra: Use common Designware port logic register definitions
PCI: dwc: Remove read_dbi2 code
PCI: dwc: Make ATU accessors private
PCI: dwc: Centralize link gen setting
PCI: dwc: Set PORT_LINK_DLL_LINK_EN in common setup code
PCI: dwc/intel-gw: Drop unnecessary checking of DT 'device_type'
property
PCI: dwc/intel-gw: Move getting PCI_CAP_ID_EXP offset to
intel_pcie_link_setup()
PCI: dwc/intel-gw: Drop unused max_width
PCI: dwc: Move N_FTS setup to common setup
PCI: dwc: Use DBI accessors

 drivers/pci/controller/dwc/pci-dra7xx.c       |  29 +-
 drivers/pci/controller/dwc/pci-exynos.c       |  45 +--
 drivers/pci/controller/dwc/pci-imx6.c         |  52 +--
 drivers/pci/controller/dwc/pci-keystone.c     | 126 ++-----
 drivers/pci/controller/dwc/pci-meson.c        | 156 ++-------
 drivers/pci/controller/dwc/pcie-al.c          |  70 +---
 drivers/pci/controller/dwc/pcie-artpec6.c     |  48 +--
 .../pci/controller/dwc/pcie-designware-ep.c   |  11 +-
 .../pci/controller/dwc/pcie-designware-host.c | 319 ++++++------------
 .../pci/controller/dwc/pcie-designware-plat.c |   4 +-
 drivers/pci/controller/dwc/pcie-designware.c  | 104 +++---
 drivers/pci/controller/dwc/pcie-designware.h  |  54 +--
 drivers/pci/controller/dwc/pcie-histb.c       |  45 +--
 drivers/pci/controller/dwc/pcie-intel-gw.c    |  65 +---
 drivers/pci/controller/dwc/pcie-kirin.c       |  43 +--
 drivers/pci/controller/dwc/pcie-qcom.c        |  33 +-
 drivers/pci/controller/dwc/pcie-spear13xx.c   |  39 +--
 drivers/pci/controller/dwc/pcie-tegra194.c    | 120 ++-----
 drivers/pci/controller/dwc/pcie-uniphier.c    |   3 +-
 drivers/pci/probe.c                           |  14 +-
 include/linux/pci.h                           |   1 +
 21 files changed, 443 insertions(+), 938 deletions(-)

--
2.25.1