Skip to content

ttm misc cleanups, mem refactoring, rename objects. (v2)

Dave Airlie dri-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest59 patches 76 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/59drm/vmwgfx: consolidate ttm object creation and populatedrivers/gpu/drm/vmwgfx/vmwgfx_drv.h drivers/gpu/drm/vmwgfx/vmwgfx_mob.c drivers/gpu/drm/vmwgfx/vmwgfx_ttm_buffer.c+39 -571 reply
2/59drm/vmwgfx: drop bo map/unmap dma functions.drivers/gpu/drm/vmwgfx/vmwgfx_drv.h drivers/gpu/drm/vmwgfx/vmwgfx_ttm_buffer.c+6 -421 reply
3/59nouveau: use ttm populate mapping functions. (v2)drivers/gpu/drm/nouveau/nouveau_bo.c+2 -361 reply
4/59qxl/ttm: drop the unusued no wait flag to reserve functiondrivers/gpu/drm/qxl/qxl_cmd.c drivers/gpu/drm/qxl/qxl_ioctl.c drivers/gpu/drm/qxl/qxl_object.c +1 more+6 -61 reply
5/59drm/ttm/amdgpu: consolidate ttm reserve pathsdrivers/gpu/drm/amd/amdgpu/amdgpu_object.h drivers/gpu/drm/ttm/ttm_execbuf_util.c include/drm/ttm/ttm_bo_driver.h+20 -851 reply
6/59drm/ttm: use a helper for unlocked moves to the lru taildrivers/gpu/drm/ttm/ttm_bo.c drivers/gpu/drm/ttm/ttm_bo_vm.c include/drm/ttm/ttm_bo_driver.h+11 -122 replies
7/59drm/vram-helper: remove populate/unpopulatedrivers/gpu/drm/drm_gem_vram_helper.c+0 -21 reply
8/59drm/ttm: export memory type debug entrypoint.drivers/gpu/drm/ttm/ttm_bo.c include/drm/ttm/ttm_bo_driver.h+15 -62 replies
9/59drm/nouveau/ttm: don't fill in blank ttm debug callbackdrivers/gpu/drm/nouveau/nouveau_ttm.c+0 -91 reply
10/59drm/vmwgfx/gmrid: don't provide pointless ttm debug callbackdrivers/gpu/drm/vmwgfx/vmwgfx_gmrid_manager.c+0 -70 replies
11/59drm/qxl/ttm: call ttm manager debug (v2)drivers/gpu/drm/qxl/qxl_ttm.c+4 -61 reply
12/59drm/vram-helper: call the ttm manager debug functiondrivers/gpu/drm/drm_gem_vram_helper.c+2 -42 replies
13/59drm/ttm: split the mm manager init code (v2)drivers/gpu/drm/ttm/ttm_bo.c include/drm/ttm/ttm_bo_api.h include/drm/ttm/ttm_bo_driver.h+50 -143 replies
14/59drm/ttm: provide a driver-led init path for range mm manager. (v2)drivers/gpu/drm/ttm/ttm_bo_manager.c include/drm/ttm/ttm_bo_driver.h+34 -30 replies
15/59drm/amdgpu/ttm: init managers from the driver side.drivers/gpu/drm/amd/amdgpu/amdgpu_gtt_mgr.c drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.h +1 more+33 -461 reply
16/59drm/radeon: use new ttm man init pathdrivers/gpu/drm/radeon/radeon_ttm.c+4 -61 reply
17/59drm/qxl/ttm: use new init path for managerdrivers/gpu/drm/qxl/qxl_ttm.c+1 -21 reply
18/59drm/vram_helper: use new ttm manager init functiondrivers/gpu/drm/drm_gem_vram_helper.c+1 -22 replies
19/59drm/nouveau: use new memory manager init pathsdrivers/gpu/drm/nouveau/nouveau_ttm.c+19 -241 reply
20/59drm/vmwgfx/ttm: convert vram mm init to new code pathsdrivers/gpu/drm/vmwgfx/vmwgfx_drv.c drivers/gpu/drm/vmwgfx/vmwgfx_drv.h drivers/gpu/drm/vmwgfx/vmwgfx_thp.c+28 -131 reply
21/59drm/vmwgfx/ttm: switch gmrid allocator to new init paths.drivers/gpu/drm/vmwgfx/vmwgfx_drv.c drivers/gpu/drm/vmwgfx/vmwgfx_drv.h drivers/gpu/drm/vmwgfx/vmwgfx_gmrid_manager.c+19 -211 reply
22/59drm/ttm: convert system manager init to new code.drivers/gpu/drm/ttm/ttm_bo.c+17 -131 reply
23/59drm/ttm: purge old manager init path.drivers/gpu/drm/ttm/ttm_bo.c drivers/gpu/drm/ttm/ttm_bo_manager.c include/drm/ttm/ttm_bo_api.h +1 more+10 -711 reply
24/59drm/ttm: pass man around instead of mem_type in some placesdrivers/gpu/drm/ttm/ttm_bo.c+6 -81 reply
25/59drm/ttm: make some inline helper functions for cleanup paths. (v2)drivers/gpu/drm/ttm/ttm_bo.c include/drm/ttm/ttm_bo_driver.h+28 -42 replies
26/59drm/ttm: start allowing drivers to use new takedown path (v2)drivers/gpu/drm/ttm/ttm_bo.c drivers/gpu/drm/ttm/ttm_bo_manager.c include/drm/ttm/ttm_bo_driver.h+50 -72 replies
27/59drm/amdgpu/ttm: use new takedown pathdrivers/gpu/drm/amd/amdgpu/amdgpu_gtt_mgr.c drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.h +1 more+29 -130 replies
28/59drm/vmwgfx: takedown vram managerdrivers/gpu/drm/vmwgfx/vmwgfx_drv.c drivers/gpu/drm/vmwgfx/vmwgfx_drv.h drivers/gpu/drm/vmwgfx/vmwgfx_thp.c+27 -111 reply
29/59drm/vram_helper: call explicit mm takedowndrivers/gpu/drm/drm_gem_vram_helper.c+1 -01 reply
30/59drm/nouveau: use new cleanup pathsdrivers/gpu/drm/nouveau/nouveau_ttm.c+30 -111 reply
31/59drm/radeon/ttm: use new takedown pathsdrivers/gpu/drm/radeon/radeon_ttm.c+2 -20 replies
32/59drm/qxl/ttm: use new takedown pathdrivers/gpu/drm/qxl/qxl_ttm.c+2 -21 reply
33/59drm/vmwgfx: fix gmrid takedown paths to new interfacedrivers/gpu/drm/vmwgfx/vmwgfx_drv.c drivers/gpu/drm/vmwgfx/vmwgfx_drv.h drivers/gpu/drm/vmwgfx/vmwgfx_gmrid_manager.c+13 -81 reply
34/59drm/ttm: remove range manager legacy takedown pathdrivers/gpu/drm/ttm/ttm_bo_manager.c+9 -191 reply
35/59drm/ttm: make TTM responsible for cleaning system only.drivers/gpu/drm/ttm/ttm_bo.c include/drm/ttm/ttm_bo_api.h include/drm/ttm/ttm_bo_driver.h+4 -881 reply
36/59drm/ttm: add wrapper to get manager from bdev.drivers/gpu/drm/ttm/ttm_bo.c drivers/gpu/drm/ttm/ttm_bo_util.c drivers/gpu/drm/ttm/ttm_bo_vm.c +1 more+34 -282 replies
37/59drm/amdgfx/ttm: use wrapper to get ttm memory managersdrivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c drivers/gpu/drm/amd/amdgpu/amdgpu_device.c +5 more+39 -361 reply
38/59drm/vram-helper: use wrapper to access memory managersdrivers/gpu/drm/drm_gem_vram_helper.c+3 -31 reply
39/59drm/nouveau/ttm: use wrapper to access memory managersdrivers/gpu/drm/nouveau/nouveau_ttm.c+4 -41 reply
40/59drm/qxl/ttm: use wrapper to access memory managerdrivers/gpu/drm/qxl/qxl_ttm.c+6 -51 reply
41/59drm/radeon/ttm: use wrapper to access memory managerdrivers/gpu/drm/radeon/radeon_gem.c drivers/gpu/drm/radeon/radeon_ttm.c+7 -71 reply
42/59drm/vmwgfx/ttm: use wrapper to access memory managerdrivers/gpu/drm/vmwgfx/vmwgfx_drv.c drivers/gpu/drm/vmwgfx/vmwgfx_gmrid_manager.c drivers/gpu/drm/vmwgfx/vmwgfx_thp.c+18 -131 reply
43/59drm/ttm: rename manager variable to make sure wrapper is used.drivers/gpu/drm/ttm/ttm_bo.c include/drm/ttm/ttm_bo_driver.h+6 -32 replies
44/59drm/ttm: allow drivers to provide their own manager subclassesinclude/drm/ttm/ttm_bo_driver.h+10 -12 replies
45/59drm/amdgpu/ttm: use bo manager subclassing for vram/gtt mgrsdrivers/gpu/drm/amd/amdgpu/amdgpu_gtt_mgr.c drivers/gpu/drm/amd/amdgpu/amdgpu_vram_mgr.c+44 -271 reply
46/59drm/ttm: make ttm_range_man_init/takedown take type + argsdrivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c drivers/gpu/drm/drm_gem_vram_helper.c drivers/gpu/drm/nouveau/nouveau_ttm.c +5 more+70 -652 replies
47/59drm/ttm: move range manager to subclassed driver allocationdrivers/gpu/drm/ttm/ttm_bo_manager.c+19 -121 reply
48/59drm/vmwgfx/ttm: move thp to driver manageddrivers/gpu/drm/vmwgfx/vmwgfx_thp.c+21 -111 reply
49/59drm/vmwgfx/gmrid: convert to driver controlled allocation.drivers/gpu/drm/vmwgfx/vmwgfx_gmrid_manager.c+18 -141 reply
50/59drm/nouveau/ttm: move to driver allocated managerdrivers/gpu/drm/nouveau/nouveau_ttm.c+32 -131 reply
51/59drm/ttm: drop priv pointer in memory managerinclude/drm/ttm/ttm_bo_driver.h+0 -21 reply
52/59drm/amdgpu/ttm: remove man->bdev references.drivers/gpu/drm/amd/amdgpu/amdgpu_vram_mgr.c+5 -20 replies
53/59drm/ttm: drop man->bdev link.drivers/gpu/drm/amd/amdgpu/amdgpu_gtt_mgr.c drivers/gpu/drm/amd/amdgpu/amdgpu_vram_mgr.c drivers/gpu/drm/nouveau/nouveau_ttm.c +6 more+11 -191 reply
54/59drm/ttm: drop list of memory managers from device. (v2)drivers/gpu/drm/ttm/ttm_bo.c include/drm/ttm/ttm_bo_driver.h+5 -72 replies
55/59drm/ttm: drop type manager has_typedrivers/gpu/drm/amd/amdgpu/amdgpu_gtt_mgr.c drivers/gpu/drm/amd/amdgpu/amdgpu_vram_mgr.c drivers/gpu/drm/nouveau/nouveau_ttm.c +5 more+10 -292 replies
56/59drm/ttm: add a wrapper for checking if manager is in usedrivers/gpu/drm/nouveau/nouveau_ttm.c drivers/gpu/drm/ttm/ttm_bo.c drivers/gpu/drm/vmwgfx/vmwgfx_drv.c +1 more+22 -93 replies
57/59drm/ttm: rename bo manager to range manager.drivers/gpu/drm/ttm/Makefile drivers/gpu/drm/ttm/ttm_range_manager.c+14 -142 replies
58/59drm/ttm: rename ttm_mem_type_manager -> ttm_resource_manager.drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c drivers/gpu/drm/amd/amdgpu/amdgpu_gtt_mgr.c +20 more+210 -2102 replies
59/59drm/ttm: rename ttm_mem_reg to ttm_resource.drivers/gpu/drm/amd/amdgpu/amdgpu_gtt_mgr.c drivers/gpu/drm/amd/amdgpu/amdgpu_object.c drivers/gpu/drm/amd/amdgpu/amdgpu_object.h +42 more+202 -2022 replies

Reviews trailers per patch

58 of 59 patches have a Reviewed-by or Acked-by.

PatchChristian KönigThomas ZimmermannGerd HoffmannBen SkeggsDaniel Vetter
1/59R-b
2/59R-b
3/59R-b
4/59R-b
5/59R-b
6/59R-b R-b
7/59R-b
8/59R-b R-b
9/59A-b R-b
10/59A-b
11/59R-b
12/59R-b R-b
13/59R-b
14/59v1-Reviewed-by
15/59R-b
16/59R-b
17/59R-b
18/59R-b R-b
19/59R-b
20/59R-b
21/59R-b
22/59R-b R-b
23/59R-b R-b
24/59R-b R-b
25/59R-b R-b
26/59R-b R-b
27/59R-b
28/59R-b
29/59R-b
30/59R-b
31/59R-b
32/59R-b
33/59R-b
34/59R-b R-b
35/59R-b R-b
36/59A-b R-b
37/59R-b
38/59R-b
39/59R-b
40/59R-b
41/59R-b
42/59R-b
43/59R-b R-b
44/59R-b R-b
45/59R-b
46/59R-b R-b
47/59R-b R-b
48/59R-b
49/59R-b
50/59R-b
51/59R-b R-b
52/59R-b
53/59R-b
54/59R-b R-b
55/59R-b R-b
56/59R-b R-b
57/59R-b R-b
58/59A-b R-b
59/59A-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 5 reviewers.

Read the v1 thread

Cover letter [00/59] ttm misc cleanups, mem refactoring, rename objects. (v2)

I've decided to repost the whole queue this time, it has a few driver patches up front that are just cleanups.

I've reorodered things a little since the first posting, but not much.

misc core/driver cleanups
mem type manager debug callback cleanup (reordered) new mem type manager init path
new mem type manager cleanup path
new wrapper to access managers
driver managed mem type allocations
cleanup after all of that
rename ttm_bo_manager to ttm_range_manager (new) rename ttm_mem_type_manager to ttm_resource_manager (new) rename ttm_mem_reg to ttm_resource (new)

I've marked most things with v2 that have changed, again I'd really like to land this in drm-misc sooner rather than later, so it would be good to get driver acks from qxl, vmwgfx and nouveau. (all cc'ed).

I've also commented on the list on any outstanding comments from previous review that I disagree with or need more discussion.

Dave.

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel