i2c: core: add generic GPIO bus recovery
Status from this message: Applied to for-next, thanks! Two minor change:
Get series with b4
b4 am [email protected]Versions newest first
Patches in v1 Applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/4 | dt-binding: i2c: add generic properties for GPIO bus recoveryDocumentation/ | +10 | 1 reply | |
| 2/4 | i2c: core: add generic I2C GPIO recoverydrivers/ include/ | +137 | 1 reply | |
| 3/4 | i2c: core: treat EPROBE_DEFER when acquiring SCL/SDA GPIOsdrivers/ | +14 | 1 reply | |
| 4/4 | i2c: at91: Move to generic GPIO bus recoverydrivers/ drivers/ | +3 | 1 reply |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [PATCH 0/4] i2c: core: add generic GPIO bus recovery
GPIO recovery has been added already for some I2C bus drivers, such as imx, pxa and at91. These drivers use similar bindings and have more or less the same code for recovery. For this reason, we aim to move the GPIO bus recovery implementation to the I2C core so that other drivers can benefit from it, with small modifications.
This implementation initializes the pinctrl states and the SDA/SCL GPIOs based on common bindings. The I2C bus drivers can still use different bindings or other particular recovery steps if needed. The ugly part with this patch series is the handle of PROBE_DEFER which could be returned by devm_gpiod_get(). This changes things a little for i2c_register_adapter() and for this reason this step is implemented in a sperate patch.
The at91 Microchip driver is the first to use this implementation, with an AI to move the rest of the drivers in the following steps.
This patch series was previously sent as a RFC. Significant changes since RFC:
- "recovery" pinctrl state marked as deprecared in bindings;
- move to "gpio" pinctrl state done after the call to prepare_recovery() callback;
- glitch protection when SDA gpio is taken at initialization;
Codrin Ciubotariu (4):
dt-binding: i2c: add generic properties for GPIO bus recovery
i2c: core: add generic I2C GPIO recovery
i2c: core: treat EPROBE_DEFER when acquiring SCL/SDA GPIOs
i2c: at91: Move to generic GPIO bus recovery
Documentation/devicetree/bindings/i2c/i2c.txt | 10 ++ drivers/i2c/busses/i2c-at91-master.c | 69 +------- drivers/i2c/busses/i2c-at91.h | 3 - drivers/i2c/i2c-core-base.c | 150 ++++++++++++++++-- include/linux/i2c.h | 11 ++ 5 files changed, 163 insertions(+), 80 deletions(-)
Signature · 1 line
2.25.1