Skip to content

Feifei Wang dpdk-dev 5 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v6 Latest7 patches 2 repliesIn review
  2. v57 patches 2 repliesSuperseded
  3. v47 patches 0 repliesSuperseded
Earlier versions · 2
VersionPostedPatchesRepliesStatus
v36 patches6 repliesSuperseded
v24 patches6 repliesSuperseded

Changes in v6 from the cover letter

1. Add extra parameter to the macro. (Konstantin)

Patches in v6 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/7test/ring: fix wrong parameter passed to the enqueue APIsapp/test/test_ring.h+3 -30 replies
2/7test/ring: fix wrong number of enq/deq elementsapp/test/test_ring.c+2 -20 replies
3/7test/ring: fix wrong size used in memcmpapp/test/test_ring.c+21 -100 replies
4/7test/ring: add check to validate dequeued objectsapp/test/test_ring.c+99 -360 replies
5/7test/ring: validate the return value of enq/deq elementsapp/test/test_ring.c+22 -40 replies
6/7test/ring: add new function to validate dequeue dataapp/test/test_ring.c+27 -430 replies
7/7test/ring: improve the application of macroapp/test/test_ring.c+90 -1500 replies

Reviews trailers per patch

All 7 patches have a Reviewed-by or Acked-by.

PatchRuifeng WangPhil YangHonnappa NagarahalliDharmik Thakkar
1/7R-b R-b R-b
2/7R-b R-b R-b
3/7R-b R-b R-b R-b
4/7R-b R-b R-b R-b
5/7R-b R-b
6/7R-b R-b R-b R-b
7/7R-b R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.

Read the v6 thread

Cover letter [dpdk-dev] [PATCH v6 0/7]

Several bugs in ring unit tests were identified and fixed.

Added data validation on objects after enqueue/dequeue operations for data integration check.

Unit tests were enhanced by checking return value of enqueue/dequeue operations and validating data integrity of objects.

v2:
1. add check to validate the dequeued objects in test_ring.c and fix some bugs of it. (David/Honnappa)
2. remove the patch to change the description for the param of rte_ring_[sp/mp]_enqueue APIs. (David/Konstantin/Honnappa)

v3:
1. Adjust the 'check dequeued objects' patch from the last to the first in the series. (Honnappa)
2. Add the new function 'test_ring_mem_cmp to replace 'memset' and print information of enqueue/dequeue elements if validation fails. (Honnappa)
3. Add test to validate the whether the enqueue and dequeue operation is successful for each time. (Honnappa)
4. Expand the scope of application for the macro TEST_RING_VERIF, and replace all ring APIs check with this macro. (Honnappa)

v4:
1. Split the 'memcmp' bug fix patch into two patches, one is memcmp issue patch, the other is to add new function 'test_ring_mem_cmp'. (Honnappa)

v5:
1. Adjust bug fixed patches to the first of the series, to ensure that the back porting will go smooth. (Honnappa)

v6:
1. Add extra parameter to the macro. (Konstantin)

Feifei Wang (7):
test/ring: fix wrong parameter passed to the enqueue APIs test/ring: fix wrong number of enq/deq elements test/ring: fix wrong size used in memcmp test/ring: add check to validate dequeued objects test/ring: validate the return value of enq/deq elements test/ring: add new function to validate dequeue data test/ring: improve the application of macro

 app/test/test_ring.c | 362 ++++++++++++++++++++++---------------------
 app/test/test_ring.h |   6 +-
 2 files changed, 192 insertions(+), 176 deletions(-)
Signature · 1 line
2.17.1