stubs: Fix notify-event stub linkage error on MinGW
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v3 Latest2 patches 4 repliesIn review
- v22 patches 6 repliesSuperseded
Changes in v3 from the cover letter
- Remove incorrectly added abort() in qemu_timer_notify_cb()
Patches in v3 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/2 | exec: Restrict icount to softmmuexec.c include/ softmmu/ | +11 | 3 replies | |
| 2/2 | stubs: Remove qemu_notify_event()stubs/ stubs/ stubs/ | +1 | 0 replies |
Reviews trailers per patch
1 of 2 patches has a Reviewed-by or Acked-by.
| Patch | Richard Henderson |
|---|---|
| 1/2 | R-b |
| 2/2 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH-for-5.1 v3 0/2] stubs: Fix notify-event stub linkage error on MinGW
2 trivial patches to fix the link error reported by Thomas:
LINK tests/test-timed-average.exe
libqemuutil.a(main-loop.o): In function `qemu_notify_event':
util/main-loop.c:139: multiple definition of `qemu_notify_event' tests/test-timed-average.o:/builds/huth/qemu/tests/../stubs/notify-event.c:5: first defined here
collect2: error: ld returned 1 exit status
rules.mak:124: recipe for target 'tests/test-timed-average.exe' failed
Since v2:
- Remove incorrectly added abort() in qemu_timer_notify_cb()
Philippe Mathieu-Daudé (2):
exec: Restrict icount to softmmu
stubs: Remove qemu_notify_event()
include/sysemu/cpus.h | 4 ++++ exec.c | 4 ---- softmmu/cpus.c | 7 +++++++ stubs/cpu-get-icount.c | 2 +- stubs/notify-event.c | 6 ------ stubs/Makefile.objs | 1 - 6 files changed, 12 insertions(+), 12 deletions(-) delete mode 100644 stubs/notify-event.c
Signature · 1 line
2.21.3