Fixes for usbip and specialised USB driver selection
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v3 Latest4 patches 11 repliesIn review
- v11 patch 4 repliesSuperseded
Patches in v3 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/4 | Revert "usbip: Implement a match function to fix usbip"drivers/ | +0 | 1 reply | |
| 2/4 | usbcore/driver: Fix specific driver selectiondrivers/ | +1 | 0 replies | |
| 3/4 | usbcore/driver: Fix incorrect downcastdrivers/ | +2 | 3 replies | |
| 4/4 | usbcore/driver: Accommodate usbipdrivers/ | +31 | 2 replies |
Reviews trailers per patch
2 of 4 patches have a Reviewed-by or Acked-by.
| Patch | Andrey Konovalov | Shuah Khan | Brooke Basile |
|---|---|---|---|
| Series | T-b | T-b | |
| 1/4 | A-b | ||
| 2/4 | |||
| 3/4 | |||
| 4/4 | A-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.
Cover letter [PATCH v3 0/4] Fixes for usbip and specialised USB driver selection
Hello all,
This is the third version of the patch sets originally published in the e-mail thread thread at [1]. As mentioned in the same e-mail thread with the e-mail at [2], I was able to find a more acceptable solution to the issue reported by Andrey Konovalov, where usbip takes over the dummy_hcd-provided devices set up by the USB fuzzing instance of the syzkaller fuzzer.
In summary, the approach involves:
* Removal of the usbip_match function.
* Fixing two bugs in the specialised USB driver selection code.
* Accommodating usbip by changing the logic in the specialised USB driver selection code, while preserving legacy/previous behaviour.
I have tested this patch set with Greg Kroah-Hartman's usb-next tree based on v5.9-rc6 with the base commit mentioned below in this e-mail, and I can report that usbip works as expected, with no regressions in the usbip_test.sh self-test suite output compared to v4.14.119. I have also verified that the apple-mfi-fastcharge driver is correctly used when an iPhone is plugged in to my system. Finally, I can report that Andrey Konovalov's "keyboard" test program making use of dummy_hcd, found at [3], also works as expected.
I would appreciate your comments.
Thank you,
Vefa
[1] https://lore.kernel.org/linux-usb/CAAeHK+zOrHnxjRFs=OE8T=O9208B9HP_oo8RZpyVOZ9AJ54pAA@mail.gmail.com/
[2] https://lore.kernel.org/linux-usb/[email protected]/
[3] https://github.com/xairy/raw-gadget
M. Vefa Bicakci (4):
Revert "usbip: Implement a match function to fix usbip" usbcore/driver: Fix specific driver selection usbcore/driver: Fix incorrect downcast usbcore/driver: Accommodate usbip
drivers/usb/core/driver.c | 50 ++++++++++++++++++++++++------------ drivers/usb/usbip/stub_dev.c | 6 ----- 2 files changed, 34 insertions(+), 22 deletions(-)
base-commit: 55be22adf11b48c80ea181366685ec91a4700b7e
Signature · 1 line
2.26.2